From acdb4477f75f728da8c96606acaa57e792e287c1 Mon Sep 17 00:00:00 2001 From: Dean Herbert Date: Mon, 26 Jan 2026 18:10:04 +0900 Subject: [PATCH] Fix logs failing to export after multiple failure attempts on file locks (#36469) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Even if one file fails, we usually don't care and still want the archive to finish exporting. Closes https://github.com/ppy/osu/issues/36446 --------- Co-authored-by: Bartłomiej Dach --- .../Overlays/Settings/Sections/General/QuickActionSettings.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/osu.Game/Overlays/Settings/Sections/General/QuickActionSettings.cs b/osu.Game/Overlays/Settings/Sections/General/QuickActionSettings.cs index 3293242418..4f988d667f 100644 --- a/osu.Game/Overlays/Settings/Sections/General/QuickActionSettings.cs +++ b/osu.Game/Overlays/Settings/Sections/General/QuickActionSettings.cs @@ -102,7 +102,7 @@ namespace osu.Game.Overlays.Settings.Sections.General using (var zip = ZipArchive.Create()) { foreach (string? f in logStorage.GetFiles(string.Empty, "*.log")) - FileUtils.AttemptOperation(z => z.AddEntry(f, logStorage.GetStream(f), true), zip); + FileUtils.AttemptOperation(z => z.AddEntry(f, logStorage.GetStream(f), closeStream: true), zip, throwOnFailure: false); zip.SaveTo(outStream); }