64429 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Bartłomiej Dach	017003deea	Fix osu! standardised score conversion sometimes exceeding bounds ... Co-authored-by: Zyf <zyfarok@gmail.com> Closes https://github.com/ppy/osu/issues/25860 Users reported that some stable scores would convert to large negative total scores in lazer after the introduction of combo exponent. Those large negative total scores were actually mangled NaNs. The root cause of this was the following calculation going below zero unexpectedly: 8e8d9b2cd9/osu.Game/Database/StandardisedScoreMigrationTools.cs (L323) which then propagates negative numbers onward until 8e8d9b2cd9/osu.Game/Database/StandardisedScoreMigrationTools.cs (L337) which yields a NaN due to attempting to take the square root of a negative number. To fix, clamp `comboPortionInScoreV1` to sane limits: to `comboPortionFromLongestComboInScoreV1` from below, and to `maximumAchievableComboPortionInScoreV1` from above. This is a less direct fix than perhaps imagined, but it seems like a better one as it will also affect the calculation of both the lower and the upper estimate of the score.	2023-12-18 22:05:19 +01:00
Bartłomiej Dach	8e8d9b2cd9	Merge pull request #25832 from peppy/more-background-processing-progress-notifications ... Show more comprehensive background processing progress notifications	2023-12-18 20:05:47 +01:00
Bartłomiej Dach	b8bcf7a097	Merge pull request #25856 from peppy/fix-keybaord-adjust-nc-dc ... Fix keyboard precision of nightcore/daycore adjustments being incorrect	2023-12-18 19:54:17 +01:00
Dean Herbert	9594ae7802	Update framework	2023-12-19 03:22:22 +09:00
Dean Herbert	374425ea75	Fix keyboard precision of nightcore/daycore adjustments being incorrect ... Closes https://github.com/ppy/osu/issues/25854.	2023-12-19 01:07:33 +09:00
Dean Herbert	c466775f78	Merge pull request #25821 from bdach/fix-collection-dropdown-crash ... Fix collections dropdown crashing during storage migration	2023-12-19 01:01:23 +09:00
Dean Herbert	c88c25e77f	Merge pull request #25848 from 65-7a/dropdown-search-padding ... Fix padding on dropdown search bar	2023-12-19 00:36:14 +09:00
Dean Herbert	da658bbf25	Merge pull request #25839 from bdach/collection-name-clashes-crashes ... Fix crash when creating collections named "All beatmaps" or "Manage collections..."	2023-12-19 00:32:18 +09:00
Dean Herbert	9aaaa12809	Don't show progress notifications when there are too few items to be worthwhile	2023-12-19 00:01:09 +09:00
65-7a	17f1f8bb43	Fix padding on dropdown search bar	2023-12-19 00:28:23 +11:00
Bartłomiej Dach	eeeb5aa3d4	Fix crash when creating collections named "All beatmaps" or "Manage collections..." ... Closes https://github.com/ppy/osu/issues/25834 The name fallback that was there previously since https://github.com/ppy/osu/pull/11892 was half broken. This way should be a lot less prone to failure.	2023-12-18 12:52:39 +01:00
Bartłomiej Dach	be16e0e538	Add failing test for adding collection w/ name colliding w/\ default items	2023-12-18 12:47:42 +01:00
Bartłomiej Dach	41f5a6e292	Merge pull request #25833 from peppy/fix-song-select-position-reset ... Fix song select's carousel scroll position getting reset on background processing	2023-12-18 12:27:48 +01:00
Dean Herbert	03ac2c3094	Remove some excessive logging	2023-12-18 19:20:57 +09:00
Dean Herbert	62444c3d04	Fix song select's carousel scroll position getting reset on background processing ... This only happened for users using absolute right-click scroll.	2023-12-18 19:17:59 +09:00
Dean Herbert	e3251b40b3	Fix progress notifications queueing up infinite text changes when not visible	2023-12-18 19:00:44 +09:00
Dean Herbert	5ab3815123	Add logging of progress every so often	2023-12-18 18:45:49 +09:00
Dean Herbert	bfa90e9dcb	Also populate ObjectCounts when running a full beatmap process ... Saves running things twice on an old install	2023-12-18 18:41:41 +09:00
Dean Herbert	e7d1cf7868	Add progress notifications for background tasks which don't already have them	2023-12-18 18:41:41 +09:00
Dean Herbert	7462a9f4ab	Add helper method to handle progress notifications for background jobs	2023-12-18 18:41:41 +09:00
Dan Balasescu	27ae7d77f4	Merge pull request #25823 from cl8n/taiko-random-mod-legacy-conversion ... Don't convert TaikoModRandom to/from legacy mods	2023-12-18 18:27:35 +09:00
Bartłomiej Dach	ef230884a8	Fix collections dropdown crashing during storage migration ... Closes https://github.com/ppy/osu/issues/25815. `CollectionDropdown.collectionsChanged()` was assuming that if it received `null` changes, then it must mean that the change subscription is being initialised and the `filters` list will not contain any items. However, that is not the only circumstance wherein a realm subscription can fire with `null` changes; that can also happen after the main realm instance gets recycled via the notification registration flow: 2f28a92f0a/osu.Game/Database/RealmAccess.cs (L545-L549) 2f28a92f0a/osu.Game/Database/RealmAccess.cs (L1228-L1251) Therefore, to fix the crash, just ensure that the list is cleared every time.	2023-12-18 09:11:00 +01:00
clayton	f84c181573	Don't convert TaikoModRandom to/from legacy mods	2023-12-17 23:47:50 -08:00
Dean Herbert	2f28a92f0a	Merge pull request #25776 from smoogipoo/slider-late-hit-lenience ... Add slider head circle late hit lenience	2023-12-18 13:05:31 +09:00
Dean Herbert	92c33f2057	Merge pull request #25808 from smoogipoo/fix-scoring-attribs-maxcombo ... Populate MaxCombo scoring attrib for non-osu rulesets	2023-12-18 12:25:06 +09:00
Dan Balasescu	30116512ca	Populate MaxCombo scoring attrib for non-osu rulesets	2023-12-18 12:01:51 +09:00
Dean Herbert	deef7dae1d	Merge pull request #25797 from smoogipoo/osu-ruleset-lazer-hp ... Make osu! ruleset once again use the lazer default HP drain	2023-12-17 22:22:43 +09:00
Dan Balasescu	04d542105f	Fix assertions	2023-12-17 21:52:21 +09:00
Dan Balasescu	2b33aec124	Require slider head to be judged before ticks	2023-12-17 21:26:48 +09:00
Dan Balasescu	fddfa33e49	Fix 1-frame issues due to referencing external value	2023-12-17 20:19:25 +09:00
Dan Balasescu	9b02bd712b	Only track if in slider ball after any ticks missed	2023-12-17 20:12:02 +09:00
Dan Balasescu	fbe48d7be8	Fix tail being missed too early	2023-12-17 20:11:15 +09:00
Dan Balasescu	f77884b62f	Only hit passed-through ticks if none were missed	2023-12-17 19:57:48 +09:00
Dan Balasescu	10610d3387	Rename test scene	2023-12-17 19:33:38 +09:00
Dan Balasescu	4b9aefa6f2	Change osu ruleset to use new HP algorithm by default	2023-12-17 19:33:04 +09:00
Dan Balasescu	d7aca2f641	Add IApplicableHealthProcessor	2023-12-17 19:27:03 +09:00
Dean Herbert	c0e96927aa	Merge branch 'master' into slider-late-hit-lenience	2023-12-17 13:00:01 +09:00
Dean Herbert	7573e316bf	Merge pull request #25775 from peppy/more-import-lenience ... Allow new common cases when a user is locating a stable osu! install directory for import	2023-12-17 12:12:06 +09:00
Dean Herbert	b0814400c2	Merge pull request #25787 from cl8n/fix-mania-column-color ... Fix fallback column colors for legacy split stage mania skins	2023-12-16 20:19:02 +09:00
clayton	f07771f59b	Fix fallback column colors for legacy split stage mania skins	2023-12-15 22:41:55 -08:00
Bartłomiej Dach	7caca905e3	Merge pull request #25777 from peppy/fix-tablet-mania-column-sizing ... Fix column sizing exceeding screen width on tablets	2023-12-15 21:28:23 +01:00
Bartłomiej Dach	df887abae9	Merge branch 'master' into fix-tablet-mania-column-sizing	2023-12-15 20:58:34 +01:00
Bartłomiej Dach	432ce275c4	Explain magic constants better	2023-12-15 20:43:18 +01:00
Bartłomiej Dach	285284eb34	Merge branch 'master' into more-import-lenience	2023-12-15 16:02:44 +01:00
Bartłomiej Dach	91f4123aa7	Fix first run locator stable locator directory desyncing between display & popover	2023-12-15 16:00:34 +01:00
Dan Balasescu	acb7016156	Remove unused using	2023-12-15 23:53:26 +09:00
Bartłomiej Dach	b384c9f938	Extract common method for determining stable import usability of directory	2023-12-15 15:42:19 +01:00
Dean Herbert	94f63d6044	Update resources	2023-12-15 19:18:53 +09:00
Dean Herbert	e8f3e52c9e	Fix nullref failure in tests	2023-12-15 19:17:48 +09:00
Dean Herbert	eb5a8284f1	Move mobile check earlier to avoid unnecessary looping	2023-12-15 19:16:18 +09:00