Dean Herbert
cc3bb590c9
Remove pointless comment
2025-02-01 14:48:13 +09:00
Salman Alshamrani
64b67252a2
Enable NRT on Column
2025-01-30 08:22:35 -05:00
Dean Herbert
e8d20fb402
Fix skin SourceChanged event never being unbound
2025-01-29 18:16:04 +09:00
Salman Alshamrani
ffc37cece0
Avoid extra unnecessary DI
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2025-01-25 19:12:42 -05:00
Salman Alshamrani
8151c3095d
Revert unnecessary inheritance
...
Everyone is right, too much inheritance and polymorphism backfires very badly.
2025-01-25 19:12:37 -05:00
Salman Alshamrani
b63d94101c
Reapply "Fix triangles judgement mispositioned on a miss"
...
This reverts commit 6ec718304e
2025-01-21 05:45:37 -05:00
Salman Alshamrani
6ec718304e
Revert "Fix triangles judgement mispositioned on a miss"
...
This reverts commit e5713e5239
2025-01-21 04:58:27 -05:00
Salman Alshamrani
c1ac27d658
Fix failing tests
...
- Caches `DrawableRuleset` in editor compose screen for mania playfield adjustment container (because it's used to wrap the blueprint container as well)
- Fixes `ManiaModWithPlayfieldCover` performing a no-longer-correct direct cast with a naive-but-working approach.
2025-01-12 22:56:40 -05:00
Salman Alshamrani
a241d1f503
Fix DrawableManiaRuleset not cached as itself in subtypes
...
i.e. editor mania ruleset
2025-01-04 02:36:06 -05:00
Salman Alshamrani
e5713e5239
Fix triangles judgement mispositioned on a miss
...
Similar to mania's `ArgonJudgementPiece`.
2024-12-31 21:31:54 -05:00
Salman Alshamrani
64e557d00f
Simplify portrait check
2024-12-31 20:01:21 -05:00
Salman Alshamrani
bea61d2483
Replace ManiaTouchInputArea with touchable columns
2024-12-31 12:28:04 -05:00
Salman Alshamrani
1e08b3dbda
Make mania judgements relative to the hit target position
...
This improves display in portrait screen, where the stage is scaled up.
2024-12-31 12:25:58 -05:00
Salman Alshamrani
9d08bc2b50
Improve osu!mania gameplay scaling on portrait orientation
2024-12-31 12:25:58 -05:00
Dean Herbert
29757ffdf2
Allow setting osu!mania scroll speed to single decimal precision
...
Addresses https://github.com/ppy/osu/discussions/30663 .
2024-11-22 17:36:28 +09:00
Bartłomiej Dach
15a8cfe685
Fix mania notes disappearing on seek to their end time
2024-11-18 14:37:09 +01:00
Salman Alshamrani
3268008d21
Fix stage line alignment in mania not matching stable
2024-11-12 04:07:27 -05:00
Dan Balasescu
7f41d5f4e7
Remove mouse input from mania touch controls
2024-08-30 16:32:15 +09:00
Dean Herbert
2221c4891f
Remove legacy non-pooled pathway to DrawableJudgement
2024-08-13 21:03:00 +09:00
clayton
5ad255ecbe
Remove special actions from Stage constructor
2024-08-07 14:36:04 -07:00
Bartłomiej Dach
92dc125d39
Match mania editor playfield time range with timeline zoom
2024-07-10 17:36:39 +02:00
Salman Ahmed
371ca4cc4b
Remove unnecessary null-conditional operators
2024-07-04 05:43:43 +03:00
Bartłomiej Dach
97de73b99c
Do not change mania column width on mobile platforms
...
- Closes https://github.com/ppy/osu/issues/25852
- Reverts https://github.com/ppy/osu/pull/25336 /
https://github.com/ppy/osu/pull/25777
With the columns not being directly touchable anymore after
https://github.com/ppy/osu/pull/28173 I see very little point to this
continuing to exist.
2024-05-16 08:21:52 +02:00
Dean Herbert
5c9a90cb40
Tidy class and change to be a VisibilityContainer similar to taiko implementation
2024-05-14 22:34:05 +08:00
Dean Herbert
390557634a
Rename touch area class to match existing usage (see taiko)
2024-05-14 22:34:05 +08:00
Dean Herbert
12e98fe55d
Move out of playfield so touch overlay is not affected by playfield position
2024-05-14 22:34:05 +08:00
Dan Balasescu
a761a7bced
Hook up touch device mod
2024-05-14 19:14:58 +08:00
Dan Balasescu
e3f2e1ba08
Add opacity setting
2024-05-14 19:14:50 +08:00
Dan Balasescu
39337f5189
Hook up input manager
2024-05-14 19:14:50 +08:00
Dan Balasescu
ef40197713
Add mania touch overlay
...
Adjust default anchor/origin
2024-05-14 19:14:50 +08:00
Dan Balasescu
4f6777a0a1
Remove existing per-column touch input
2024-05-14 19:10:14 +08:00
Dan Balasescu
0beaa8e8c5
Merge branch 'master' into tcm-resume
2024-03-14 12:22:46 +09:00
Andrei Zavatski
e9aca9226a
Reduce allocations in ManiaPlayfield.TotalColumns
2024-02-20 19:10:03 +03:00
Bartłomiej Dach
4b2197039c
Make dropdown text nicer
2024-02-15 16:40:58 +01:00
Dan Balasescu
878fb2d10d
Add break support
2024-02-15 22:05:25 +09:00
Dan Balasescu
dcb195f3c8
Add delayed resume for taiko/catch/mania
2024-02-08 02:16:08 +09:00
Dan Balasescu
8f995a30af
Fix legacy coverage metrics
2024-02-08 00:20:32 +09:00
Dan Balasescu
bacb1d0dc7
Add easing to make the transition less awkward
2024-02-06 23:58:27 +09:00
Dan Balasescu
5265d33c12
Make coverage into a bindable
2024-02-06 23:33:00 +09:00
Bartłomiej Dach
8b9c9f4fed
Add NRT annotations to DrawableManiaRuleset
2024-02-05 14:52:08 +01:00
Andrei Zavatski
e00e583bb4
Fix DrawableManiaRuleset performing skin lookup every frame
2024-02-02 03:56:38 +03:00
Andrei Zavatski
8e20eed4ef
Don't use LINQ in ReceivePositionalInputAt
2024-01-30 03:19:27 +03:00
Andrei Zavatski
7dba870518
Rework Content storage in ColumnFlow
2024-01-30 03:07:37 +03:00
Dean Herbert
e9812fac7a
Fix osu!mania judgments not being pooled correctly
2024-01-15 20:50:09 +09:00
Dan Balasescu
2ec6aa7fbb
Make mania scroll speed independent of hit position
2023-12-26 12:46:21 +09:00
Dan Balasescu
104fbbde94
Change mania scoring to match ScoreV2
2023-12-20 18:35:45 +09:00
Bartłomiej Dach
432ce275c4
Explain magic constants better
2023-12-15 20:43:18 +01:00
Dean Herbert
e8f3e52c9e
Fix nullref failure in tests
2023-12-15 19:17:48 +09:00
Dean Herbert
eb5a8284f1
Move mobile check earlier to avoid unnecessary looping
2023-12-15 19:16:18 +09:00
Dean Herbert
456916f680
Fix column sizing exceeding screen width on tablets
2023-12-15 18:02:27 +09:00
