Bartłomiej Dach 12cc8e38da Fix replays being misrecorded if an action is pressed and released in one update frame ...

Closes https://github.com/ppy/osu/issues/33465 probably.

This reverts the replay frame de-duplication logic to what it was before
https://github.com/ppy/osu/pull/33148#discussion_r2091549388.

I don't have good reproduction steps. I tried to write a test case for
this that isn't just "press and release a key in the same frame",
thinking that maybe there was some loophole in the osu! touch input
mapper that may produce this situation artificially, but I could not in
many configurations. So I have to assume that this just *can happen*
organically.

12cc8e38da · 2025-06-06 09:10:51 +02:00

History

..

Audio

…

Beatmaps

Make BeatmapDifficultyCache's returned bindable non-nullable

2025-05-25 22:27:37 +09:00

Chat

Avoid ChatAckRequest failures flooding console in OsuGameTestScenes

2024-05-30 17:37:55 +09:00

Collections/IO

…

Database

Attempt to fix intermittent BackgroundDataStoreProcessor tests

2025-03-21 15:37:54 +09:00

Editing

Isolate EditorBeatmap instance to fix flaky tests

2025-06-03 19:15:15 +09:00

Extensions

Add failing test

2025-04-18 11:23:20 +02:00

Gameplay

Make CreateJudgement public again and add remarks

2024-02-16 20:24:02 +03:00

Input

Rename enum to non-plural now that it won't conflict

2024-10-01 19:55:46 +09:00

Localisation

…

Models

Make ScoreInfo.BeatmapInfo nullable

2023-07-04 14:50:34 +09:00

Mods

Adjust test cases to pass

2025-06-05 15:01:26 +02:00

NonVisual

Fix replays being misrecorded if an action is pressed and released in one update frame

2025-06-06 09:10:51 +02:00

Online

Make test headless

2025-03-25 16:19:46 +09:00

OnlinePlay

Add RNG seed

2025-03-18 16:24:01 +09:00

Resources

Merge branch 'master' into gameplay-leaderboard-skinnable

2025-04-28 13:11:22 +02:00

Rulesets

Add demonstrative test coverage of combo accounting being order-agnostic

2025-05-20 12:28:28 +02:00

Scores/IO

Add failing test

2025-04-17 10:05:57 +02:00

ScrollAlgorithms

…

Skins

Fix the same test that I forget to update every time

2025-04-24 13:32:51 +02:00

Testing

…

Utils

Merge branch 'master' into selection-center

2024-09-27 09:30:36 +02:00

Visual

Fix replays being misrecorded if an action is pressed and released in one update frame

2025-06-06 09:10:51 +02:00

CodeAnalysis.tests.globalconfig

Convert legacy ruleset to globalconfig

2024-11-28 19:34:56 +08:00

ImportTest.cs

Fix ImportTest.TestOsuGameBase having null ruleset

2024-02-11 11:16:54 +03:00

osu.Game.Tests.csproj

Add MultiplayerPlaylistItem copy constructor + tests

2025-03-14 18:50:45 +09:00

WaveformTestBeatmap.cs

Remove another similar finaliser

2025-06-03 20:48:36 +09:00