h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2026-06-04 04:13:37 +08:00
Code Issues Releases Wiki Activity

Add demonstrative test coverage of combo accounting being order-agnostic

Browse Source
This commit is contained in:
Bartłomiej Dach
2025-05-19 14:55:30 +02:00
Unverified
parent 237de1ef72
commit 1576001491
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
osu.Game.Tests/Rulesets/Scoring/ScoreProcessorTest.cs
+8 -2
View File
@@ -422,7 +422,7 @@ namespace osu.Game.Tests.Rulesets.Scoring
}
[Test]
public void TestComboAccounting()
public void TestComboAccounting([Values] bool shuffleResults)
{
var testBeatmap = new Beatmap
{
@@ -467,7 +467,13 @@ namespace osu.Game.Tests.Rulesets.Scoring
Assert.That(scoreProcessor.Combo.Value, Is.EqualTo(14));
Assert.That(scoreProcessor.HighestCombo.Value, Is.EqualTo(25));
foreach (var result in Enumerable.Reverse(results))
// random shuffle is VERY extreme and overkill.
// it might not work correctly for any other `ScoreProcessor` property, and the intermediate results likely make no sense.
// the goal is only to demonstrate idempotency to zero when reverting all results.
var random = new Random(20250519);
var toRevert = shuffleResults ? results.OrderBy(_ => random.Next()).ToList() : Enumerable.Reverse(results);
foreach (var result in toRevert)
scoreProcessor.RevertResult(result);
Assert.That(scoreProcessor.Combo.Value, Is.Zero);