1
0
mirror of https://github.com/ppy/osu.git synced 2024-09-21 22:07:25 +08:00
osu-lazer/osu.Game.Rulesets.Osu
Dean Herbert 87570ed238 Fix incorrect slider stacking on very old beatmaps
Closes https://github.com/ppy/osu/issues/24185

The stable code has had a bug in this logic forever. So we'll need to
reimplement the bug.

Basically, sliders have to have `UpdateCalculations` run in order to
have a correct `Position2` and `EndTime`, but this wasn't being called
in the inner loop before use of `EndTime` at
1531237b63/osu!/GameplayElements/HitObjectManager.cs#L1813.

To fix this, we use `StartTime` in the inner loop to reproduce the bug.
2023-07-12 17:35:03 +09:00
..
Beatmaps Fix incorrect slider stacking on very old beatmaps 2023-07-12 17:35:03 +09:00
Configuration Add basic structural requirements for cursor ripples 2023-04-30 14:48:03 +09:00
Difficulty ILegacyScoreProcessor -> ILegacyScoreSimulator 2023-07-04 17:32:54 +09:00
Edit Manual fixes to reduce warnings to zero 2023-06-24 01:52:53 +09:00
Judgements Automated pass 2023-06-24 01:00:03 +09:00
Mods Fix slider tails receiving wrong colours 2023-06-19 17:47:01 +02:00
Objects Replace various local implementations of rewinding checks with new property 2023-07-07 15:21:24 +09:00
Properties Automated pass 2023-06-24 01:00:03 +09:00
Replays Use new ArgumentNullException.ThrowIfNull throw-helper API 2022-12-22 21:27:59 +01:00
Resources/Testing/Beatmaps Add failing test cases covering NaN-timing-point sliders 2023-07-08 23:24:38 +02:00
Scoring Add back required override to make AccuracyHeatmap work 2023-06-01 13:26:47 +09:00
Skinning Adjust adjustment to 1px based on review feedback 2023-06-12 14:24:39 +09:00
Statistics Adjust text and alignment 2023-05-23 16:21:56 +09:00
UI Automated pass 2023-06-24 01:00:03 +09:00
Utils Automated pass 2023-06-24 01:00:03 +09:00
osu.Game.Rulesets.Osu.csproj Update language version 2023-02-25 02:15:56 +09:00
OsuInputManager.cs Add note about CheckScreenSpaceActionPresJudgeable being naive 2023-01-25 15:03:47 +09:00
OsuRuleset.cs Implement back-and-forth conversion of ModScoreV2 and LegacyMods 2023-07-09 16:15:21 +02:00
OsuSkinComponentLookup.cs Add "Component" prefix to lookup naming 2022-11-09 17:46:43 +09:00
OsuSkinComponents.cs Implement ripples (legacy and default) 2023-04-30 14:48:03 +09:00