Bartłomiej Dach a9facc076f Fix difficulty creation flow failing for some ruleset combinations ... In current `master`, the difficulty creation flow would retrieve a "reference beatmap" to copy metadata and timing points from using `GetPlayableBeatmap()`. But, importantly, it was calling that method using *the ruleset of the new difficulty* rather than the ruleset of the existing one. This would make the difficulty creation flow fail if the beatmap couldn't be converted between rulesets (like taiko to catch). Fixing to use the reference beatmap's actual ruleset would be trivial, but there's no real reason to do all of that work anyway when a `WorkingBeatmap` is available. Because getting a playable beatmap is not required to copy across metadata and timing points, remove the `GetPlayableBeatmap()` step entirely to fix the bug. Closes #22145.		2023-01-14 19:46:55 +01:00
..
ControlPoints	Use new ArgumentNullException.ThrowIfNull throw-helper API	2022-12-22 21:27:59 +01:00
Drawables	Merge branch 'master' into overlay-panels-context-menu	2023-01-09 19:04:56 +09:00
Formats	Fix editor exporting beatmap combo colours in wrong order	2023-01-03 13:41:08 +03:00
Legacy	Update parameter discards	2022-06-24 21:26:19 +09:00
Timing	Remove various simple obsoletions	2022-10-28 13:20:58 +09:00
APIFailTimes.cs	Automated #nullable processing	2022-06-17 16:37:17 +09:00
Beatmap.cs	Fix two implementation oversights	2022-12-02 16:05:14 +09:00
BeatmapConverter.cs	Fix control points not being cloned when running beatmap conversion	2022-11-01 17:42:09 +09:00
BeatmapDifficulty.cs	Automated #nullable processing	2022-06-17 16:37:17 +09:00
BeatmapDifficultyCache.cs	Partial everything	2022-11-27 00:00:27 +09:00
BeatmapImporter.cs	Fix incorrect ConfigureAwait call in ImportAsUpdate	2022-12-16 18:54:56 +09:00
BeatmapInfo.cs	Remove various simple obsoletions	2022-10-28 13:20:58 +09:00
BeatmapInfoExtensions.cs	Add extension methods for case insensitive file lookups	2022-08-10 15:48:25 +09:00
BeatmapManager.cs	Fix difficulty creation flow failing for some ruleset combinations	2023-01-14 19:46:55 +01:00
BeatmapMetadata.cs	Add more comprehensive xmldoc for beatmap model classes	2022-07-28 15:41:28 +09:00
BeatmapMetadataInfoExtensions.cs	Automated #nullable processing	2022-06-17 16:37:17 +09:00
BeatmapModelDownloader.cs	Add ImportAsUpdate method to IModelImporter to avoid otehr changes	2022-07-26 15:49:04 +09:00
BeatmapOnlineChangeIngest.cs	Partial everything	2022-11-27 00:00:27 +09:00
BeatmapOnlineStatus.cs	Add localisation support for local modification strings	2022-08-02 16:30:14 +09:00
BeatmapProcessor.cs	Automated #nullable processing	2022-06-17 16:37:17 +09:00
BeatmapSetHypeStatus.cs	Automated #nullable processing	2022-06-17 16:37:17 +09:00
BeatmapSetInfo.cs	Migrate the majority of existing file lookups to use new extension methods	2022-08-10 16:01:16 +09:00
BeatmapSetInfoExtensions.cs	Match class name to file	2022-08-10 19:53:40 +09:00
BeatmapSetNominationStatus.cs	Automated #nullable processing	2022-06-17 16:37:17 +09:00
BeatmapSetOnlineAvailability.cs	Automated #nullable processing	2022-06-17 16:37:17 +09:00
BeatmapSetOnlineCovers.cs	Fix tournament population failure when beatmap is not found on server	2022-09-01 22:03:01 +09:00
BeatmapSetOnlineGenre.cs	Automated #nullable processing	2022-06-17 16:37:17 +09:00
BeatmapSetOnlineLanguage.cs	Automated #nullable processing	2022-06-17 16:37:17 +09:00
BeatmapSetOnlineNomination.cs	Move and rename nomination response model to singular	2023-01-07 10:54:48 -08:00
BeatmapStatistic.cs	Automated #nullable processing	2022-06-17 16:37:17 +09:00
BeatmapStatisticIcon.cs	Partial everything	2022-11-27 00:00:27 +09:00
BeatmapUpdater.cs	Rename parameter to read better (and still use local cache if no online API is available)	2022-07-28 17:08:59 +09:00
BeatmapUpdaterMetadataLookup.cs	Fix the MOTHERLOAD of undetected issues that are now visible thanks to net6.0	2022-12-16 18:16:26 +09:00
BeatmapUserSettings.cs	Automated #nullable processing	2022-06-17 16:37:17 +09:00
BeatSyncProviderExtensions.cs	Replace parantheses with nullable-bool equality operation	2022-08-03 20:11:08 +03:00
CountdownType.cs	Automated #nullable processing	2022-06-17 16:37:17 +09:00
DifficultyRating.cs	Automated #nullable processing	2022-06-17 16:37:17 +09:00
DifficultyRecommender.cs	Fix the MOTHERLOAD of undetected issues that are now visible thanks to net6.0	2022-12-16 18:16:26 +09:00
DummyWorkingBeatmap.cs	Reduce calls to LoadTrack by implicitly running on test/dummy classes	2022-07-28 18:11:40 +09:00
FlatFileWorkingBeatmap.cs	Automated #nullable processing	2022-06-17 16:37:17 +09:00
FramedBeatmapClock.cs	Partial everything	2022-11-27 00:00:27 +09:00
IBeatmap.cs	Fix multiple instances of last hitobject time being calculated incorrectly	2022-12-01 18:04:06 +09:00
IBeatmapConverter.cs	Automated #nullable processing	2022-06-17 16:37:17 +09:00
IBeatmapDifficultyInfo.cs	Automated #nullable processing	2022-06-17 16:37:17 +09:00
IBeatmapInfo.cs	Automated #nullable processing	2022-06-17 16:37:17 +09:00
IBeatmapMetadataInfo.cs	Automated #nullable processing	2022-06-17 16:37:17 +09:00
IBeatmapOnlineInfo.cs	Add more properties to IBeatmapOnlineInfo	2022-06-27 16:07:15 +09:00
IBeatmapProcessor.cs	Automated #nullable processing	2022-06-17 16:37:17 +09:00
IBeatmapResourceProvider.cs	Automated #nullable processing	2022-06-17 16:37:17 +09:00
IBeatmapSetInfo.cs	Automated #nullable processing	2022-06-17 16:37:17 +09:00
IBeatmapSetOnlineInfo.cs	Automated #nullable processing	2022-06-17 16:37:17 +09:00
IBeatSyncProvider.cs	Convert interface methods to extension methods	2022-08-03 20:07:55 +09:00
IWorkingBeatmap.cs	Rename parameter to read better	2022-10-12 14:46:35 +09:00
IWorkingBeatmapCache.cs	Remove unnecessary invalidation handling flow	2022-06-30 17:13:26 +09:00
MetadataUtils.cs	Automated #nullable processing	2022-06-17 16:37:17 +09:00
StarDifficulty.cs	Guard against NaN star difficulty results	2022-06-29 21:02:29 +09:00
WorkingBeatmap.cs	Dispose previous waveform on track reload	2022-12-23 00:35:59 +03:00
WorkingBeatmapCache.cs	Add todo regarding validity check	2022-12-12 13:44:09 +09:00