1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-15 08:22:56 +08:00
osu-lazer/osu.Game/Skinning
Dean Herbert 28c9c61f71 Fix potential null reference in skin editor if target screen is null (during exit)
```csharp
[runtime] 2022-06-06 09:24:31 [verbose]: Host execution state changed to
Stopping
[runtime] 2022-06-06 09:24:31 [error]: An unhandled error has occurred.
[runtime] 2022-06-06 09:24:31 [error]: System.NullReferenceException:
Object reference not set to an instance of an object.
[runtime] 2022-06-06 09:24:31 [error]: at
osu.Game.Skinning.Editor.SkinEditorOverlay.setTarget(OsuScreen target)
in
/Users/dean/Projects/osu/osu.Game/Skinning/Editor/SkinEditorOverlay.cs:line
173
[runtime] 2022-06-06 09:24:31 [error]: at
osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
[runtime] 2022-06-06 09:24:31 [error]: at
osu.Framework.Threading.Scheduler.Update()
[runtime] 2022-06-06 09:24:31 [error]: at
osu.Framework.Graphics.Drawable.UpdateSubTree()
[runtime] 2022-06-06 09:24:31 [error]: at
osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
[runtime] 2022-06-06 09:24:31 [error]: at
osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
[runtime] 2022-06-06 09:24:31 [error]: at
osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
[runtime] 2022-06-06 09:24:31 [error]: at
osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
```
2022-06-06 18:27:54 +09:00
..
Components Combine SkinSprite into SkinnableSprite 2022-04-01 16:01:33 +09:00
Editor Fix potential null reference in skin editor if target screen is null (during exit) 2022-06-06 18:27:54 +09:00
BeatmapSkinProvidingContainer.cs
DefaultLegacySkin.cs
DefaultSkin.cs Handle all skin component types explicitly 2022-04-23 03:34:05 +03:00
EFSkinInfo.cs
GameplaySkinComponent.cs
GlobalSkinColours.cs
HUDSkinComponents.cs
IAnimationTimeReference.cs
IPooledSampleProvider.cs
ISkin.cs Apply notnull constraint 2022-03-25 15:54:01 +09:00
ISkinComponent.cs
ISkinnableDrawable.cs
ISkinnableTarget.cs
ISkinSource.cs
LegacyAccuracyCounter.cs
LegacyBeatmapSkin.cs Add proof of concept flow to ensure RealmBackedResourceStore is invalidated on realm file changes 2022-04-01 16:01:33 +09:00
LegacyColourCompatibility.cs
LegacyFont.cs
LegacyHealthDisplay.cs
LegacyJudgementPieceNew.cs
LegacyJudgementPieceOld.cs
LegacyManiaSkinConfiguration.cs
LegacyManiaSkinConfigurationLookup.cs
LegacyManiaSkinDecoder.cs
LegacyRollingCounter.cs
LegacyScoreCounter.cs Use localisable format string for comma separator mode 2021-10-10 17:41:16 +09:00
LegacySkin.cs Handle all skin component types explicitly 2022-04-23 03:34:05 +03:00
LegacySkinDecoder.cs
LegacySkinExtensions.cs Split out GetTextures helper function for LegacySkins 2022-04-07 17:28:48 +09:00
LegacySkinTransformer.cs Expose LegacySkinTransformer's underlying skin for pattern-matching 2022-06-04 01:14:42 +03:00
LegacySpriteText.cs
PausableSkinnableSound.cs Move ISamplePlaybackDisabler to more general namespace 2022-05-08 10:38:58 +02:00
PoolableSkinnableSample.cs
RealmBackedResourceStore.cs Revert "Remove nullable on RealmBackedResourceStore realm parameter" 2022-04-04 22:22:55 +02:00
ResourceStoreBackedSkin.cs Apply notnull constraint 2022-03-25 15:54:01 +09:00
RulesetSkinProvidingContainer.cs
Skin.cs Merge pull request #17596 from peppy/skin-editor-sprites 2022-04-05 17:38:58 +09:00
SkinComboColourLookup.cs
SkinConfigManager.cs
SkinConfiguration.cs
SkinCustomColourLookup.cs
SkinFileInfo.cs
SkinInfo.cs
SkinManager.cs Fix return condition from EnsureMutableSkin not accounting for "failed" imports 2022-04-29 13:46:18 +09:00
SkinModelManager.cs Fix skins getting duplicated when importing after export 2022-04-12 00:29:19 +09:00
SkinnableDrawable.cs Combine SkinSprite into SkinnableSprite 2022-04-01 16:01:33 +09:00
SkinnableSound.cs
SkinnableSprite.cs Change SpriteComponent accessibility to internal 2022-04-23 19:11:54 +03:00
SkinnableSpriteText.cs
SkinnableTarget.cs
SkinnableTargetComponent.cs
SkinnableTargetComponentsContainer.cs
SkinnableTargetContainer.cs
SkinProvidingContainer.cs
SkinReloadableDrawable.cs
SkinUtils.cs
UnsupportedSkinComponentException.cs Add a touch more detail to the unsupported skin component exception 2022-04-25 19:06:47 +09:00