rushiiMachine 1d4db3b7a9 Fix SkinEditorOverlay freezing when ReplayPlayer screen exits early ... Originally when popping in, the ReplayPlayer was loaded first (if previous screen was MainMenu), and afterwards the SkinEditor component was loaded asynchronously. However, if the ReplayPlayer screen exits quickly (like in the event the beatmap has no objects), the skin editor component has not finished initializing (this is before it was even added to the component tree, so it's still not marked `Visible`), then the screen exiting will cause `OsuGame` to call SetTarget(newScreen) -> setTarget(...) which sees that the cached `skinEditor` is not visible yet, and hides/nulls the field. This is the point where LoadComponentAsync(editor, ...) finishes, and the callback sees that the cached skinEditor field is now different (null) than the one that was loaded, and never adds it to the component tree. This occurrence is unhandled and as such the SkinEditorOverlay never hides itself, consuming all input infinitely. This PR changes the loading to start loading the ReplayPlayer *after* the SkinEditor has been loaded and added to the component tree. Additionally, this lowers the exit delay for ReplayPlayer and changes the "no hit objects" notification to not be an error since it's a controlled exit.		2023-12-26 12:22:00 -08:00
..
AccountCreation	Automated pass	2023-06-24 01:00:03 +09:00
BeatmapListing	Replace all hexacon lookups with strongly typed properties	2023-11-24 13:17:39 +09:00
BeatmapSet	Replace all hexacon lookups with strongly typed properties	2023-11-24 13:17:39 +09:00
Changelog	Replace all hexacon lookups with strongly typed properties	2023-11-24 13:17:39 +09:00
Chat	Fix chat overlay top bar icon being incorrect	2023-11-30 10:20:01 -08:00
Comments	Fix comment markdown image not showing tooltips	2023-11-15 19:50:32 -08:00
Dashboard	Fix "spectate" button not always being clickable in online users list	2023-12-23 21:21:34 +09:00
Dialog	Use DangerousActionDialog	2023-12-05 16:54:44 +09:00
FirstRunSetup	Fix first run locator stable locator directory desyncing between display & popover	2023-12-15 16:00:34 +01:00
Login	Simplify UserStatus to be an enumeration type	2023-12-06 18:52:27 +01:00
MedalSplash	Partial everything	2022-11-27 00:00:27 +09:00
Mods	Revert to using a more manual approach to holding focus	2023-12-19 19:46:30 +09:00
Music	Allow screens to change the ability to interact with the global track	2023-07-25 20:20:53 +09:00
News	Replace all hexacon lookups with strongly typed properties	2023-11-24 13:17:39 +09:00
Notifications	Fix progress notifications queueing up infinite text changes when not visible	2023-12-18 19:00:44 +09:00
OSD	Remove touch device toasts entirely	2023-11-06 10:54:32 +01:00
Profile	Fix user profile cover showing 1px line when contracted	2023-12-23 21:07:17 +09:00
Rankings	Replace all hexacon lookups with strongly typed properties	2023-11-24 13:17:39 +09:00
Settings	Extract common method for determining stable import usability of directory	2023-12-15 15:42:19 +01:00
SkinEditor	Fix SkinEditorOverlay freezing when ReplayPlayer screen exits early	2023-12-26 12:22:00 -08:00
Toolbar	Fix toolbar keybinding hint not clearing after unbinding the keybinding	2023-12-23 19:39:17 +01:00
Volume	Automated pass	2023-06-24 01:00:03 +09:00
Wiki	Replace all hexacon lookups with strongly typed properties	2023-11-24 13:17:39 +09:00
AccountCreationOverlay.cs	Apply osu! side changes in line with FocusedOverlayContainer.PopIn abstract change	2023-06-18 20:57:32 +09:00
BeatmapListingOverlay.cs	Uncomment net6.0 code and remove old code	2023-12-04 20:17:22 +01:00
BeatmapSetOverlay.cs	Normalise overlay horizontal padding const	2023-04-02 20:24:13 -07:00
BreadcrumbControlOverlayHeader.cs	Automated pass	2023-06-24 01:00:03 +09:00
ChangelogOverlay.cs	Change some order and assert for positive visibility before scheduling an operation in changelog overlay	2023-01-24 17:59:25 +09:00
ChatOverlay.cs	Merge branch 'master' into chat-drag-improvements	2023-11-24 18:13:18 +09:00
DashboardOverlay.cs	Retrofit user presence watching into dashboard overlay	2023-12-06 19:37:35 +01:00
DialogOverlay.cs	Apply osu! side changes in line with FocusedOverlayContainer.PopIn abstract change	2023-06-18 20:57:32 +09:00
FirstRunSetupOverlay.cs	Fix the MOTHERLOAD of undetected issues that are now visible thanks to net6.0	2022-12-16 18:16:26 +09:00
FullscreenOverlay.cs	Replace all hexacon lookups with strongly typed properties	2023-11-24 13:17:39 +09:00
HoldToConfirmOverlay.cs	Partial everything	2022-11-27 00:00:27 +09:00
IDialogOverlay.cs	Automated #nullable processing	2022-06-17 16:37:17 +09:00
INamedOverlayComponent.cs	Replace all hexacon lookups with strongly typed properties	2023-11-24 13:17:39 +09:00
INotificationOverlay.cs	Flip and rename CompletedOrCancelled to Ongoing	2023-07-08 14:11:58 +02:00
IOverlayManager.cs	Automated pass	2023-06-24 01:00:03 +09:00
KudosuTable.cs	Add ability to view kudosu rankings	2023-11-07 15:58:17 -08:00
LoginOverlay.cs	Reduce LoginOverlay pop-in/pop-out sample panning to match NowPlayingOverlay	2023-10-20 21:01:36 +09:00
MedalOverlay.cs	Apply osu! side changes in line with FocusedOverlayContainer.PopIn abstract change	2023-06-18 20:57:32 +09:00
MusicController.cs	Adjust xmldoc to explicitly metnion it only affects end user control	2023-07-30 13:52:58 +09:00
NewsOverlay.cs	Partial everything	2022-11-27 00:00:27 +09:00
NotificationOverlay.cs	Replace all hexacon lookups with strongly typed properties	2023-11-24 13:17:39 +09:00
NotificationOverlayToastTray.cs	Expose all notifications from INotificationOverlay	2023-06-23 15:19:21 +09:00
NowPlayingOverlay.cs	Replace all hexacon lookups with strongly typed properties	2023-11-24 13:17:39 +09:00
OnlineOverlay.cs	Automated pass	2023-06-24 01:00:03 +09:00
OnScreenDisplay.cs	Use new ArgumentNullException.ThrowIfNull throw-helper API	2022-12-22 21:27:59 +01:00
OverlayActivation.cs	Remove redundant nullable suppression directives	2023-06-07 08:20:41 +03:00
OverlayColourProvider.cs	Automated pass	2023-06-24 01:00:03 +09:00
OverlayHeader.cs	Manual fixes to reduce warnings to zero	2023-06-24 01:52:53 +09:00
OverlayHeaderBackground.cs	Automated pass	2023-06-24 01:00:03 +09:00
OverlayPanelDisplayStyleControl.cs	Partial everything	2022-11-27 00:00:27 +09:00
OverlayRulesetSelector.cs	Automated pass	2023-06-24 01:00:03 +09:00
OverlayRulesetTabItem.cs	Automated pass	2023-06-24 01:00:03 +09:00
OverlayScrollContainer.cs	Ensure scroll-to-top button is displayed above all overlay content	2023-05-17 15:42:38 +09:00
OverlaySidebar.cs	Increase the minimum size of the scroll bar	2023-07-02 00:04:56 +09:00
OverlaySortTabControl.cs	Add failing beatmap listing sort direction on criteria change test	2023-03-21 15:08:37 -07:00
OverlayStreamControl.cs	Partial everything	2022-11-27 00:00:27 +09:00
OverlayStreamItem.cs	Replace other hardcoded horizontal padding with const	2023-04-02 20:50:18 -07:00
OverlayTabControl.cs	Partial everything	2022-11-27 00:00:27 +09:00
OverlayTitle.cs	Replace all hexacon lookups with strongly typed properties	2023-11-24 13:17:39 +09:00
OverlayView.cs	Partial everything	2022-11-27 00:00:27 +09:00
RankingsOverlay.cs	Add ability to view kudosu rankings	2023-11-07 15:58:17 -08:00
RevertToDefaultButton.cs	Change RevertToDefaultButton and BackButton to use Default sampleset instead	2023-10-20 21:01:36 +09:00
SettingsOverlay.cs	Replace all hexacon lookups with strongly typed properties	2023-11-24 13:17:39 +09:00
SettingsPanel.cs	Move behaviour to settings search text box only	2023-10-30 06:41:01 +03:00
SettingsSearchTextBox.cs	Only run "select all on focus" behaviour on desktop platforms	2023-10-30 11:54:19 +03:00
SettingsSubPanel.cs	Change RevertToDefaultButton and BackButton to use Default sampleset instead	2023-10-20 21:01:36 +09:00
SettingsToolboxGroup.cs	Move hover logic to SettingsToolboxGroup to avoid expanded state clash	2023-01-17 14:43:22 +09:00
SortDirection.cs	Remove redundant nullable suppression directives	2023-06-07 08:20:41 +03:00
TabbableOnlineOverlay.cs	Partial everything	2022-11-27 00:00:27 +09:00
TabControlOverlayHeader.cs	Manual fixes to reduce warnings to zero	2023-06-24 01:52:53 +09:00
UserProfileOverlay.cs	Ensure only run once	2023-11-22 12:03:42 +09:00
VersionManager.cs	Automated pass	2023-06-24 01:00:03 +09:00
VolumeOverlay.cs	Partial everything	2022-11-27 00:00:27 +09:00
WaveOverlayContainer.cs	Use string.Empty	2023-08-25 01:07:07 +09:00
WikiOverlay.cs	Fix "Return to main page" link not working on wiki after error	2023-05-08 15:29:05 +09:00