osu-lazer

mirror of https://github.com/ppy/osu.git synced 2026-05-18 03:47:04 +08:00

Files

T

Bartłomiej Dach c4f7dee82b Fix skin editor sometimes dropping anchor/origin specification on paste (#35957 )

* Add failing test for copy->paste not being idempotent

* Ensure all elements on default skins use fixed anchors

`UsesFixedAnchor` defaults to false, i.e. closest anchors. Combined with
manual anchor / origin specs on some drawables, this would get default
skins into impossible states wherein a drawable would use "closest
anchor" but also explicitly specify anchor / origin that aren't closest,
which horribly fails on attempting to copy and paste.

Frankly shocked this has gone unnoticed for this long, and I regret not
vetoing this "feature" more every time I see its tentacles spread to
produce breakage of levels yet unseen.

Does this commit contain major levels of suck? For sure. Do I have any
better ideas that wouldn't consist of a multi-day rewrite or deletion of
this "feature"? No.

* Fix skin editor always applying closest anchor / origin on paste regardless of whether the component uses fixed anchor

Self-explanatory. Should close https://github.com/ppy/osu/issues/29111
along with previous commit.

c4f7dee82b · 2025-12-11 13:40:48 +09:00

History

Beatmaps

Add localisation usage to BeatmapStatistic and revert ShowDetailsMappedBy

2025-06-21 21:01:48 +03:00

Difficulty

Bump difficulty calculator versions

2025-10-20 08:46:30 +02:00

Edit

Add basic colour indication as to when placements are valid

2025-12-04 14:37:56 +01:00

Judgements