mirror of
https://github.com/ppy/osu.git
synced 2025-01-14 04:02:59 +08:00
08609e19d6
As it turns out, the "lower" and "upper" estimates of the combo portion of the score being converted were misnomers. In selected cases (scores with high accuracy but combo being lower than max by more than a few objects) the janky score-based math could overestimate the count of remaining objects in a map. For instance, in one case the numbers worked out something like this: - Accuracy: practically 100% - Max combo on beatmap: 571x - Max combo for score: 551x The score-based estimation attempts to extract a "remaining object count" from score, by doing something along of sqrt(571^2 - 551^2). That comes out to _almost 150_. Which leads to the estimation overshooting the total max combo count on the beatmap by some hundred objects. To curtail this nonsense, enforce some basic invariants: - Neither estimate is allowed to exceed maximum achievable - Ensure that lower estimate is really lower and upper is really upper by just looking at the values and making sure that is so rather than just saying that it is. |
||
|---|---|---|
| .. | ||
| BackgroundDataStoreProcessor.cs | ||
| BeatmapExporter.cs | ||
| BeatmapLookupCache.cs | ||
| EmptyRealmSet.cs | ||
| ICanAcceptFiles.cs | ||
| IHasFiles.cs | ||
| IHasGuidPrimaryKey.cs | ||
| IHasNamedFiles.cs | ||
| IHasOnlineID.cs | ||
| IHasPrimaryKey.cs | ||
| IHasRealmFiles.cs | ||
| IModelDownloader.cs | ||
| IModelFileManager.cs | ||
| IModelImporter.cs | ||
| IModelManager.cs | ||
| ImportParameters.cs | ||
| ImportProgressNotification.cs | ||
| ImportTask.cs | ||
| INamedFile.cs | ||
| INamedFileInfo.cs | ||
| INamedFileUsage.cs | ||
| IPostNotifications.cs | ||
| ISoftDelete.cs | ||
| LegacyArchiveExporter.cs | ||
| LegacyBeatmapExporter.cs | ||
| LegacyBeatmapImporter.cs | ||
| LegacyCollectionImporter.cs | ||
| LegacyExporter.cs | ||
| LegacyImportManager.cs | ||
| LegacyModelImporter.cs | ||
| LegacyScoreExporter.cs | ||
| LegacyScoreImporter.cs | ||
| LegacySkinExporter.cs | ||
| LegacySkinImporter.cs | ||
| Live.cs | ||
| MemoryCachingComponent.cs | ||
| MissingBeatmapNotification.cs | ||
| ModelDownloader.cs | ||
| ModelManager.cs | ||
| OnlineLookupCache.cs | ||
| RealmAccess.cs | ||
| RealmArchiveModelImporter.cs | ||
| RealmExtensions.cs | ||
| RealmFileStore.cs | ||
| RealmLive.cs | ||
| RealmLiveUnmanaged.cs | ||
| RealmObjectExtensions.cs | ||
| StandardisedScoreMigrationTools.cs | ||
| TooManyDownloadsNotification.cs | ||
| UserLookupCache.cs | ||