Bartłomiej Dach
ff59a236ae
Merge pull request #22775 from peppy/dont-filter-results-on-sort-mode
...
Don't filter away results with missing data when using "Date Submitted" or "Date Ranked" sort modes
2023-03-06 18:47:41 +01:00
Bartłomiej Dach
ec15e2b9cc
Merge branch 'master' into dont-filter-results-on-sort-mode
2023-03-06 17:57:47 +01:00
Dean Herbert
87d0bef313
Use nullable comparison helper method instead of manual implementation
2023-03-06 15:16:32 +09:00
Dean Herbert
778cde8932
Merge pull request #22790 from Joehuu/fix-android-external-links
...
Fix external links not working on Android
2023-03-05 22:12:57 +09:00
Dean Herbert
77257398db
Merge pull request #22787 from bdach/skin-editor-screen-transitions
...
Fix several issues with skin editor behaviour on screen transitions
2023-03-05 22:00:14 +09:00
Bartłomiej Dach
d120638e68
Use manifest overlay and merger for intent query specs
...
Co-authored-by: Susko3 <Susko3@protonmail.com>
2023-03-05 13:17:46 +01:00
Joseph Madamba
5d6ab5f465
Add mailto scheme to intent queries
2023-03-04 16:07:29 -08:00
Joseph Madamba
92f94278c1
Fix external links not working on Android
2023-03-04 13:35:34 -08:00
Bartłomiej Dach
60cdd3c070
Clear components sidebar unconditionally on every target change
...
Fixes the working layer dropdown lingering after exiting from a
skinnable screen to a non-skinnable one.
2023-03-04 14:10:05 +01:00
Bartłomiej Dach
9d4bb2ecf7
Add failing test coverage for clearing sidebar contents
2023-03-04 14:08:50 +01:00
Bartłomiej Dach
d233f3a3ab
Show non-skinnable screen placeholder at higher level
2023-03-04 13:49:10 +01:00
Bartłomiej Dach
49e298e304
Accept ISerialisableDrawableContainer directly in SkinBlueprintContainer
...
An end result of #22674 is that `SkinBlueprintContainer`s are only ever
created by supplying a `SkinComponentsContainer` to them. However,
`SkinBlueprintContainer` still contained remnants of code that suggested
it was designed to handle cases where more than the drawable supplied to
it contained more than one `ISerialisableDrawableContainer`, or even
zero.
The zero path is totally dead right now (because every
`SkinComponentsContainer` is *by necessity* an
`ISerialisableDrawableContainer`), and the more-than-one path is dead
*for now* (and potentially forever?). Therefore, just hard-couple
`SkinBlueprintContainer` to receive a single target container.
2023-03-04 13:33:21 +01:00
Bartłomiej Dach
2f25fb4083
Move NonSkinnableScreenPlaceholder to outer scope
2023-03-04 13:22:43 +01:00
Bartłomiej Dach
15409b9c15
Fix skin selection not clearing on exit to non-skinnable screen
2023-03-04 13:18:34 +01:00
Bartłomiej Dach
3dd3b5e77a
Add failing test case
2023-03-04 13:17:54 +01:00
Bartłomiej Dach
866987d6e1
Merge pull request #22776 from peppy/fix-mania-upscroll
...
Fix upwards scroll direction not working with recent hold note display changes
2023-03-03 21:37:51 +01:00
Dean Herbert
36058b3da2
Fix upwards scroll direction not working with recent hold note display changes
2023-03-03 18:03:06 +09:00
Dean Herbert
a14dede036
Ensure TestBeatmapCarousel.Items only returns actually visible items (and in correct order)
...
Turns out that items could be in an order that isn't the same as how
things look on the carousel, so this change ensures that for testing
purposes they are sorted by Y position.
Also uses the `CarouselItem.Visible` flag to ensure that we don't have
to wait for drawable fade transitions after a filter operation.
2023-03-03 17:18:34 +09:00
Dean Herbert
7a092ea995
Add better coverage and more comments explaining the structure of test setup
2023-03-03 17:18:14 +09:00
Dean Herbert
82293c0c86
Don't filter away results with missing data when using "Date Submitted" or "Date Ranked" sort modes
...
From a user's perspective, changing a sort / order mode shouldn't filter
away results, but we were doing this.
In terms of UX expectations, in stable this kind of scenario would
results in a group being added to the end of son select with "Not
ranked" or "Unknown". I think we should aim to match this eventually.
2023-03-03 16:36:18 +09:00
Dean Herbert
29be26b150
Merge pull request #22766 from Joehuu/fix-talking-with-text-overflow
...
Fix "talking with" text overflowing when usernames are too long
2023-03-02 17:04:11 +09:00
Joseph Madamba
af540de69b
Fix "talking with" text overflowing when usernames are too long
2023-03-01 22:10:15 -08:00
Dean Herbert
bd11d5d29a
Merge pull request #22743 from Joehuu/scroll-back-to-previous
...
Add ability to scroll back to previous position after scrolling to top via button on overlays
2023-03-01 22:55:47 +09:00
Dean Herbert
21ebcdf5ed
Merge pull request #22755 from EVAST9919/colour-info-framework
...
Use `ColourInfo.Interpolate(Quad)` where possible
2023-03-01 12:05:54 +09:00
Bartłomiej Dach
24723ca873
Merge pull request #22749 from peppy/rename-setting-source-tests
...
Rename `SettingSource` tests to match attribute name
2023-02-28 20:40:07 +01:00
Andrei Zavatski
31f58a33ac
Use ColourInfo.Interpolate where possible
2023-02-28 18:47:27 +03:00
Dean Herbert
3c45ab677a
Merge pull request #22751 from peppy/update-framework
...
Update framework
2023-02-28 16:40:18 +09:00
Dean Herbert
89e20a7962
Update resources
2023-02-28 14:47:51 +09:00
Dean Herbert
bd1460a8d5
Update framework
2023-02-28 14:32:58 +09:00
Dean Herbert
2615453b31
Rename SettingSource tests to match attribute name
2023-02-28 11:45:32 +09:00
Bartłomiej Dach
ca47d55f10
Merge pull request #22748 from OpenSauce04/patch-1
...
Fix grammar mistake in taiko relax mod description
2023-02-27 20:17:14 +01:00
Bartłomiej Dach
4e9d25957a
Merge pull request #22717 from peppy/skin-editor-depth-changing
...
Add ability to send selected skin components to front or back
2023-02-27 19:56:21 +01:00
Bartłomiej Dach
92edb0f868
Merge branch 'master' into skin-editor-depth-changing
2023-02-27 19:24:53 +01:00
OpenSauce
8d747f2402
Fixed grammar mistake in Taiko Relax mod description
2023-02-27 16:06:33 +00:00
Joseph Madamba
fa710ae1b0
Rename ScrollToTopButton to ScrollBackButton
2023-02-26 14:39:34 -08:00
Joseph Madamba
dc00905f8d
Add ability to scroll back to previous position after scrolling to top via button on overlays
2023-02-26 14:38:51 -08:00
Joseph Madamba
d98d330da2
Add expected behavior test for scroll back to previous position
2023-02-26 14:30:46 -08:00
Dean Herbert
dc3c1150b8
Set better defaults for SkinBlueprint transforms
2023-02-23 21:10:15 +09:00
Dean Herbert
c48aceb055
Fix undo history not being batched correctly for depth change operations
2023-02-23 20:03:36 +09:00
Bartłomiej Dach
d679703fa2
Merge pull request #22659 from peppy/fix-taiko-drum-nested-sample-detection
...
Fix `GameplaySampleTriggerSource` not considering nested objects when determining the best sample to play
2023-02-22 18:56:59 +01:00
Dean Herbert
a8c692a215
Merge pull request #22635 from peppy/use-overlays-container-more
...
Use `Overlays` container rather than `KeyBindingInputManager` for flashlight
2023-02-22 18:30:21 +09:00
Dean Herbert
32a9c066df
Add test coverage of bring-to-front / send-to-back operations
2023-02-22 18:17:20 +09:00
Dean Herbert
90ca635a17
Fix weird nullability in TestSceneSkinEditor
2023-02-22 18:17:20 +09:00
Dean Herbert
16c8a392a1
Add ability to send selected skin components to front or back
2023-02-22 18:17:20 +09:00
Dean Herbert
f61fbcf3fc
Update assertion to also check GameplayClockContainer's current time
2023-02-22 15:26:09 +09:00
Dean Herbert
a511e64fa5
Seek using GameplayClockContainer
2023-02-22 14:41:20 +09:00
Dean Herbert
4f9f4b3970
Merge pull request #22674 from peppy/skin-editor-layer-select
...
Add the ability to select a target layer in the skin editor
2023-02-22 12:51:15 +09:00
Bartłomiej Dach
051eb18b33
Merge branch 'master' into skin-editor-layer-select
2023-02-21 21:38:51 +01:00
Bartłomiej Dach
ab97b02235
Remove contradictory remark from xmldoc
2023-02-21 21:05:46 +01:00
Bartłomiej Dach
d59d153654
Fix test compile failures from Audio hoisting
2023-02-21 21:03:00 +01:00
