Salman Ahmed
fe48ce4bd5
Remove unaccessed field
...
It was a warning...
2021-06-11 00:58:06 +03:00
Salman Ahmed
ca3c45363a
Add test coverage
2021-06-11 00:25:22 +03:00
Salman Ahmed
169c98f963
Add skin providing ruleset resources in RulesetSkinProvidingContainer
2021-06-11 00:25:22 +03:00
Salman Ahmed
2240e2c39c
Refrain from attempting to clear skin sources in disposal
...
`Drawable.Dispose` is usually in an asynchronous context (async disposals stuff) and therefore this could cause a "collection was modified; enumeration opeartion may not execute" exception.
2021-06-10 17:23:16 +03:00
Salman Ahmed
680791301f
Consume new method rather than caching skin sources on top of Player
2021-06-10 16:36:46 +03:00
Salman Ahmed
23d6c366ac
Add method for assigning arbitrary skins to player in test scenes
2021-06-10 16:36:46 +03:00
Salman Ahmed
ef2c4fd0d8
Make RulesetSkinProvidingContainer able to be overriden for testing purposes
2021-06-10 16:36:46 +03:00
Salman Ahmed
09a2d008d2
Refrain from attempting to transform null skins
2021-06-10 16:36:45 +03:00
Salman Ahmed
5c9c424a0d
Switch state case placements for consistency
...
Tickled me.
2021-06-10 13:15:18 +03:00
Salman Ahmed
26cdcc8d78
Remove stale access to Source from master merge
2021-06-10 13:07:32 +03:00
Salman Ahmed
c3a2f2c2a4
Expose default SkinManager providers for use in RulesetSkinProvidingContainer
2021-06-10 13:07:32 +03:00
Salman Ahmed
59be3588eb
Change SkinSources to a bindable list for binding SourceChanged events
2021-06-10 13:07:32 +03:00
Salman Ahmed
dde84e5cbd
Merge branch 'master' into transformers-per-skin
2021-06-10 11:58:52 +03:00
Salman Ahmed
58cca9da06
Revert "Expose the skin lookup layers of SkinManager to a property"
...
This reverts commit 9e652715ce
2021-06-10 11:57:28 +03:00
Salman Ahmed
530026b675
Add simple xmldoc to ctors explaining their deal with SkinSources
2021-06-10 11:56:13 +03:00
Salman Ahmed
18edbdd135
Remove mentioning of "layer" in skin providers
...
`SkinSources` sounds better.
2021-06-10 11:55:26 +03:00
Dan Balasescu
3cd7d45b0f
Merge pull request #13401 from peppy/no-unranked-display
...
Remove the concept of "unranked" mods
2021-06-10 17:51:31 +09:00
Dan Balasescu
c06c447564
Merge pull request #13404 from peppy/fix-beatmap-skin-disables
...
Fix `FindProvider` calls on `SkinProvidingContainer` not considering disable flags
2021-06-10 17:23:46 +09:00
Dan Balasescu
a44fd887ee
Merge branch 'master' into no-unranked-display
2021-06-10 17:09:46 +09:00
Dean Herbert
05b46b4743
Merge pull request #13379 from ekrctb/catcher-sprite
...
Refactor osu!catch catcher sprite to factor out skinning logic
2021-06-10 16:52:17 +09:00
Dan Balasescu
479d6d3fc5
Merge branch 'master' into fix-beatmap-skin-disables
2021-06-10 16:37:58 +09:00
Dan Balasescu
4eab717a80
Merge pull request #13408 from peppy/default-skin-fallback
...
Add fallback lookup support for `DefaultSkin`
2021-06-10 16:37:48 +09:00
Dean Herbert
62b400fea5
Merge pull request #13427 from Joehuu/fix-stats-forever-dimming
...
Fix background being dimmed forever after toggling statistics in results screen
2021-06-10 16:09:14 +09:00
Dean Herbert
865c5c0676
Use [Resolved] to simplify bindable resolution
2021-06-10 15:47:03 +09:00
Dean Herbert
6995945360
Use With to simplify drawable construction
2021-06-10 15:45:49 +09:00
Joseph Madamba
cc38556f61
Fix background being dimmed forever after toggling statistics in results screen
2021-06-09 23:26:57 -07:00
Dean Herbert
9a3ca09501
Merge pull request #13384 from bdach/fixed-label-width
...
Align label widths of editor setup screen controls
2021-06-10 14:55:49 +09:00
Dean Herbert
b55a4053cf
Merge pull request #13426 from gagahpangeran/wiki-image-title
...
Fix wiki image tooltips not showing inside table views
2021-06-10 14:28:49 +09:00
Gagah Pangeran Rosfatiputra
05cb935a94
change WikiMarkdownImage to extend OsuMarkdownImage
2021-06-10 09:38:48 +07:00
Dean Herbert
2b4649a3ea
Merge pull request #13425 from Joehuu/score-panel-kb-navigation
2021-06-10 11:38:17 +09:00
Gagah Pangeran Rosfatiputra
28d7b06908
create OsuMarkdownImage
2021-06-10 09:38:07 +07:00
Gagah Pangeran Rosfatiputra
39e1f77d53
add image table with image content test
2021-06-10 09:37:33 +07:00
Joseph Madamba
e3f3c37953
Add ability to navigate score panels with left/right arrows
2021-06-09 17:03:46 -07:00
Salman Ahmed
1aaad7bfd4
Apply few adjustments to skinning overlays comment
2021-06-09 22:49:31 +03:00
Salman Ahmed
e30f6581b3
Wrap gameplay content within a RulesetSkinProvidingContainer
2021-06-09 22:49:31 +03:00
Salman Ahmed
33a9cac398
Add special RulesetSkinProvidingContainer managing ruleset-compatible skin setup
2021-06-09 22:49:31 +03:00
Salman Ahmed
9e652715ce
Expose the skin lookup layers of SkinManager to a property
2021-06-09 22:49:31 +03:00
Salman Ahmed
6538d44708
Make SkinProvidingContainer able to perform lookup on multiple skins
...
Currently `protected` functionality for use in custom `SkinProvidingContainer`s, can be exposed to public constructors if it need to later on, but I'm not sure about doing that opposed to just nesting multiple `SkinProvidingContainer`.
2021-06-09 22:49:31 +03:00
Salman Ahmed
cf40282f1f
Convert LegacySkinTransformers to accept raw ISkins rather than a full ISkinSource
2021-06-09 22:49:31 +03:00
Bartłomiej Dach
209f658d05
Merge branch 'master' into fix-beatmap-skin-disables
2021-06-09 20:22:00 +02:00
Bartłomiej Dach
aed490803f
Merge pull request #13407 from peppy/fix-results-exit-transition
2021-06-09 20:16:09 +02:00
Bartłomiej Dach
89cdea8123
Merge branch 'master' into fix-results-exit-transition
2021-06-09 19:40:56 +02:00
Bartłomiej Dach
266c1e2e25
Merge branch 'master' into fix-beatmap-skin-disables
2021-06-09 18:43:15 +02:00
Dean Herbert
58e00e9e43
Merge pull request #13412 from peppy/update-framework
...
Update framework
2021-06-10 01:41:49 +09:00
Bartłomiej Dach
222ae40a04
Merge branch 'master' into update-framework
2021-06-09 17:36:17 +02:00
Bartłomiej Dach
988e97bbc3
Merge pull request #13335 from gagahpangeran/wiki-article
2021-06-09 17:00:19 +02:00
Bartłomiej Dach
7fe878299f
Merge branch 'master' into wiki-article
2021-06-09 16:24:45 +02:00
Dean Herbert
f113c095ce
Update framework
2021-06-09 20:29:06 +09:00
Dean Herbert
ca02e8e5d3
Merge pull request #13405 from ekrctb/fix-circle-piece-2
...
Fix circle piece animation sometimes not playing when a replay is rewound (again)
2021-06-09 19:48:59 +09:00
Dean Herbert
b02b8ae2bc
Merge pull request #13381 from smoogipoo/improve-hit-error-judgements
...
Improve hit error judgement displays
2021-06-09 19:40:17 +09:00
