392 Commits

• Revert "Fix potential crash in tests when attempting to lookup key bindings in cases the lookup is not available"

  This reverts commit 8115a4bb8f.
  
  Commit was cherrypicked out to a separate pull on a different merge
  base, then reverted in that pull, so it should be reverted here too.

  Bartłomiej Dach · 2022-03-05 16:42:51 +01:00
  08b3bc222d
• Merge branch 'master' into offset-ui-improvements
  Bartłomiej Dach · 2022-03-05 16:10:18 +01:00
  e4b4c3c5c4
• Merge branch 'add-offset-adjust-tooltip-text' into combine-time-slider-implementation
  Bartłomiej Dach · 2022-03-05 14:58:56 +01:00
  346cec3577
• Add note about how global audio offset is currently applied
  Dean Herbert · 2022-03-04 12:44:02 +09:00
  c1c9482077
• Fix potential crash in tests when attempting to lookup key bindings in cases the lookup is not available
  Dean Herbert · 2022-03-04 12:44:02 +09:00
  8115a4bb8f
• Move default function specifications to OsuConfigManager

  This ensures that running tests in release configuration will not fail
  due to the same issue being fixed in this PR.

  Dean Herbert · 2022-03-04 12:31:58 +09:00
  ac914878b8
• Use double instead of float for UIHoldActivationDelay configuration value

  All times use double, so let's also use double here.

  Dean Herbert · 2022-03-04 12:22:56 +09:00
  7854a0a913
• Fix potential crash in tests when attempting to lookup key bindings in cases the lookup is not available
  Dean Herbert · 2022-03-03 16:29:37 +09:00
  f09a4e9c5b
• Rename RealmContextFactory to RealmAccess
  Dean Herbert · 2022-01-24 20:38:07 +09:00
  6eb2c28e41
• Add migration of positional hitsounds setting to new level based setting
  Dean Herbert · 2022-01-03 12:46:20 +09:00
  623d6d6d2d
• Remove outdated settings migration
  Dean Herbert · 2022-01-03 12:46:02 +09:00
  5dd024aab7
• Merge branch 'master' into positional-sounds-strength-adjustment
  Dean Herbert · 2022-01-03 12:40:56 +09:00
  bb54f438aa
• Do not reset last hover sound playback time on inactivity
  Bartłomiej Dach · 2021-12-21 08:47:41 +01:00
  979624160f
• Remove unused private method
  Bartłomiej Dach · 2021-12-21 08:47:26 +01:00
  cd10af633c
• Rename method and simplify SetDefault calling code
  Dean Herbert · 2021-12-21 15:34:32 +09:00
  981158ed88
• Split session statics reset method to prevent unloading seasonal backgrounds while idle
  dekrain · 2021-12-20 16:51:51 +01:00
  9344897542
• Merge branch 'master' into primary-key-consistency
  Dean Herbert · 2021-12-08 21:34:38 +09:00
  8d9c37a825
• Specify config file default as DEFAULT_SKIN's guid
  Dean Herbert · 2021-12-01 12:45:47 +09:00
  fb2310f826
• Create Guid constants for system skins (and store skin choice to configuration as guid)
  Dean Herbert · 2021-11-29 18:28:25 +09:00
  3db5646fa8
• Fixed the problems that were brought up and deleted the old bind logic
  mk-56 · 2021-11-28 14:06:53 +01:00
  c3fb793762
• Binding logic fix, nullification of unnecessary path
  mk-56 · 2021-11-28 03:25:11 +01:00
  e83115ad5e
• Initial implementation of adjustable positional hitobject audio strength
  mk-56 · 2021-11-28 02:58:08 +01:00
  eaa464e548
• Merge branch 'master' into realm-ruleset-setting-short-name
  Dean Herbert · 2021-11-23 14:55:36 +09:00
  f264b128c2
• Switch realm ruleset configuration to use ruleset's ShortName as key
  Dean Herbert · 2021-11-22 18:52:00 +09:00
  329bae50b0
• Store preferred ruleset to configuration using ShortName instead of ID
  Dean Herbert · 2021-11-22 17:45:31 +09:00
  f1926c6d27
• Add IsManaged helper method to EF classes to match realm implementation
  Dean Herbert · 2021-11-19 21:56:06 +09:00
  eecf6ad558
• Apply batch fixing of built-in types using var
  Dean Herbert · 2021-10-27 13:04:41 +09:00
  6944151486
• Fix a missed toast shortcut string not localising correctly
  Joseph Madamba · 2021-10-22 15:45:48 -07:00
  1ae6621c85
• Fix a couple more weird variable names
  Dean Herbert · 2021-10-19 17:22:50 +09:00
  8672b3325a
• Tidy up tracked settings code syntax and fix remaining issue
  Dean Herbert · 2021-10-19 17:21:07 +09:00
  61670a70b6
• Replace unnecessary ToString call

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2021-10-19 16:42:07 +09:00
  192cfe8717
• Merge branch 'master' into localise-toasts
  Dean Herbert · 2021-10-19 16:37:14 +09:00
  c97cfdd978
• Add some missing labels
  Dean Herbert · 2021-10-12 15:09:59 +09:00
  59202d27c7
• Localise more toast related strings
  Joseph Madamba · 2021-10-11 01:02:26 -07:00
  4fc84e71cd
• Track ui scale setting
  Joseph Madamba · 2021-10-10 19:55:02 -07:00
  4b01c23c11
• Localise tracked setting toasts
  Joseph Madamba · 2021-10-10 19:35:25 -07:00
  545cfc7bf1
• Attach migration memo to DatabasedSetting class for visibility
  Dean Herbert · 2021-09-15 17:25:07 +09:00
  4f1db5af40
• Mark key and value non-nullable (at realm end) and simplify Value logic
  Dean Herbert · 2021-09-15 17:16:05 +09:00
  a1d325cb22
• Add nullability directive and make variant non-nullable
  Dean Herbert · 2021-09-15 17:16:05 +09:00
  a150fb2996
• Make ruleset id non-nullable
  Dean Herbert · 2021-09-15 17:12:04 +09:00
  dcfe9c67e3
• Rename all databased setting classes to be specific to rulesets for now
  Dean Herbert · 2021-09-15 17:12:04 +09:00
  80ecf81be3
• Bring back SettingsStore to avoid changing ruleset API for now

  Also fixes some remaining test failures due to locally constructed
  rulesets that are not being tracked by the game.

  Dean Herbert · 2021-09-15 17:12:02 +09:00
  520e550764
• Remove unused SettingsStore
  Dean Herbert · 2021-09-15 16:31:13 +09:00
  ac377a2e3c
• Make settings works with current caching structure

  Will likely pull out that `RulesetConfigCache` next, but this is an
  "everything works" state.

  Dean Herbert · 2021-09-15 16:31:13 +09:00
  a2f1752344
• Begin migrating settings implementation across to realm
  Dean Herbert · 2021-09-15 16:22:14 +09:00
  187c557ea8
• Fix cache not actually caching anything
  Dean Herbert · 2021-09-09 14:56:39 +09:00
  41a2e6eeeb
• Use a more traditional method of caching
  Dean Herbert · 2021-09-08 23:18:17 +09:00
  a622a0b660
• Cache reflection portion of SettingSource lookups

  Fixes the mod-related overhead portion of https://github.com/ppy/osu/issues/14638. There's still a significant performance issue that will be addressed separately.

  Dean Herbert · 2021-09-08 13:26:11 +09:00
  81c9d831f4
• Add a note against OsuSetting
  Dean Herbert · 2021-08-16 16:59:59 +09:00
  71fab416d8
• Revert "Rename element in OsuSettings enum"

  This reverts commit c2bbe17562.

  Dean Herbert · 2021-08-16 16:56:48 +09:00
  fc89f2bac4