40719 Commits

This Branch

This Branch

All Branches

• Call base when overriding lookup methods

  Rather than arbitrarily accessing `Skin` here and there.

  Salman Ahmed · 2021-06-11 12:44:44 +03:00
  fbb856d84b
• Forward all base transformer lookup methods to Skin
  Salman Ahmed · 2021-06-11 12:44:25 +03:00
  e59beffc4e
• Refactor disallowing in SkinProvidingContainer to become per source

  Fixes `FindProvider` becoming completely broken, because of no way to perform the checks on one skin source.

  Salman Ahmed · 2021-06-11 12:29:29 +03:00
  9e16359f18
• Move TODO comment to correct location
  Salman Ahmed · 2021-06-11 11:46:30 +03:00
  2e01e61177
• Add other affectable change action cases
  Salman Ahmed · 2021-06-11 11:34:22 +03:00
  8132852753
• Apply documentation settings for better readability

  Co-authored-by: Dean Herbert <pe@ppy.sh>
  Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>

  Salman Ahmed · 2021-06-11 11:25:07 +03:00
  a985e3b8d3
• Update xmldoc
  Dean Herbert · 2021-06-11 14:50:21 +09:00
  debd359d2e
• Expose as Skins and consume SkinInfo from instances
  Dean Herbert · 2021-06-11 14:49:35 +09:00
  b9050f91a4
• Refrain from attempting to clear skin sources in disposal

  `Drawable.Dispose` is usually in an asynchronous context (async disposals stuff) and therefore this could cause a "collection was modified; enumeration opeartion may not execute" exception.

  Salman Ahmed · 2021-06-10 17:23:16 +03:00
  2240e2c39c
• Consume new method rather than caching skin sources on top of Player
  Salman Ahmed · 2021-06-10 16:36:46 +03:00
  680791301f
• Add method for assigning arbitrary skins to player in test scenes
  Salman Ahmed · 2021-06-10 16:36:46 +03:00
  23d6c366ac
• Make RulesetSkinProvidingContainer able to be overriden for testing purposes
  Salman Ahmed · 2021-06-10 16:36:46 +03:00
  ef2c4fd0d8
• Refrain from attempting to transform null skins
  Salman Ahmed · 2021-06-10 16:36:45 +03:00
  09a2d008d2
• Switch state case placements for consistency

  Tickled me.

  Salman Ahmed · 2021-06-10 13:15:18 +03:00
  5c9c424a0d
• Remove stale access to Source from master merge
  Salman Ahmed · 2021-06-10 13:07:32 +03:00
  26cdcc8d78
• Expose default SkinManager providers for use in RulesetSkinProvidingContainer
  Salman Ahmed · 2021-06-10 13:07:32 +03:00
  c3a2f2c2a4
• Change SkinSources to a bindable list for binding SourceChanged events
  Salman Ahmed · 2021-06-10 13:07:32 +03:00
  59be3588eb
• Merge branch 'master' into transformers-per-skin
  Salman Ahmed · 2021-06-10 11:58:52 +03:00
  dde84e5cbd
• Revert "Expose the skin lookup layers of SkinManager to a property"

  This reverts commit 9e652715ce.

  Salman Ahmed · 2021-06-10 11:57:28 +03:00
  58cca9da06
• Add simple xmldoc to ctors explaining their deal with SkinSources
  Salman Ahmed · 2021-06-10 11:56:13 +03:00
  530026b675
• Remove mentioning of "layer" in skin providers

  `SkinSources` sounds better.

  Salman Ahmed · 2021-06-10 11:55:26 +03:00
  18edbdd135
• Merge pull request #13401 from peppy/no-unranked-display

  Remove the concept of "unranked" mods

  Dan Balasescu · 2021-06-10 17:51:31 +09:00
  3cd7d45b0f
• Merge pull request #13404 from peppy/fix-beatmap-skin-disables

  Fix `FindProvider` calls on `SkinProvidingContainer` not considering disable flags

  Dan Balasescu · 2021-06-10 17:23:46 +09:00
  c06c447564
• Merge branch 'master' into no-unranked-display
  Dan Balasescu · 2021-06-10 17:09:46 +09:00
  a44fd887ee
• Merge pull request #13379 from ekrctb/catcher-sprite

  Refactor osu!catch catcher sprite to factor out skinning logic

  Dean Herbert · 2021-06-10 16:52:17 +09:00
  05b46b4743
• Merge branch 'master' into fix-beatmap-skin-disables
  Dan Balasescu · 2021-06-10 16:37:58 +09:00
  479d6d3fc5
• Merge pull request #13408 from peppy/default-skin-fallback

  Add fallback lookup support for `DefaultSkin`

  Dan Balasescu · 2021-06-10 16:37:48 +09:00
  4eab717a80
• Merge pull request #13427 from Joehuu/fix-stats-forever-dimming

  Fix background being dimmed forever after toggling statistics in results screen

  Dean Herbert · 2021-06-10 16:09:14 +09:00
  62b400fea5
• Use [Resolved] to simplify bindable resolution
  Dean Herbert · 2021-06-10 15:47:03 +09:00
  865c5c0676
• Use With to simplify drawable construction
  Dean Herbert · 2021-06-10 15:45:49 +09:00
  6995945360
• Fix background being dimmed forever after toggling statistics in results screen
  Joseph Madamba · 2021-06-09 23:26:57 -07:00
  cc38556f61
• Merge pull request #13384 from bdach/fixed-label-width

  Align label widths of editor setup screen controls

  Dean Herbert · 2021-06-10 14:55:49 +09:00
  9a3ca09501
• Merge pull request #13426 from gagahpangeran/wiki-image-title

  Fix wiki image tooltips not showing inside table views

  Dean Herbert · 2021-06-10 14:28:49 +09:00
  b55a4053cf
• change WikiMarkdownImage to extend OsuMarkdownImage
  Gagah Pangeran Rosfatiputra · 2021-06-10 09:38:48 +07:00
  05cb935a94
• Merge pull request #13425 from Joehuu/score-panel-kb-navigation
  Dean Herbert · 2021-06-10 11:38:17 +09:00
  2b4649a3ea
• create OsuMarkdownImage
  Gagah Pangeran Rosfatiputra · 2021-06-10 09:38:07 +07:00
  28d7b06908
• add image table with image content test
  Gagah Pangeran Rosfatiputra · 2021-06-10 09:37:33 +07:00
  39e1f77d53
• Add ability to navigate score panels with left/right arrows
  Joseph Madamba · 2021-06-09 17:03:46 -07:00
  e3f3c37953
• Apply few adjustments to skinning overlays comment
  Salman Ahmed · 2021-06-09 22:49:31 +03:00
  1aaad7bfd4
• Wrap gameplay content within a RulesetSkinProvidingContainer
  Salman Ahmed · 2021-06-09 22:49:31 +03:00
  e30f6581b3
• Add special RulesetSkinProvidingContainer managing ruleset-compatible skin setup
  Salman Ahmed · 2021-06-09 22:49:31 +03:00
  33a9cac398
• Expose the skin lookup layers of SkinManager to a property
  Salman Ahmed · 2021-06-09 22:49:31 +03:00
  9e652715ce
• Make SkinProvidingContainer able to perform lookup on multiple skins

  Currently `protected` functionality for use in custom `SkinProvidingContainer`s, can be exposed to public constructors if it need to later on, but I'm not sure about doing that opposed to just nesting multiple `SkinProvidingContainer`.

  Salman Ahmed · 2021-06-09 22:49:31 +03:00
  6538d44708
• Convert LegacySkinTransformers to accept raw ISkins rather than a full ISkinSource
  Salman Ahmed · 2021-06-09 22:49:31 +03:00
  cf40282f1f
• Merge branch 'master' into fix-beatmap-skin-disables
  Bartłomiej Dach · 2021-06-09 20:22:00 +02:00
  209f658d05
• Merge pull request #13407 from peppy/fix-results-exit-transition
  Bartłomiej Dach · 2021-06-09 20:16:09 +02:00
  aed490803f
• Merge branch 'master' into fix-results-exit-transition
  Bartłomiej Dach · 2021-06-09 19:40:56 +02:00
  89cdea8123
• Merge branch 'master' into fix-beatmap-skin-disables
  Bartłomiej Dach · 2021-06-09 18:43:15 +02:00
  266c1e2e25
• Merge pull request #13412 from peppy/update-framework

  Update framework

  Dean Herbert · 2021-06-10 01:41:49 +09:00
  58e00e9e43
• Merge branch 'master' into update-framework
  Bartłomiej Dach · 2021-06-09 17:36:17 +02:00
  222ae40a04