Dean Herbert
6a4933a31c
Remove need for TestRealmLive nonsense
2023-05-05 16:30:43 +09:00
Dean Herbert
0158102467
Rename class back to original name so I can read the diff
2023-05-05 16:19:10 +09:00
Dean Herbert
3d55a0291f
Prefer block scoped namespaces
2023-05-05 16:06:02 +09:00
Dean Herbert
b7a287869a
Add display of beatmap slider velocity when adjusting
2023-05-05 15:57:38 +09:00
Dean Herbert
cc70d89bf9
Move editor inspector classes out of ruleset namespace
2023-05-05 15:57:38 +09:00
Dean Herbert
4663057060
Split out EditorInspector implementation for reuse
2023-05-05 15:54:15 +09:00
Dean Herbert
76b2f0e6dd
Show slider velocity in hit object inspector
2023-05-05 15:15:18 +09:00
Dean Herbert
560f71ef53
Adjust BlurredIcon expansion ratio to fix glow getting cut off at lower resolutions
...
Closes https://github.com/ppy/osu/issues/23210 .
Ballparked the fix to work down to the lowest resolution we support. The
previous number (`2.5f`) was also likely ballparked so the fix seems in
line with expectations.
I don't want to put too much thought into this because the design of
this screen is likely going to change in the mean time anyway.
2023-05-05 14:29:04 +09:00
Dean Herbert
8391e2a538
Move reporting code out of DrawableChatUsername into more correct locations
2023-05-05 14:03:42 +09:00
Dean Herbert
698baa78bf
Merge pull request #22711 from Terochi/keep-shared-settings-ruleset-change
...
Keep shared mod settings when changing ruleset
2023-05-05 13:29:55 +09:00
Bartłomiej Dach
dcd2abae6d
Add test coverage for mod equality with multiple settings
2023-05-04 20:46:27 +02:00
Bartłomiej Dach
6368e1cc53
Merge pull request #22801 from cdwcgt/edit-mods-preset
...
Add ability to edit mod presets
2023-05-04 19:43:42 +02:00
Bartłomiej Dach
a1106d0a4e
Be explicit in test
2023-05-04 19:14:20 +02:00
Bartłomiej Dach
99e8b2ce70
Make getMod() method generally better
2023-05-04 19:12:22 +02:00
Bartłomiej Dach
aa7885ab97
Use better test step names
2023-05-04 19:11:51 +02:00
Bartłomiej Dach
485b7282dc
Clarify type check
2023-05-04 19:06:07 +02:00
Bartłomiej Dach
bdd96caaa9
Merge branch 'master' into edit-mods-preset
2023-05-04 18:59:47 +02:00
Bartłomiej Dach
e43fc23606
Fix typos in test
2023-05-04 18:50:21 +02:00
Bartłomiej Dach
1f1342b099
Reword xmldoc
2023-05-04 18:33:49 +02:00
Bartłomiej Dach
88e77ad390
Rename Settings{-> Map}
2023-05-04 18:30:41 +02:00
Bartłomiej Dach
26337dbcd8
Do not rely on unspecified Dictionary.Values ordering
2023-05-04 18:29:01 +02:00
Bartłomiej Dach
0d2396c557
Rename method to better indicate directionality
2023-05-04 18:15:12 +02:00
cdwcgt
2cb6642b0d
use AddUntilStep or not wait
2023-05-04 13:18:25 +09:00
Dean Herbert
95b541ab39
Update framework
2023-05-04 11:27:18 +09:00
Dean Herbert
0034124d79
Remove unnecessary content clear
2023-05-04 11:25:10 +09:00
Dean Herbert
26b8c5b852
Fix mod list display not updating after clicking "use current"
...
This is not a regression from my changes. It was broken before them.
2023-05-04 11:23:51 +09:00
Dean Herbert
49fb5da1a2
Stop passing preset panel to popover
2023-05-04 11:19:09 +09:00
Dean Herbert
b12d139317
Remove dead code
2023-05-04 11:16:52 +09:00
Dean Herbert
99d2616c34
Move drawable construction to load for simplicity
2023-05-04 11:14:51 +09:00
Dean Herbert
be995f1359
Add localisation support for new button string
2023-05-04 11:11:19 +09:00
Dean Herbert
b7abab6d8a
More variable improvements
2023-05-04 11:10:05 +09:00
Dean Herbert
0a584f0652
Simplify check logic and improve variable naming
2023-05-04 11:07:09 +09:00
Bartłomiej Dach
2bd07cc0d9
Merge pull request #23344 from Terochi/skin-editor-change-handler-improvement
...
Implement better logic for `ApplyStateChange` in skin editor
2023-05-03 20:36:15 +02:00
Bartłomiej Dach
59ece64d25
Merge branch 'master' into skin-editor-change-handler-improvement
2023-05-03 19:42:42 +02:00
Bartłomiej Dach
1d4d31e35c
Trim comments
...
Leaving only the ones that add anything useful and do not restate the
code verbatim.
2023-05-03 19:22:52 +02:00
Bartłomiej Dach
27fabd99fb
Rename variables for legibility
...
Having `typedComponents` and `typeComponents` next to each other is
asking for trouble.
2023-05-03 19:21:16 +02:00
Bartłomiej Dach
a45f0b65a1
Merge pull request #23372 from peppy/fix-slider-end-circle-appear-delay
...
Fix fade in delay for first slider end circle being incorrect when snaking disabled
2023-05-03 19:06:39 +02:00
Terochi
d1d4b54c64
Simplified
2023-05-03 18:31:35 +02:00
Bartłomiej Dach
fa3f42ba75
Merge pull request #23386 from peppy/fix-osu-logo-input-handling
...
Extend input handling of osu! logo to full border area
2023-05-03 17:48:51 +02:00
cdwcgt
4549a865d9
Merge branch 'master' into export
2023-05-04 00:18:01 +09:00
cdwcgt
967e801f9c
code inspect
2023-05-03 23:26:58 +09:00
cdwcgt
debbd376bd
move scrollContent update logic to updateActiveState()
2023-05-03 23:24:14 +09:00
cdwcgt
f4b1264cc9
use button Enable status to ensure preset name is not null
2023-05-03 23:22:46 +09:00
cdwcgt
aa5a026c67
remove local button handle
2023-05-03 23:14:24 +09:00
cdwcgt
c609e6345c
remove Use Current Mods menu item
2023-05-03 23:02:50 +09:00
cdwcgt
3a15783a3c
remove wait, use AddUntilStep
2023-05-03 22:59:01 +09:00
cdwcgt
25bf4e68ec
remove useless wait
2023-05-03 22:53:13 +09:00
Bartłomiej Dach
0ba31c5709
Merge pull request #23388 from peppy/fix-song-select-drawable-carousel-beatmap-leak
...
Fix runaway memory usage at song select when opening many beatmaps many times
2023-05-03 14:32:13 +02:00
Dean Herbert
be15d07b17
Tidy up various implementation details
2023-05-03 18:59:39 +09:00
Dean Herbert
b932e4d986
Rename DrawableUsername to DrawableChatUsername and only pass message ID
2023-05-03 18:53:22 +09:00
