1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-18 05:52:56 +08:00
Commit Graph

62649 Commits

Author SHA1 Message Date
Joseph Madamba
f6741514aa Remove alternative total score display (colour gradient) for now
For simplicity and a future consideration for when the skinning portion is implemented.
2023-10-11 09:41:02 -07:00
Joseph Madamba
42d41add41 Remove unused field 2023-10-11 09:41:02 -07:00
Joseph Madamba
e32be36d92 Move invalidation issue todo to tests 2023-10-10 22:29:43 -07:00
Joseph Madamba
f2aff628b2 Fix statistics container showing for a brief moment on lower widths 2023-10-10 22:17:31 -07:00
Joseph Madamba
ba62498478 Add set up steps to reinit drawables with a different relative width 2023-10-10 20:47:15 -07:00
Joseph Madamba
e4f1eab6ad Add experimental collapse content logic based on width 2023-10-10 20:47:15 -07:00
Joseph Madamba
e049a072f8 Update right content to latest design
- Add more scenarios to test
- Future-proof mods display to not overflow
2023-10-10 20:24:25 -07:00
Joseph Madamba
3c1d15d9b7 Fix user cover having shear 2023-10-10 20:24:25 -07:00
Joseph Madamba
3ad5a7c661 Reduce indents of private container methods 2023-10-10 18:39:35 -07:00
Joseph Madamba
e0c6c1bc66 Fix rank label tooltip area 2023-10-10 18:26:00 -07:00
Joseph Madamba
837437ac57 Rename createRightSideContent() to createRightContent() 2023-10-10 18:26:00 -07:00
Joseph Madamba
bb3f426b93 Truncate name label and clean up positioning code
Also adds a test score with a long username.
2023-10-10 18:26:00 -07:00
Joseph Madamba
6087c12d85 Use grid container for centre content 2023-10-10 18:26:00 -07:00
Joseph Madamba
43c8d51d02 Add draw width statistic to test 2023-10-10 16:47:33 -07:00
Joseph Madamba
39b008b070 Move test scores to a method and add TestResources.CreateTestScoreInfo() 2023-10-10 16:47:33 -07:00
Joseph Madamba
668e083ddc Use AutoSizeAxes instead of hardcoded Size 2023-10-10 16:47:33 -07:00
Joseph Madamba
dad03778b7 Fix leaderboard score caching colour provider 2023-10-10 16:47:33 -07:00
Joseph Madamba
c0b8b3509f Populate dates and add show animation on test 2023-10-10 16:47:33 -07:00
Joseph Madamba
5bea5415be Remove weird yellow background override on mods
To who's reading, don't follow figma designs all the time. In most cases, follow what other places are doing.
2023-10-10 16:47:33 -07:00
Joseph Madamba
236352a176 Add shadow to centre content
Done this way instead of edge effect because of 1px/dimming issues.
2023-09-22 19:59:40 -07:00
Joseph Madamba
f7f390195a Add user covers to centre content 2023-09-22 19:59:40 -07:00
Joseph Madamba
2bd28e6718 Move drawable init properties to constructor 2023-09-22 19:59:40 -07:00
Joseph Madamba
228731493e Add relative width slider to test 2023-09-22 19:59:40 -07:00
Joseph Madamba
9f9f7eb01b Nuke hit results display 2023-09-22 19:59:40 -07:00
Joseph Madamba
6ed1685223 Fix/update score exporting method 2023-09-22 19:59:40 -07:00
Joseph Madamba
70b16d7246 Merge remote-tracking branch 'upstream/master' into pr/22237 2023-09-21 22:51:23 -07:00
Salman Ahmed
d18bd2d2ac
Merge pull request #24880 from bdach/flaky-scoreboard-test
Fix `TestFriendScore` intermittently failing due to randomness
2023-09-22 02:09:04 +03:00
Bartłomiej Dach
e45d456324
Fix TestFriendScore intermittently failing due to randomness
If `createRandomScore()` happened to randomly pick the highest total
score when called with `friend` as the sole argument, that particular
score would not be pink.

`GetScoreByUsername()` would arbitrarily pick the first score for the
user, so in this particular case where a friend had the number 1 score,
the test would wrongly fail.

Fix by checking whether any of the 3 added friend scores have received
the pink colour. Because there is more than 1 friend score in the test,
doing so ensures that at least one of those should eventually become
pink (because, obviously, you can't have two scores at number 1).
2023-09-21 21:12:44 +02:00
Bartłomiej Dach
9301a1907a
Rewrite TestFriendScore assertions to constraint model
Allows to clearly see what the failure is:

	TearDown : System.TimeoutException : "friend score is pink" timed out: Expected: some item equal to "#FF549A"
	  But was:  < "#FFFFFF", "#7FCC33", "#444444" >

The #7FCC33 colour is used for the first score on the leaderboard.
2023-09-21 21:05:41 +02:00
Bartłomiej Dach
561f66400a
Merge pull request #24878 from peppy/fix-song-select-shift-delete
Fix shift-delete not working at song select
2023-09-21 20:48:42 +02:00
Bartłomiej Dach
d73f06fc89
Add test coverage for delete hotkey 2023-09-21 20:01:59 +02:00
Salman Ahmed
5266cdc722 Add explanatory note 2023-09-21 20:41:10 +03:00
Salman Ahmed
095812c6b8
Merge branch 'master' into fix-song-select-shift-delete 2023-09-21 20:25:43 +03:00
Salman Ahmed
1f3a660443
Merge pull request #24870 from peppy/update-framework
Update clocks in line with framework changes
2023-09-21 20:25:08 +03:00
Salman Ahmed
9e4a56d64e
Merge branch 'master' into update-framework 2023-09-21 19:49:20 +03:00
Dean Herbert
f1258a3963 Update framework 2023-09-22 01:26:38 +09:00
Dean Herbert
9af4e75dfc Disable clipboard export for song select textbox
In combination with https://github.com/ppy/osu-framework/pull/5997,
closes https://github.com/ppy/osu/issues/24867
2023-09-22 01:24:29 +09:00
Bartłomiej Dach
08ef840370
Merge pull request #24550 from smoogipoo/mania-edit-disable-sv
Adjust osu!taiko and osu!mania editors to not visualise velocity changes by default
2023-09-21 09:50:55 +02:00
Bartłomiej Dach
69ed99dfd5
Merge branch 'master' into mania-edit-disable-sv 2023-09-21 09:13:27 +02:00
Bartłomiej Dach
b81e1ce4b2
Merge pull request #24875 from peppy/update-readme
General improvements to README
2023-09-21 09:04:49 +02:00
Dean Herbert
8ef0ef09db Reword release build disclaimer 2023-09-21 14:59:37 +09:00
Dean Herbert
0eab4c5364
Reword sentence with multiple ands
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-09-21 14:47:55 +09:00
Dean Herbert
262916787e
Apply punctuation and terminology fixes
Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>
2023-09-21 13:27:00 +09:00
Dean Herbert
9629f49afb Update build instructions to be more clear about slnf files and mention workloads 2023-09-21 11:57:10 +09:00
Dean Herbert
fc6abae968 Remove note about dotnet CLI tools not working (less relevant post-EF) 2023-09-21 11:56:49 +09:00
Dean Herbert
c76853c32c Add mention of new project 2023-09-21 11:56:32 +09:00
Dean Herbert
2954ad7834 Update language across whole readme to read better 2023-09-21 11:56:23 +09:00
Dean Herbert
8a3d412ffc Remove mention of no-heated-gameplay-mechanics discussions
We're kinda at the point we're allowing this now.
2023-09-21 11:38:16 +09:00
Dean Herbert
bf984388b3 Update clocks in line with framework changes 2023-09-20 21:17:08 +09:00
Bartłomiej Dach
f2791d4f3e
Move comment a bit to fix formatting
Would otherwise trigger IDE0055, but that isn't resolveable without
an inspection cycle with resharper, so just move in a more sane place.
2023-09-20 12:22:05 +02:00