Bartłomiej Dach
f5c5614eef
Resolve existing colour provider instead of re-caching own one
2024-09-08 16:29:53 +02:00
schiavoanto
2e6f17f253
Fixed wrong OverlayColourScheme
2024-09-08 16:04:10 +02:00
schiavoanto
cf23c6668c
Added background color to hide beatmap background
2024-09-08 15:59:23 +02:00
schiavoanto
2bc6547d49
Code quality fix: added type
2024-09-07 16:23:23 +02:00
schiavoanto
32de8e9b2d
Fixed ControlPointTable items being blocked by buttons
2024-09-07 16:15:00 +02:00
Dean Herbert
7f687d545d
Merge pull request #29715 from bdach/fix-stall-on-empty-replay-import-attempt
...
Fix stall when attempting to import replay after hitting nothing
2024-09-07 22:01:31 +09:00
Dean Herbert
10ef5a6d6d
Update framework
2024-09-07 21:46:43 +09:00
Dean Herbert
f3a07654d1
Merge pull request #29743 from smallketchup82/fix-file-associations
...
Fix file associations not updating or uninstalling
2024-09-07 21:23:51 +09:00
Dan Balasescu
02eb6835e3
Merge pull request #29745 from Ianlucht/fix-beatmap-artist-and-title-search-to-include-double-quotes-resolves#29708
...
Double-quote in beatmap listing when searching by artist/title
2024-09-07 18:42:27 +09:00
Dan Balasescu
ac6cce5911
Refactor to string interpolation
2024-09-07 17:40:33 +09:00
Dan Balasescu
6fb5c10f19
Merge pull request #29742 from SchiavoAnto/29736-results-collections-overflow
...
Fix collections overflowing in the results screen
2024-09-07 17:37:11 +09:00
Dan Balasescu
f1c024d3f0
Merge pull request #29759 from Bruno5430/fix-default-effect-control-point
...
Fix scroll speed slider defaulting to 0.01
2024-09-07 17:36:59 +09:00
Dean Herbert
9b189fd244
Fix windows check weirdness
2024-09-07 13:58:17 +09:00
Dean Herbert
41d32ab2ca
Fix display length not resetting to default because default was wrong
...
Closes https://github.com/ppy/osu/issues/29757 .
2024-09-07 13:54:12 +09:00
Bruno Heredia
3b81ad4cbf
Fix scroll speed slider defaulting to 0.01
2024-09-07 01:44:40 -03:00
Ianlucht
581f190856
fixed issues with search by adding the double quotation marks in the BeatmapSetHeaderContents links.
2024-09-06 16:31:48 -06:00
schiavoanto
ed044d5b85
Fix proposal for #29736
2024-09-06 22:58:18 +02:00
smallketchup82
575da0992f
Fix file associations not updating & uninstalling
2024-09-06 16:16:40 -04:00
Bartłomiej Dach
4e9ad1388f
Fix stall when attempting to import replay after hitting nothing
2024-09-06 13:16:58 +02:00
Bartłomiej Dach
7e53df5226
Add failing test coverage
2024-09-06 13:15:21 +02:00
Dean Herbert
04d133832f
Merge pull request #29711 from smoogipoo/add-played-acronyms
...
Add 'yes'/'no' acronyms to the `played=` filter
2024-09-06 18:08:37 +09:00
Dean Herbert
a912d86dc9
Merge pull request #29710 from bdach/silence-favourite-button-errors
...
Silence beatmap retrieval failures from results screen favourite button
2024-09-06 18:08:32 +09:00
Dan Balasescu
6913d75792
Add 'yes'/'no' acronyms to the played= filter
2024-09-06 18:04:39 +09:00
Bartłomiej Dach
9f834ca1a2
Silence beatmap retrieval failures from results screen favourite button
...
As reported (very poorly) in
https://github.com/ppy/osu/pull/28991#issuecomment-2331854970 .
I believe this is a total edge case and is mostly visible on dev due to
some beatmaps existing on `osu.ppy.sh` and not on `dev.ppy.sh`, but I
tend to agree in general that these types of failures should not be
firing very loud error notifications; logging to network and disabling
the button with a tooltip adjustment should be enough.
2024-09-06 10:29:23 +02:00
Bartłomiej Dach
925710d9b3
Merge pull request #29702 from peppy/fix-offset-control-wrong-order
...
Fix beatmap offset control not working correctly when calibrating from quitting gameplay
2024-09-06 09:39:14 +02:00
Dean Herbert
36a30cf077
Add note about using hard links in the future
2024-09-06 16:01:47 +09:00
Dean Herbert
96042349ac
Merge pull request #29707 from Sheppsu/replay-analysis-marker-depth
...
Fix replay analysis marker depth when rewinding
2024-09-06 12:03:35 +09:00
Sheppsu
e94e08fec3
fix marker depth when rewinding
2024-09-05 20:14:36 -04:00
Dean Herbert
9802b59459
Merge pull request #29693 from bdach/editor/setup-screen-textbox
...
Implement "form" text box control
2024-09-05 19:31:02 +09:00
Dean Herbert
37f61b26ea
Fix offset adjust control not correctly applying changes after song select quit
...
This is an interesting scenario where we arrive at a fresh
`BeatmapOffsetControl` but with a reference score (from the last play).
Our best assumption here is that the beatmap's offset hasn't changed
since the last play, so we want to use it for the `lastPlayBeatmapOffset`.
But due to unfortunate order of execution, `Current.Value` was not yet
initialised.
2024-09-05 19:04:52 +09:00
Dean Herbert
791ce218fc
Add test coverage of beatmap offset edge case failure
2024-09-05 19:04:52 +09:00
Dean Herbert
c51503cfee
Merge pull request #29695 from peppy/fail-t-request-on-null-response
...
Trigger request failure on receiving a null response for a typed `APIRequest`
2024-09-05 18:31:54 +09:00
Bartłomiej Dach
3a3a912ebc
Merge pull request #29701 from peppy/fix-gc-fuck-fuck-fuck
...
Fix high performance session potentially getting stuck after multiplayer spectator
2024-09-05 11:24:54 +02:00
Bartłomiej Dach
49b14ad579
Merge branch 'master' into editor/setup-screen-textbox
2024-09-05 11:22:10 +02:00
Bartłomiej Dach
e1b763ff0d
Apply review suggestions wrt border appearance
2024-09-05 11:21:59 +02:00
Dean Herbert
446c8109b7
Merge pull request #27334 from Sheppsu/replay-analysis-settings
...
Add a replay analysis overlay
2024-09-05 17:43:00 +09:00
Dean Herbert
86a06c7e10
Fix high performance session potentially getting stuck after multiplayer spectator
2024-09-05 17:19:53 +09:00
Bartłomiej Dach
b9ddac4201
Fix test failures
2024-09-05 09:45:37 +02:00
Bartłomiej Dach
7136483f85
Fix nullability inspections
2024-09-05 09:45:34 +02:00
Dean Herbert
167e3a3377
Make loading asynchronous
2024-09-05 16:25:08 +09:00
Dean Herbert
a1cf67be62
Add setting to adjust replay analysis display length
2024-09-05 15:53:53 +09:00
Dean Herbert
0f01a855af
Add note about cursor hiding being potentially flaky
2024-09-05 15:30:42 +09:00
Dean Herbert
47a9b345eb
Rename config variables and setting strings
2024-09-05 15:15:15 +09:00
Dean Herbert
7983a765ab
Update test scene to show more button holds (including both buttons sometimes)
2024-09-05 15:12:53 +09:00
Dean Herbert
7390d89c75
Switch to using CircularProgress for more consistent sizing
...
Also show both mouse buttons at once on frame markers.
2024-09-05 15:12:53 +09:00
Dean Herbert
4f719b9fec
One more rename pass
2024-09-05 14:28:20 +09:00
Dean Herbert
2d198e57e1
Second visual design pass
2024-09-05 14:17:53 +09:00
Dean Herbert
ee26ff2e29
Add out-of-bounds tests to test case
2024-09-05 13:07:49 +09:00
Dean Herbert
08ebc83a89
Fix path getting misaligned with negative position values
2024-09-05 12:14:24 +09:00
Dean Herbert
21146c3501
Add back shadow cast
2024-09-05 12:08:49 +09:00
