Dean Herbert
f02416f877
Improve visuals of tournament song bar
...
This is a stop-gap until we add new versions (and share between game and tournament client).
2023-08-16 17:16:36 +09:00
Dean Herbert
7f8455eb06
Merge pull request #24402 from QuantumSno/leaderboard-toggle
...
Add ability to toggle gameplay leaderboards with tab key
2023-08-16 16:57:07 +09:00
Dean Herbert
caf0fd0742
Refactor migration to read the same as previous one
2023-08-16 16:21:42 +09:00
Dean Herbert
68db112882
Re-date migration
2023-08-16 16:20:17 +09:00
Dean Herbert
c885b71f3a
Add leaderboard toggle as tracked setting to give better use visibility
2023-08-16 16:17:56 +09:00
Dean Herbert
31c2b7f925
Merge branch 'master' into leaderboard-toggle
2023-08-16 15:49:55 +09:00
Bartłomiej Dach
34a519f803
Merge pull request #24561 from peppy/rename-dummy-local-user
...
Rename "dummy" local user to something more descriptive
2023-08-16 07:34:25 +02:00
Dean Herbert
6001f7e5c7
Rename "dummy" local user to something more descriptive
...
This created weird cases in logs which are very hard to understand. The
one which really got me was this:
```
[runtime] 2023-08-13 07:48:27 [verbose]: Invalidating working beatmap cache for unknown artist - unknown title (Dummy)
```
Which looks like a dummy working beatmap was invalidated, but it turns
out that's just the local user which was populated when creating a new
local beatmap.
2023-08-16 13:52:27 +09:00
Dean Herbert
2a3f7e7362
Merge pull request #24552 from smoogipoo/hold-off-no-end-notes
...
Disable hold end conversion for mania HoldOff mod
2023-08-16 13:26:28 +09:00
Dan Balasescu
5678db4e70
Fix test + cleanup
2023-08-15 19:42:32 +09:00
Dan Balasescu
e34a9a0001
Disable hold end conversion for mania HoldOff mod
2023-08-15 19:30:40 +09:00
Bartłomiej Dach
4e96853c75
Merge pull request #24548 from peppy/fix-score-copy-instability
...
Fix score being cloned in async method causing random crashes
2023-08-15 09:38:38 +02:00
Dean Herbert
e8bde6504a
Fix score being cloned in async method causing random crashes
...
Closes https://github.com/ppy/osu/issues/24445 .
2023-08-15 16:08:13 +09:00
Dean Herbert
526a145b93
Merge pull request #24546 from peppy/update-framework
...
Update framework
2023-08-15 15:34:56 +09:00
Dean Herbert
3526032c9a
Merge pull request #24544 from smoogipoo/pool-mania-barlines
...
Add pooling for mania barlines
2023-08-15 15:21:59 +09:00
Dean Herbert
57e49495bc
Merge pull request #24547 from bdach/slider-kiai-stars-broke
...
Fix kiai stars flickering on and off during gameplay
2023-08-15 15:21:46 +09:00
Bartłomiej Dach
ab1d523528
Fix kiai stars flickering on and off during gameplay
...
Closes #24503 .
The problematic reset of `lastParticleAdded` has been moved to a place
that should hopefully (a) not cause such problems and (b) be much more
explicit about what's happening.
2023-08-15 07:44:05 +02:00
Dean Herbert
8c14ff674e
Update framework
2023-08-15 14:33:21 +09:00
Dean Herbert
31c31a9359
Merge pull request #24528 from bdach/fix-dual-stages-skinnable-layer
...
Fix playfield skinnable layer bounds being incorrectly calculated with multiple stages
2023-08-15 14:29:18 +09:00
Dan Balasescu
e9621e7d6e
Adjust test to share barline between stages
2023-08-15 13:34:02 +09:00
Dan Balasescu
6a7b0786c9
Add barline pooling for mania
2023-08-15 13:33:49 +09:00
Bartłomiej Dach
01eceea72f
Merge pull request #24540 from peppy/remove-fps-fade-in-out
...
Don't completely fade FPS counter out when running at full FPS
2023-08-14 19:26:59 +02:00
Bartłomiej Dach
9e7cc05138
Merge branch 'master' into remove-fps-fade-in-out
2023-08-14 18:46:30 +02:00
Bartłomiej Dach
7dd82841ea
Merge pull request #24541 from smoogipoo/fix-incorrect-cast
...
Fix incorrect truncation to int
2023-08-14 18:46:10 +02:00
Dan Balasescu
90d7e46e20
Fix incorrect truncation to int
2023-08-15 00:58:13 +09:00
Dean Herbert
34c761946c
Don't completely fade FPS counter out when running at full FPS
...
I've heard multiple times from uses that this is distracting or
confusing.
2023-08-14 23:55:57 +09:00
Dean Herbert
fd3f5d8e79
Merge pull request #24538 from smoogipoo/temp-optional-difficulty-attribs
...
Temporarily allow new difficulty attributes to not exist
2023-08-14 17:33:30 +09:00
Dan Balasescu
d1a4a46fd3
Temporarily allow new difficulty attributes to not exist
2023-08-14 16:59:01 +09:00
Bartłomiej Dach
4152b4e523
Remove duplicated test case
2023-08-12 22:46:18 +02:00
Bartłomiej Dach
3178865cd3
Fix playfield skinnable layer bounds being incorrectly calculated with multiple stages
...
Closes #24514 .
The original PR was _supposed_ to be handling this, and had code that
_looked_ like it would handle it, but was in fact subtly wrong, as the
union of `RectangleF.Empty` (initial value of `area`) and an arbitrary
other rectangle is _not_ the second rectangle, but rather a rectangle
that contains _both_ the second rectangle and the point (0,0),
thus leading to the bound calculation fail.
2023-08-12 21:55:20 +02:00
QuantumSno
a0543d97bd
Merge branch 'master' into leaderboard-toggle
2023-08-12 11:21:02 -04:00
Bartłomiej Dach
d2baffa0e7
Merge pull request #24518 from peppy/update-framework
...
Update framework
2023-08-12 11:44:25 +02:00
Dean Herbert
0eaa383120
Update framework
2023-08-12 17:54:05 +09:00
Dean Herbert
7fa3508a0b
Merge pull request #24511 from bdach/legacy-exporter-not-converting
...
Fix legacy beatmap exporter not converting beatmap between decode and re-encode
2023-08-12 14:28:08 +09:00
QuantumSno
e9bb9434e9
Merge remote-tracking branch 'origin/leaderboard-toggle' into leaderboard-toggle
2023-08-12 00:19:48 -04:00
QuantumSno
562af8b46d
Updated test TestSceneGameplayChatDisplay.cs. Now uses new default bind for toggle chat (enter)
2023-08-12 00:18:10 -04:00
Bartłomiej Dach
253392409e
Fix LegacyBeatmapExporter not converting beatmap between decode and re-encode
2023-08-12 00:50:31 +02:00
Bartłomiej Dach
37361cd683
Repurpose Flat{File -> }WorkingBeatmap
2023-08-12 00:49:42 +02:00
Dean Herbert
896cbb0ba0
Update framework
2023-08-11 21:34:59 +09:00
Bartłomiej Dach
2b738edb93
Reword / fix comments
2023-08-10 22:55:02 +02:00
Bartłomiej Dach
1b3806539a
Merge branch 'master' into leaderboard-toggle
2023-08-10 22:50:55 +02:00
QuantumSno
5d6ebb4df9
Removed comments organizing GlobalActionContainer.cs, since they were incorrectly grouping actions
2023-08-10 10:18:15 -04:00
QuantumSno
71c42167e7
Updated wording on realm comments
2023-08-10 10:17:12 -04:00
Dean Herbert
5b44124ecf
Merge pull request #24409 from cdwcgt/tournament-nullable
...
Remove #nullable disable in tournament
2023-08-10 19:38:16 +09:00
Bartłomiej Dach
3501b7c22b
Fix some more nullability inspections
2023-08-09 21:32:46 +02:00
Dean Herbert
4e83245acf
Apply nullability to all remaining tests where it wasn't applied
2023-08-10 00:24:57 +09:00
Dean Herbert
6549ca5304
Revert some usages of AsNonNull() in tests
...
We generally prefer `!` when it is unambiguous usage (ie. direct access).
2023-08-10 00:20:37 +09:00
cdwcgt
5ad80879b7
let MatchIPCInfo .Beatmap be nullable
2023-08-09 19:13:49 +09:00
cdwcgt
5898a9986b
Revert "use no null when true"
...
This reverts commit 6ad8339c66
2023-08-09 19:11:36 +09:00
Dean Herbert
c88045dfc7
Fix weird usage of Cast
2023-08-09 18:21:57 +09:00
