Dean Herbert
|
a6343a669c
|
Merge pull request #24422 from bdach/multiplayer-exit-reliability
Fix multiplayer match screen being exited from when not current
|
2023-07-30 23:33:32 +09:00 |
|
Bartłomiej Dach
|
d3435483eb
|
Fix multiplayer match screen being exited from when not current
This was supposed to be fixed by #24255, but has popped up as a
regression on Sentry since:
https://sentry.ppy.sh/organizations/ppy/issues/22749/?project=2&referrer=regression_activity-email
On a fifteen-minute check I cannot figure out how to reproduce, so
rather than spending further brain cycles on this, just apply the same
explicit guard that like fifteen other places do.
|
2023-07-30 15:50:10 +02:00 |
|
Bartłomiej Dach
|
3e801d8696
|
Merge pull request #24419 from peppy/fix-replay-export-queued-op
Fix replay being unexpected exported at results screen after score switch
|
2023-07-30 15:31:17 +02:00 |
|
Bartłomiej Dach
|
1f7f336fd5
|
Merge branch 'master' into fix-replay-export-queued-op
|
2023-07-30 14:58:14 +02:00 |
|
Dean Herbert
|
15b5b481aa
|
Merge pull request #24421 from bdach/fix-nrt
|
2023-07-30 21:43:08 +09:00 |
|
Bartłomiej Dach
|
1981e49a40
|
Fix nullability inspection
|
2023-07-30 14:28:16 +02:00 |
|
Bartłomiej Dach
|
b51e577239
|
Merge pull request #24418 from peppy/now-playing-async-fix
Fix now playing overlay background occasionally showing incorrect background
|
2023-07-30 14:05:49 +02:00 |
|
Bartłomiej Dach
|
898913f32a
|
Merge pull request #24415 from peppy/multi-spectator-improvements
General visual improvements to mutliplayer spectatator screen
|
2023-07-30 12:43:26 +02:00 |
|
Bartłomiej Dach
|
e208f38bcb
|
Merge pull request #24361 from peppy/fix-editor-global-music-hotkey-conflicts
Disallow interacting with the global track state in `Player` and `Editor`
|
2023-07-30 12:28:53 +02:00 |
|
Dean Herbert
|
6d5b3617b3
|
Remove pending export operation if active score is changed
|
2023-07-30 16:41:45 +09:00 |
|
Dean Herbert
|
35ec55c1f6
|
Don't queue export replay operations if button is disabled
|
2023-07-30 16:41:33 +09:00 |
|
Dean Herbert
|
de61b74e91
|
Add proper cancellation and out-of-order blocking logic to NowPlayingOverlay's background carousel
|
2023-07-30 16:21:35 +09:00 |
|
Dean Herbert
|
07d224ecb6
|
Apply NRT to NowPlayingOverlay
|
2023-07-30 16:17:04 +09:00 |
|
Dean Herbert
|
4f83c8661a
|
Remove unnecessary async fetch of beatmap in NowPlayingOverlay
No idea if this was historically required for some reason, but it's
definitely not required now.
|
2023-07-30 16:16:25 +09:00 |
|
Dean Herbert
|
45ceaba00d
|
Disable multiplayer spectator zoom when there's only one player's screen visible
|
2023-07-30 14:40:58 +09:00 |
|
Dean Herbert
|
feea412bec
|
Add test with only one player
|
2023-07-30 14:40:24 +09:00 |
|
Dean Herbert
|
7138291636
|
Adjust xmldoc to explicitly metnion it only affects end user control
|
2023-07-30 13:52:58 +09:00 |
|
Dean Herbert
|
945d89e955
|
Move disables to loading screens for better coverage of edge cases
|
2023-07-30 13:45:42 +09:00 |
|
Joseph Madamba
|
4ddf05602f
|
Update BreakInfoLine to formatting standards
|
2023-07-29 11:05:15 -07:00 |
|
Joseph Madamba
|
6ebfafa9c3
|
Remove unnecessary text comparison
|
2023-07-29 11:02:04 -07:00 |
|
cdwcgt
|
404a927caf
|
fix Possible NullReferenceException in test
|
2023-07-30 02:56:52 +09:00 |
|
cdwcgt
|
99dd156d53
|
remove useless using
|
2023-07-30 02:50:16 +09:00 |
|
cdwcgt
|
5d09eca104
|
revert test change
|
2023-07-30 02:49:30 +09:00 |
|
cdwcgt
|
ba80d1e2d5
|
remove nullable for Box
|
2023-07-30 02:49:13 +09:00 |
|
cdwcgt
|
0590121309
|
string mod should not null
Already assigned in the constructor
|
2023-07-30 02:41:45 +09:00 |
|
cdwcgt
|
bc2ca11bb0
|
move to initialiser
|
2023-07-30 02:41:45 +09:00 |
|
cdwcgt
|
a1f0e59784
|
remove null check for b.Beatmap
|
2023-07-30 02:41:44 +09:00 |
|
cdwcgt
|
6ad8339c66
|
use no null when true
|
2023-07-30 02:41:25 +09:00 |
|
Joseph Madamba
|
740898dffb
|
Remove unnecessary prefix parameter
|
2023-07-29 10:40:18 -07:00 |
|
Joseph Madamba
|
9d928c0225
|
Apply NRT to BreakInfoLine
|
2023-07-29 10:39:50 -07:00 |
|
Dean Herbert
|
75625f089e
|
Hide toolbar when entering multiplayer spectator
|
2023-07-30 02:29:14 +09:00 |
|
Dean Herbert
|
38244c081f
|
Further refactorings along with shadow implementation
|
2023-07-30 02:29:14 +09:00 |
|
Dean Herbert
|
84bc14c1dd
|
Improve animation and sizing of maximised screen display
|
2023-07-30 02:29:14 +09:00 |
|
Dean Herbert
|
1826819663
|
Move Facade to nested class
|
2023-07-30 02:29:14 +09:00 |
|
Dean Herbert
|
5fa0a21b56
|
Add corner radius around player areas
|
2023-07-30 02:29:14 +09:00 |
|
QuantumSno
|
65b4ae506e
|
Moved enum to bottom of enumeration table
|
2023-07-29 13:18:47 -04:00 |
|
cdwcgt
|
88a1cf4005
|
remove all canBeNull from attribute
|
2023-07-30 01:57:54 +09:00 |
|
cdwcgt
|
9482f74456
|
fix nullable for TeamList
|
2023-07-30 01:49:57 +09:00 |
|
cdwcgt
|
cb4adf115c
|
RemoveTeam shouldn't have nullable arg
|
2023-07-30 01:40:13 +09:00 |
|
cdwcgt
|
625ed729ee
|
debug assert closest != null
|
2023-07-30 01:39:56 +09:00 |
|
cdwcgt
|
033c9091c0
|
use cast instead AsNonNull
|
2023-07-30 01:39:31 +09:00 |
|
Bartłomiej Dach
|
55cb400674
|
Merge pull request #24386 from peppy/fix-autoplay-mod-revert
Fix temporary auto mod (ctrl+enter at song select) not reverting in all scenarios
|
2023-07-29 16:43:46 +02:00 |
|
Bartłomiej Dach
|
579b0bc570
|
Merge branch 'master' into fix-autoplay-mod-revert
|
2023-07-29 16:12:11 +02:00 |
|
Bartłomiej Dach
|
43a51671ac
|
Fix wrong test step name
|
2023-07-29 16:12:02 +02:00 |
|
cdwcgt
|
4c33013674
|
null check in test
|
2023-07-29 22:41:26 +09:00 |
|
cdwcgt
|
8a06914438
|
remove #nullable disable in tournament
|
2023-07-29 22:25:06 +09:00 |
|
Joseph Madamba
|
a3301dc7ff
|
Fix accuracy break info decimal separator being incorrect in certain languages
|
2023-07-28 23:26:07 -07:00 |
|
Dean Herbert
|
a7ff084be2
|
Merge pull request #24405 from bdach/spinner-input-test
|
2023-07-29 11:34:45 +09:00 |
|
Bartłomiej Dach
|
1fd4a6dc96
|
Fix tests crashing due to HUDOverlay not finding DrawableRuleset in Update()
|
2023-07-29 01:07:49 +02:00 |
|
Bartłomiej Dach
|
cd416e09f9
|
Add test scene for checking spinner judgements
|
2023-07-29 00:49:21 +02:00 |
|