Walavouchey
fd93bd3f50
move rank accuracy requirements to class-local constants
2023-02-09 00:46:24 +01:00
Walavouchey
9544a1d26d
use values closer to the extremities for test cases
2023-02-09 00:02:32 +01:00
Walavouchey
ee40444fd3
use Precision.AlmostEquals for bounds check
2023-02-08 23:59:19 +01:00
Bartłomiej Dach
2873905cc6
Merge pull request #22506 from peppy/skin-editor-undo-support
...
Add very basic skin editor undo / redo support
2023-02-08 19:19:25 +01:00
Bartłomiej Dach
0a5c4e04bf
Merge branch 'master' into skin-editor-undo-support
2023-02-08 18:43:59 +01:00
Walavouchey
0531c010eb
display RankBadges on on their sector centres
...
the D `RankBadge` does this anyway. the A and S badges are slightly off
centre to prevent overlap with the SS badge
2023-02-08 14:01:40 +01:00
Walavouchey
6ace6bfee1
ensure AccuracyCircle doesn't land in gaps created by RankNotches
2023-02-08 13:20:53 +01:00
OpenSauce
df1355ea4b
Taiko hit objects now snap to hit target
2023-02-08 10:59:08 +00:00
Dean Herbert
21fa29f47f
Merge pull request #22545 from Joehuu/fix-user-profile-context-menu
...
Fix beatmap cards not showing context menu on user profile
2023-02-08 17:07:28 +09:00
Joseph Madamba
0156ff732f
Fix beatmap cards not showing context menu on user profile
2023-02-07 22:56:09 -08:00
Dean Herbert
b0131db1dc
Update test assertions in line with new state saving logic
2023-02-08 15:55:17 +09:00
Dean Herbert
17ca26ebee
Remove unnecessary null check on targetScreen
2023-02-08 15:44:24 +09:00
Dean Herbert
3a3c2e78a1
Merge branch 'master' into skin-editor-undo-support
2023-02-08 15:41:58 +09:00
Dean Herbert
4fdba880b1
Fix xmldoc reference fail at CI
2023-02-08 15:39:18 +09:00
Dean Herbert
38031fdf23
Add test coverage of stores stored in database as well
2023-02-08 15:38:07 +09:00
Dean Herbert
d4d985ba0f
Improve test to also check that reverting hash restores old scores
2023-02-08 15:34:46 +09:00
Dean Herbert
c7eec371f5
Clean up tests somewhat
2023-02-08 15:22:17 +09:00
Dean Herbert
78eae171ed
Merge pull request #22507 from Joehuu/fix-comment-padding
...
Fix comments having too much padding at the bottom
2023-02-08 15:01:05 +09:00
Dean Herbert
b6809e156b
Merge pull request #22432 from mk56-spn/sheared_slider_implementation_clean_ii
...
Implement a sheared slider for the updated design
2023-02-08 15:01:00 +09:00
Dean Herbert
c50ea89bc9
Simplify migration to not rely on old/dynamic schema
2023-02-08 14:24:06 +09:00
Dean Herbert
5c113ddb03
Reword xmldoc to read better
2023-02-08 14:20:58 +09:00
Dean Herbert
5cd111e6f1
Fix ordering of methods in OsuSliderBar
2023-02-08 14:01:50 +09:00
Dean Herbert
cec1f77e6c
Fix glow flash occurring after releasing mouse and adjust transition slightly
2023-02-08 13:59:09 +09:00
Cootz
086b3eb542
Fix minor formating issues
2023-02-08 05:50:52 +03:00
Cootz
4ba915268c
Change a comment into RealmAccess
2023-02-08 05:46:47 +03:00
Cootz
ab7c9a200b
Fix a typo
2023-02-08 05:42:06 +03:00
Cootz
6bf56aff73
Add warning for ScoreInfo
2023-02-08 05:40:20 +03:00
Dean Herbert
ee65c65893
Attempt to fix channel join / leave loop
...
I don't have a solid way to repro the issue, but this should hopefully
help in resolving it. Either way, I think this change brings more
correct behaviour (if a websocket message comes through that we have
left the channel, I don't believe we should be sending a request to
leave that channel again).
2023-02-08 11:31:30 +09:00
Cootz
391af2791b
Fix CSharpWarnings::CS1574,CS1584,CS1581,CS1580
2023-02-08 05:23:42 +03:00
Cootz
338d96534a
Add leaderboard test on beatmap update
2023-02-08 05:01:54 +03:00
Joseph Madamba
277f71d36a
Expire reply editor instead of clearing container
2023-02-07 15:15:51 -08:00
PC
7e127dafe2
Update reference
2023-02-07 11:52:47 +03:00
Cootz
957c9e7e27
Update osu.Game/Scoring/ScoreInfo.cs
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2023-02-07 11:23:39 +03:00
Dean Herbert
0320ba770f
Handle component changes via ISkinnableTarget.Components rather than inside SkinEditor directly
...
Seems saner? Maybe?
2023-02-07 16:23:25 +09:00
Dean Herbert
e162fd56da
Change the way initial state saving works in EditorChangeHandler to be closer to first change
2023-02-07 16:22:51 +09:00
Dean Herbert
dad348111d
Fix holding a selection while changing screens causing a crash
2023-02-07 16:07:33 +09:00
Dean Herbert
71eef238c4
Make OnStateChange non-implemented rather than wrong
2023-02-07 16:04:31 +09:00
Adam
d027d69913
Make hit circle fade out into late miss judgement
2023-02-06 19:22:47 -06:00
Adam
5cd973fb34
Add test
2023-02-06 19:20:43 -06:00
Cootz
a1ee3df453
Improve local variable naming
2023-02-07 03:16:25 +03:00
Cootz
1470ea0a31
Remove unnecessary using directives
2023-02-07 03:07:53 +03:00
Cootz
723f13af25
Add summary for OriginalBeatmapHash
2023-02-07 02:43:27 +03:00
Cootz
cb26601cb4
Fix test's score generation
2023-02-07 02:29:28 +03:00
tsrk
da10166628
quality: convert getter property to method so that sensible information can be hidden via an argument
2023-02-06 21:30:55 +00:00
tsrk
1baaae35a9
quality: Simplify string
2023-02-06 20:07:16 +00:00
Bartłomiej Dach
12f6d461b9
Merge pull request #22532 from peppy/fix-long-storyboard-outro
...
Fix storyboard outro time potentially running too long
2023-02-06 20:30:36 +01:00
Bartłomiej Dach
179db09075
Merge pull request #22531 from peppy/apply-future-rider-inspection
...
Apply single inspection from newer inspectcode versions
2023-02-06 20:05:49 +01:00
Bartłomiej Dach
3ee771cbef
Merge pull request #22535 from peppy/forcefully-stop-pause-sample
...
Ensure pause sample loop is stopped on exiting player
2023-02-06 19:51:51 +01:00
tsrk
bc89f8dc5b
feat: add name and rulset verb display support
2023-02-06 12:44:00 +00:00
Cootz
2c7386db39
FIx score appearing on BeatmapLeaderboard and TopLocalRank
2023-02-06 15:14:14 +03:00
