1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-19 01:42:54 +08:00
Commit Graph

49791 Commits

Author SHA1 Message Date
Salman Ahmed
eca7975864 Compute the beatmap maximum achievable combo instead of Beatmap.MaxCombo 2022-03-20 05:38:14 +03:00
Salman Ahmed
d36f32a9c9 Introduce method for computing maximum achievable combo properly 2022-03-20 05:38:14 +03:00
Salman Ahmed
c5cc7eec79 Add explicit todo about removing BeatmapInfo.MaxCombo
Using that property is a trap basically.
2022-03-20 05:38:14 +03:00
Dean Herbert
d681643c38
Merge pull request #17299 from nekodex/arm64
Update download links for macOS builds (to add Apple Silicon)
2022-03-19 20:45:51 +09:00
Dean Herbert
9aa902785c
Merge pull request #17327 from frenzibyte/simplify-extension-methods
Simplify `IncreasesCombo`/`BreaksCombo` helper method implementation
2022-03-19 20:23:09 +09:00
Dean Herbert
acaa3ff21b
Merge pull request #17331 from Sublimelime/make-relax-aimassist-incomp
Make Relax and Aim assist mods incompatible
2022-03-19 20:22:06 +09:00
Dean Herbert
2c5af6265e
Merge pull request #17341 from peppy/fix-spectator-seeks-hot
Fix spectator not starting from current player position (hotfix version)
2022-03-19 20:21:41 +09:00
Bartłomiej Dach
b7d5a628bc
Merge branch 'master' into fix-spectator-seeks-hot 2022-03-19 11:39:01 +01:00
Dean Herbert
89c43d0e07
Merge pull request #17337 from frenzibyte/improve-exit-button-placement
Improve visual behaviour of "hold for menu" to not distract players
2022-03-19 18:18:54 +09:00
Dean Herbert
a903aee17e Use schedule to workaround seek issue instead 2022-03-19 18:00:14 +09:00
Dean Herbert
cf2212e794 Revert "Fix spectator not starting from correct seek point (hotfix)"
This reverts commit 2b59eff465.
2022-03-19 17:20:54 +09:00
Dean Herbert
2b59eff465 Fix spectator not starting from correct seek point (hotfix) 2022-03-19 15:14:25 +09:00
Dean Herbert
63998ad9f1 Add test coverage of SpectatorPlayer failing to seek on inopportune frame arrival time 2022-03-19 15:06:22 +09:00
Dean Herbert
dae5569e36 Use nullable in PlayerLoader 2022-03-19 15:06:22 +09:00
Dean Herbert
da76358ee0 Expose the loading player in PlayerLoader 2022-03-19 15:06:22 +09:00
Salman Ahmed
b99541fb5e Revert "Swap placements of "hold for menu" and key counter"
This reverts commit 5bcb7c167c.
2022-03-19 08:08:07 +03:00
Dean Herbert
e2c0e3bafd
Merge pull request #17322 from frenzibyte/form-bug-report
Add "bug report" GitHub issue form template
2022-03-19 13:54:25 +09:00
Dean Herbert
41ab798bbe
Simplify screenshot/video attach text
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-03-19 12:43:48 +09:00
Dean Herbert
762385d336
Simplify log drag-drop message
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-03-19 12:43:08 +09:00
Dean Herbert
79f6e7cc1c
Simplify wording of description hint
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-03-19 12:42:25 +09:00
Salman Ahmed
ad9b119e3d Reduce "hold for menu" radius of visibility 2022-03-19 05:04:54 +03:00
Salman Ahmed
486be83177 Calculate position adjustment distance in local parent space 2022-03-19 05:04:13 +03:00
Salman Ahmed
5bcb7c167c Swap placements of "hold for menu" and key counter 2022-03-19 05:02:22 +03:00
Salman Ahmed
744cd61643
Apply further minor rewordings
Co-authored-by: Walavouchey <36758269+Walavouchey@users.noreply.github.com>
2022-03-19 03:33:13 +03:00
Salman Ahmed
7bb8cd5411
Apply second pass rewordings on logs section
Co-authored-by: Walavouchey <36758269+Walavouchey@users.noreply.github.com>
2022-03-19 03:22:57 +03:00
Salman Ahmed
c92217415b
Merge pull request #17323 from smoogipoo/fix-intermittent-failure 2022-03-19 03:20:23 +03:00
Salman Ahmed
60390a916a
Merge branch 'master' into fix-intermittent-failure 2022-03-19 02:49:21 +03:00
Salman Ahmed
c07a906b22
Rewrite log attachment section
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-03-19 02:27:40 +03:00
Noah M
78869c462a
Use .Concat() instead of chained Append
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-03-18 14:24:36 -05:00
Noah M
b4a8defe1a Make Relax and Aim assist mods incompatible 2022-03-18 14:12:36 -05:00
Salman Ahmed
8078a8c1f8 Simplify IncreasesCombo/BreaksCombo helper method implementation 2022-03-18 17:18:42 +03:00
Dean Herbert
fc75aa0807
Merge pull request #17324 from frenzibyte/score-panel-max-combo
Display beatmap maximum combo next to score combo in results panel
2022-03-18 22:59:38 +09:00
Dan Balasescu
4b23f02f03
Merge pull request #17320 from peppy/hit-error-meter-settings
Add new settings for adjusting the hit error display
2022-03-18 22:28:20 +09:00
Salman Ahmed
ffa972e9f7
Merge pull request #17325 from peppy/fix-skin-component-toolbox-abstract-class 2022-03-18 15:49:36 +03:00
Salman Ahmed
fa8eb1feec Update score panel to check for all combo-breaking statistics 2022-03-18 15:23:14 +03:00
Salman Ahmed
5ec2d86c09 Update ScoreProcessor to use new defined helper methods 2022-03-18 15:22:53 +03:00
Salman Ahmed
fc576b1369 Separate increase/break combo helper methods from AffectsCombo 2022-03-18 15:22:01 +03:00
Dean Herbert
ed90dc6d6b Fix centering of labels using Height instead of location to better handle rotations 2022-03-18 20:17:04 +09:00
Dean Herbert
806a16d8f6 Fix SkinComponentToolbox attempting to create instances of abstract classes 2022-03-18 20:13:15 +09:00
Dean Herbert
bd488d139d Better centre text labels for hit error meter 2022-03-18 20:11:05 +09:00
Salman Ahmed
2cb1974a58 Add max combo to test beatmap info 2022-03-18 13:11:41 +03:00
Salman Ahmed
af22e67e15 Fix perfect combo check not accounting for LargeTickMiss
`LargeTickMiss` can affect combo, see
a352a140bc/osu.Game/Rulesets/Scoring/HitResult.cs (L124-L144).
2022-03-18 13:11:41 +03:00
Salman Ahmed
9215384229 Display beatmap maximum combo in score panel 2022-03-18 13:11:41 +03:00
Dan Balasescu
c97aa3a26f Fix intermittent ready button test failure 2022-03-18 18:57:34 +09:00
Salman Ahmed
4b0649743a Remove unnecessary description 2022-03-18 12:47:40 +03:00
Salman Ahmed
32faa05b87 Include searching step as part of the bullets 2022-03-18 12:47:33 +03:00
Salman Ahmed
105245a53a
Apply minor rewording suggestions
Co-authored-by: Dean Herbert <pe@ppy.sh>
2022-03-18 12:41:34 +03:00
Salman Ahmed
341201ae55 Add "bug report" issue form template 2022-03-18 12:18:11 +03:00
Dean Herbert
7c9fe4036c Add setting to change the style of the early/late markers 2022-03-18 17:50:37 +09:00
Dean Herbert
919583137e Add line style for centre marker 2022-03-18 17:50:37 +09:00