1069 Commits

• Avoid deadlock during migration failed exit process
  Dean Herbert · 2022-03-29 00:04:13 +09:00
  ea46e024c1
• Limit macOS specific log output to macOS platforms specifically
  Dean Herbert · 2022-03-28 23:46:07 +09:00
  b6ae0ebb6f
• Better inform users of migration failure reason when running Apply Silicon build

  As mentioned in https://github.com/ppy/osu/discussions/17409#discussioncomment-2445464?

  Dean Herbert · 2022-03-28 17:34:36 +09:00
  a98aac3bf2
• Allow realm subscriptions to be initiated from a non-update thread
  Dean Herbert · 2022-03-24 23:41:07 +09:00
  b04ca111c6
• Remove unnecessary MaxCombo migration between unmapped database fields
  Salman Ahmed · 2022-03-20 16:27:54 +03:00
  c2063f415d
• Remove unused variable
  Dean Herbert · 2022-03-08 18:19:54 +09:00
  6565c95b17
• Add flow to allow recovery after running an older release (with a different realm database version)

  As brought up in https://github.com/ppy/osu/discussions/17148

  Dean Herbert · 2022-03-08 18:15:28 +09:00
  0718a55ad0
• Add extension method to detect and isolate realm collection-level changes
  Dean Herbert · 2022-03-08 14:50:47 +09:00
  2a55c5e02e
• Remove redundant string interpolation prefixes
  Bartłomiej Dach · 2022-03-03 20:21:09 +01:00
  0fbc018a42
• Add ability to watch properties via a RealmAccess helper method
  Dean Herbert · 2022-03-03 17:42:40 +09:00
  35f532fefa
• Add detach mapping for BeatmapUserSettings
  Dean Herbert · 2022-03-01 20:12:59 +09:00
  7d11cfb301
• Store and retrieve offset from realm
  Dean Herbert · 2022-03-01 20:12:59 +09:00
  047e801da9
• Store user settings to realm
  Dean Herbert · 2022-03-01 18:44:15 +09:00
  acf8db13ac
• Add RealmAccess.WriteAsync method
  Dean Herbert · 2022-03-01 18:44:05 +09:00
  9a117467b5
• Add global statistics output for all realm reads/writes
  Dean Herbert · 2022-03-01 18:31:18 +09:00
  7fa5842783
• Add AsSplitQuery specification to avoid optimisation recommendation log messages
  Dean Herbert · 2022-02-15 15:23:17 +09:00
  334fe1f120
• Update OsuDbContext in line with EF changes
  Dean Herbert · 2022-02-15 15:19:50 +09:00
  8ec28dc8bc
• Update stream read operations to use new helper methods
  Dean Herbert · 2022-02-11 16:02:25 +09:00
  908c31c687
• Add support for creating new blank difficulties
  Bartłomiej Dach · 2022-02-02 21:55:33 +01:00
  dc96c4888b
• Fix RealmLive unnecessarily passing ID around

  Appears to have never been needed. When the `retrieveFromID` method was
  created in 81b5717ae7, it didn't use the
  `id` parameter for anything either.

  Bartłomiej Dach · 2022-02-01 21:35:12 +01:00
  a378e78ced
• Run EF migrations before migrating to realm

  Turns out that there are more than zero users that are upgrading from
  old databases. I think we probably want to support this for now.
  
  Tested against database in https://github.com/ppy/osu/discussions/16700
  and one other I had locally, both work correctly.

  Dean Herbert · 2022-01-29 23:13:23 +09:00
  1a14ccc7ee
• Skip scores missing beatmaps during realm migration
  Dean Herbert · 2022-01-28 01:20:32 +09:00
  942ea896f1
• Skip beatmap imports where ruleset is not present in realm

  Closes #16651.
  
  When a ruleset is not available, the `Find` call would return null. When
  a null is passed to the constructor, `BeatmapInfo` would create an "osu"
  ruleset, which tries to get stored to realm and fails on duplicate
  primary key.
  
  Probably need to add better safeties against this (or change that
  constructor...) but this will fix the migration process.
  
  Probably not serious enough to pull the build. This only affects
  rulesets like karaoke which have custom beatmaps.

  Dean Herbert · 2022-01-28 00:14:20 +09:00
  81461be49f
• Merge pull request #16640 from peppy/realm-migration-always-delete

  Improve realm migration UX to give users a recovery path on error

  Dan Balasescu · 2022-01-27 15:43:14 +09:00
  9ff2b9eb95
• Add exception message to discussion template url
  Dean Herbert · 2022-01-27 14:56:04 +09:00
  67ccb87992
• Add safety against zip creation potentially failing (probably can't but still)
  Dean Herbert · 2022-01-27 14:55:52 +09:00
  fb081384e1
• Avoid showing the external link warning
  Dean Herbert · 2022-01-27 14:53:11 +09:00
  465e7d29fe
• Automatically zip and show the backup archive to the user
  Dean Herbert · 2022-01-27 14:52:58 +09:00
  31abb372e5
• Show notification when migration fails to give users a recovery path
  Dean Herbert · 2022-01-27 14:39:11 +09:00
  b745252962
• Change migration process to always delete old EF database

  It is already backed up, so this is probably fine.

  Dean Herbert · 2022-01-27 14:33:46 +09:00
  deb5d75b5f
• Add more attempts to delete EF database

  Just noticed in passing. Probably best we do this since it was known to
  fail on windows in some rare cases.

  Dean Herbert · 2022-01-27 14:32:21 +09:00
  587c0f965c
• Block collection loading until realm migration has completed
  Dean Herbert · 2022-01-27 00:34:51 +09:00
  f21e3d0d86
• Merge branch 'master' into fix-out-of-order-events-on-block-fail
  Dan Balasescu · 2022-01-26 19:08:55 +09:00
  94d3e2c90c
• Merge pull request #16626 from peppy/fix-skin-section-realm-usage

  Refactor `SkinSection` to avoid unnecessary realm queries

  Dan Balasescu · 2022-01-26 19:01:15 +09:00
  b1a23486c5
• Remove collection ToLive helper method to avoid confusion
  Dean Herbert · 2022-01-26 18:26:37 +09:00
  45636ce04b
• Skip importing scores which have no matching realm ruleset

  There's no real way to recover these unless we want to start importing
  rulesets into realm. And that seems counter productive. This can only
  happen if users don't have the dll present any more, and it was removed
  far before realm was tracking rulesets (else it would have an
  `Available=0` entry in realm to match).

  Dean Herbert · 2022-01-26 18:04:54 +09:00
  3aa681005b
• Move final empty result set sending to post-compact
  Dean Herbert · 2022-01-26 17:21:57 +09:00
  885fb92aad
• Add flag to guard against deadlocks during blocking operations
  Dean Herbert · 2022-01-26 17:09:28 +09:00
  791ea0308f
• Revert "Move final result set firing to before the update realm is disposed"

  This reverts commit 24bcba6418.

  Dean Herbert · 2022-01-26 16:21:24 +09:00
  11f0f3c17d
• Move final result set firing to before the update realm is disposed

  Without this, if any registered callback attempts to access
  `RealmAccess.Realm` when handling the empty set callback, it will
  deadlock the game.

  Dean Herbert · 2022-01-26 15:57:06 +09:00
  24bcba6418
• Send unsubscribe actions to synchronization context for consistency and safety
  Dean Herbert · 2022-01-26 15:24:53 +09:00
  5ea781faef
• Merge branch 'master' into fix-out-of-order-events-on-block-fail
  Dean Herbert · 2022-01-26 15:21:10 +09:00
  91e0d1021f
• Remove ILive<> interface (and use abstract Live<> instead)
  Dean Herbert · 2022-01-26 13:38:56 +09:00
  cd71ec0edd
• Move statistics to static class
  Dean Herbert · 2022-01-26 13:29:12 +09:00
  d37c3c463e
• Add statistics for Live usage
  Dean Herbert · 2022-01-26 12:42:24 +09:00
  c7947b3489
• Fix RealmLive not refetching if update thread context was closed at some point
  Dean Herbert · 2022-01-26 12:32:34 +09:00
  56b06f34f0
• Avoid creating realm contexts or refetching when accessing RealmLive from the update thread
  Dean Herbert · 2022-01-26 12:32:34 +09:00
  d76822b685
• Use blocking calls to SynchronizationContext to guarantee order of execution
  Dean Herbert · 2022-01-25 20:49:52 +09:00
  4a9f4eecba
• Merge pull request #16604 from peppy/less-async-import

  Remove `Task` from the inner-most `Import` method in `RealmArchiveModelImporter`

  Dan Balasescu · 2022-01-25 16:47:07 +09:00
  d8270fe14f
• Fix notification reset events potentially arriving out of order if a block operation times out
  Dean Herbert · 2022-01-25 16:26:06 +09:00
  1bb1366c9f