h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-19 11:32:54 +08:00
Code Issues Releases Wiki Activity

Use blocking calls to SynchronizationContext to guarantee order of execution

Browse Source
This commit is contained in:
Dean Herbert 2022-01-25 20:49:52 +09:00
parent ffd7877a1e
commit 4a9f4eecba
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
osu.Game/Database/RealmAccess.cs
View File

@ -607,7 +607,7 @@ namespace osu.Game.Database
// and must be posted to the synchronization context.
// This is because realm may fire event callbacks between the `unregisterAllSubscriptions` and `updateRealm.Dispose`
// calls above.
syncContext?.Post(_ =>
syncContext?.Send(_ =>
{
foreach (var action in notificationsResetMap.Values)
action();
@ -647,8 +647,14 @@ namespace osu.Game.Database
{
Logger.Log(@"Restoring realm operations.", LoggingTarget.Database);
realmRetrievalLock.Release();
// Post back to the update thread to revive any subscriptions.
syncContext?.Post(_ => ensureUpdateRealm(), null);
// In the case we are on the update thread, let's also require this to run synchronously.
// This requirement is mostly due to test coverage, but shouldn't cause any harm.
if (ThreadSafety.IsUpdateThread)
syncContext?.Send(_ => ensureUpdateRealm(), null);
else
syncContext?.Post(_ => ensureUpdateRealm(), null);
}
}