35980 Commits

This Branch

This Branch

All Branches

• Add online beatmap "explicit content" property
  Salman Ahmed · 2021-01-13 12:13:14 +03:00
  e8daea91d2
• Merge pull request #11467 from bdach/fix-multiplayer-non-host-crash

  Fix non-hosts crashing on load requested

  Dean Herbert · 2021-01-13 11:38:59 +09:00
  10fd4cf7c9
• Fix non-hosts crashing on load requested

  `onLoadRequested()` always released the `readyClickOperation` ongoing
  operation, without checking whether it actually needs to/should (it
  should only do so if the action initiating the operation was starting
  the game by the host). This would crash all other consumers, who already
  released the operation when their ready-up operation completed server
  side.
  
  To resolve, relax the constraint such that the operation can be ended
  multiple times in any order. At the end of the day the thing that
  matters is that the operation is done and the ready button is unblocked.

  Bartłomiej Dach · 2021-01-13 00:58:53 +01:00
  2d3cacca11
• Merge pull request #11465 from smoogipoo/fix-taiko-conversion-2
  Bartłomiej Dach · 2021-01-12 20:43:37 +01:00
  becd52b5d2
• Fix BPM multiplier not working in all cases
  smoogipoo · 2021-01-12 17:50:22 +09:00
  9a22df2b88
• Add failing test
  smoogipoo · 2021-01-12 17:49:21 +09:00
  22a0f99f35
• Merge pull request #11118 from MiraiSubject/tourney-switching-ui

  Add the ability to switch tournaments to the SetupScreen

  Dean Herbert · 2021-01-11 16:36:45 +09:00
  dd809df076
• Add missing licence headers
  Dean Herbert · 2021-01-11 15:47:27 +09:00
  f65042cf44
• Change field to local variable
  Dean Herbert · 2021-01-11 14:45:01 +09:00
  c9466426b7
• Move setup screen classes out of single file and into their own namespace
  Dean Herbert · 2021-01-11 14:44:07 +09:00
  7a7c583ded
• Use disabled state instead of hiding button
  Dean Herbert · 2021-01-11 14:38:51 +09:00
  bd627534b7
• Clean up code
  Dean Herbert · 2021-01-11 14:38:42 +09:00
  ba3a7a0501
• Cache TournamentStorage explicitly for better safety
  Dean Herbert · 2021-01-11 14:38:42 +09:00
  49057e8cbc
• Merge pull request #11447 from bdach/fix-play-button-crashes

  Fix track previews crashing on completion

  Dean Herbert · 2021-01-11 03:10:18 +09:00
  2abeda5e0f
• Remove unused constant
  Dean Herbert · 2021-01-11 01:56:09 +09:00
  d2ca6da0fd
• Expose as IBindable for added safety
  Dean Herbert · 2021-01-11 01:55:54 +09:00
  bd37723788
• Merge branch 'master' into fix-play-button-crashes
  Dean Herbert · 2021-01-11 01:46:41 +09:00
  e4eb44df6e
• Move assignments to the TournamentSwitcher component

  This also adds conditional checks for displaying the "Close osu!" button

  Shivam · 2021-01-10 17:34:20 +01:00
  f466791b69
• Merge branch 'master' into tourney-switching-ui
  Shivam · 2021-01-10 17:34:03 +01:00
  959696c296
• Merge branch 'master' into tourney-switching-ui
  Shivam · 2021-01-10 17:33:52 +01:00
  e5c670f843
• Merge pull request #11386 from frenzibyte/fix-mod-buttons-not-copying-settings
  Bartłomiej Dach · 2021-01-10 16:37:25 +01:00
  b79e8d0192
• Merge branch 'master' into fix-mod-buttons-not-copying-settings
  Bartłomiej Dach · 2021-01-10 15:42:33 +01:00
  d110ed9e95
• Merge pull request #11452 from bdach/ongoing-operation-tracker-safety
  Bartłomiej Dach · 2021-01-10 15:41:13 +01:00
  e006891db0
• Rename param to match method body
  Bartłomiej Dach · 2021-01-10 15:35:53 +01:00
  4b4adc927c
• Merge branch 'master' into ongoing-operation-tracker-safety
  Dean Herbert · 2021-01-10 23:05:03 +09:00
  4e32b0d6de
• Merge branch 'master' into fix-mod-buttons-not-copying-settings
  Dean Herbert · 2021-01-10 23:01:54 +09:00
  95ad324a39
• Merge pull request #11392 from ppy/dependabot/nuget/Microsoft.CodeAnalysis.FxCopAnalyzers-3.3.2

  Bump Microsoft.CodeAnalysis.FxCopAnalyzers from 3.3.1 to 3.3.2

  Dean Herbert · 2021-01-10 16:18:02 +09:00
  556dc11da7
• Merge pull request #11448 from bdach/fix-editor-enter-crash

  Fix editor crashing on enter if login overlay was previously opened

  Dean Herbert · 2021-01-10 12:59:47 +09:00
  e81f9e358e
• Improve safety of ongoing operation tracker

  Finishing an operation started via
  `OngoingOperationTracker.BeginOperation()` was risky in cases where the
  operation ended at a callback on another thread (which, in the case of
  multiplayer, is *most* cases). In particular, if any consumer registered
  a callback that mutates transforms when the operation ends, it would
  result in crashes after the framework-side safety checks.
  
  Rework `OngoingOperationTracker` into an always-present component
  residing in the drawable hierarchy, and ensure that the
  `operationInProgress` bindable is always updated on the update thread.
  This way consumers don't have to add local schedules in multiple places.

  Bartłomiej Dach · 2021-01-09 22:45:24 +01:00
  8c3955d341
• Merge pull request #11353 from bdach/disable-repeat-multi-actions

  Disable multiplayer action buttons after clicks to prevent double operations

  Dean Herbert · 2021-01-09 17:42:38 +09:00
  c8d83a9fb3
• Merge branch 'master' into disable-repeat-multi-actions
  Dean Herbert · 2021-01-09 10:15:20 +09:00
  b69fe8a274
• Merge branch 'master' into dependabot/nuget/Microsoft.CodeAnalysis.FxCopAnalyzers-3.3.2
  Bartłomiej Dach · 2021-01-08 22:36:03 +01:00
  c1ef05af82
• Target logic at this and adjust variables
  Salman Ahmed · 2021-01-09 00:31:18 +03:00
  0aad0c7c6c
• Move out test ongoing operation tracker to higher level
  Bartłomiej Dach · 2021-01-08 22:28:21 +01:00
  ff60d652ed
• Merge remote-tracking branch 'upstream/master' into fix-mod-buttons-not-copying-settings
  Salman Ahmed · 2021-01-09 00:26:18 +03:00
  375ecf92ed
• Rename {joiningRoom -> operationInProgress}
  Bartłomiej Dach · 2021-01-08 22:23:38 +01:00
  c2eeb822b8
• Remove unnecessary permissiveness wrt null
  Bartłomiej Dach · 2021-01-08 22:21:54 +01:00
  dad5dd3667
• Move screen activity update to LoadComplete()

  Fixes a potential crash when moving from main menu to editor after
  having previously opened the login settings overlay. Setting the
  activity in BDL as done before is unsafe, as that set can trigger value
  change callbacks, which in turn can trigger adding transforms, which
  should always be done on the update thread.
  
  Semantically it also makes sense, as the user activity should change
  once the screen they're moving to has actually loaded and displayed to
  the user.

  Bartłomiej Dach · 2021-01-08 21:18:15 +01:00
  284d30d336
• Remove Dispose() override

  Culls another non-thread-safe mutation of the `Playing` bindable.
  It seems to be a weird vestige from an earlier revision of the old
  "direct" panel, which relied on `DisposeOnDeathRemoval` to finish track
  playback (and then was removed in
  6c150c9ed7). The play button is no longer
  responsible for managing preview track lifetime anyway;
  `PreviewTrackManager`'s method are intended for that.

  Bartłomiej Dach · 2021-01-08 20:08:19 +01:00
  274a045d8d
• Schedule play button state update

  Revealed by the framework-side transform thread safety checks. `Stopped`
  is even annotated as not being thread-safe (but was annotated as such
  long after the class's nascence).

  Bartłomiej Dach · 2021-01-08 20:08:19 +01:00
  52789118a3
• Merge pull request #11439 from peppy/improve-hover-sounds-debounce

  Improve hover sounds playback (to reduce volume saturation and delay)

  Dean Herbert · 2021-01-09 02:31:02 +09:00
  2021.109.0 8a7a1fc40a
• Remove mention of default value in xmldoc

  Just bound to get outdated with every change anyway. Look at the actual
  default value declaration to see what the default is.

  Bartłomiej Dach · 2021-01-08 18:26:41 +01:00
  49c6abcb5c
• Merge pull request #11424 from peppy/fix-transform-mutation-mod-selection
  Bartłomiej Dach · 2021-01-08 18:21:56 +01:00
  9422219eaa
• Start with null last hover playback time
  Bartłomiej Dach · 2021-01-08 18:16:03 +01:00
  d507a08951
• Merge branch 'master' into fix-transform-mutation-mod-selection
  Dean Herbert · 2021-01-09 01:44:52 +09:00
  3bb71e4b77
• Merge pull request #11444 from peppy/fix-tournament-serialization-changes

  Add custom handling of Point serialization to fix startup crashes of tournament client

  Dean Herbert · 2021-01-09 01:32:38 +09:00
  ef5ea82d8c
• Update framework
  Dean Herbert · 2021-01-09 01:24:18 +09:00
  8feaf3fb6a
• Merge pull request #11438 from bdach/difficulty-adjust-defaults

  Fix difficulty adjust mod treating default values as user overrides

  Dean Herbert · 2021-01-09 01:18:34 +09:00
  05ba5d4c31
• Fix selection change event being invoked with wrong mod
  Bartłomiej Dach · 2021-01-08 17:02:57 +01:00
  0cf5be3ef4
• Use PointConverter
  Dean Herbert · 2021-01-09 00:56:54 +09:00
  82725b59c0