5484 Commits

• Fix taiko swell ending samples playing at results sometimes

  Closes https://github.com/ppy/osu/issues/32052.
  
  Sooooo... this is going to be a rant...
  
  To understand why this is going to require a rant, dear reader, please
  do the following:
  
  1. Read the issue thread and follow the reproduction scenario (download
     map linked, fire up autoplay, seek near end, wait for results, hear
     the sample spam).
  2. Now exit out to song select, *hide the toolbar*, and attempt
     reproducing the issue again.
  3. Depending on ambient mood, laugh or cry.
  
  Now, *why on earth* would the *TOOLBAR* have any bearing on anything?
  
  Well, the chain of failure is something like this:
  
  - The toolbar hides for the duration of gameplay, naturally.
  - When progressing to results, the toolbar gets automatically unhidden.
  - This triggers invalidations on `ScrollingHitObjectContainer`. I'm not
    precisely sure which property it is that triggers the invalidations,
    but one clearly does. It may be position or size or whichever.
  - When the invalidation is triggered on `layoutCache`, the next
    `Update()` call is going to recompute lifetimes for ALL hitobject
    entries.
  - In case of swells, it happens that the calculated lifetime end of the
    swell is larger than what it actually ended up being determined as at
    the instant of judging the swell, and thus, the swell is *resurrected*,
    reassigned a DHO, and the DHO calls `UpdateState()` and plays the
    sample again despite the `samplePlayed` flag in `LegacySwell`, because
    all of that is ephemeral state that does not survive a hitobject
    getting resurrected.
  
  Now I *could* just fix this locally to the swell, maybe, by having some
  time lenience check, but the fact that hitobjects can be resurrected by
  the *toolbar* appearing, of all possible causes in the world, feels
  just completely wrong. So I'm adding a local check in SHOC to not
  overwrite lifetime ends of judged object entries.
  
  The reason why I'm making that check specific to end time is that I can
  see valid reasons why you would want to recompute lifetime *start* even
  on a judged object (such as playfield geometry changing in a significant
  way). I can't think of a valid reason to do that to lifetime *end*.

  Bartłomiej Dach · 2025-02-24 14:30:55 +01:00
  41db3c1501
• Fix "use current distance snap" button incorrectly factoring in last object with velocity

  Closes https://github.com/ppy/osu/issues/32003.

  Bartłomiej Dach · 2025-02-21 12:52:59 +01:00
  de78518fea
• Fix incorrect snapping behaviour when previous object is not snapped to beat
  Bartłomiej Dach · 2025-02-04 11:45:15 +01:00
  731f100aaf
• Fix code quality
  Bartłomiej Dach · 2025-02-03 15:18:03 +01:00
  2d6f64e891
• Remove unused method

  Only used in test code.

  Bartłomiej Dach · 2025-02-03 14:01:51 +01:00
  df37768ff4
• Refactor IDistanceSnapProvider to accept slider velocity objects as a reference

  Method signatures are also changed to be a lot more explicit as to what
  inputs they expect.

  Bartłomiej Dach · 2025-02-03 14:00:57 +01:00
  a1185df2eb
• Merge pull request #31368 from frenzibyte/mobile-fix-mania

  Improve osu!mania playability on mobile devices

  Dean Herbert · 2025-02-01 14:49:46 +09:00
  cf3a379b1c
• Merge pull request #31655 from bdach/deabstractify-editor-snap

  Refactor editor object snapping to remove bad abstractions

  Dan Balasescu · 2025-01-30 01:38:42 +09:00
  48b1c7398e
• Fix incremental unstable rate calculation not matching expectations

  The `EventCount` variable wasn't factoring in that some results do not
  affect unstable rate. It would therefore become more incorrect as the
  play continued.
  
  Closes https://github.com/ppy/osu/issues/31712.

  Dean Herbert · 2025-01-29 17:11:12 +09:00
  d8ec3b77e4
• Avoid extra unnecessary DI

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Salman Alshamrani · 2025-01-25 19:12:42 -05:00
  ffc37cece0
• Refactor further to avoid weird non-virtual common method
  Bartłomiej Dach · 2025-01-24 13:14:31 +01:00
  daec91f61d
• Fix tests
  Bartłomiej Dach · 2025-01-24 11:59:07 +01:00
  269ade178e
• Remove IPositionSnapProvider
  Bartłomiej Dach · 2025-01-24 11:59:07 +01:00
  32d341a468
• Remove dependence of placement blueprints on IPositionSnapProvider
  Bartłomiej Dach · 2025-01-24 11:59:07 +01:00
  a6987f5c95
• Remove dependence of blueprint containers on IPositionSnapProvider
  Bartłomiej Dach · 2025-01-24 11:59:05 +01:00
  15b6e28ebe
• Expose GameplayStartTime in IGameplayClock
  Dean Herbert · 2025-01-24 15:29:49 +09:00
  5cc8181bad
• Merge branch 'master' into mobile-fix-mania
  Dean Herbert · 2025-01-16 18:08:46 +09:00
  42e5cb58b7
• Typo fix
  Shawn Presser · 2025-01-15 19:29:41 -06:00
  6008c3138e
• Merge pull request #31446 from EVAST9919/new-combo-editor

  Fix performance degradation while trying to place object with a new combo in the editor.

  Dean Herbert · 2025-01-15 12:56:06 +09:00
  ef7982fbfa
• Fix failing tests

  - Caches `DrawableRuleset` in editor compose screen for mania playfield adjustment container (because it's used to wrap the blueprint container as well)
  - Fixes `ManiaModWithPlayfieldCover` performing a no-longer-correct direct cast with a naive-but-working approach.

  Salman Alshamrani · 2025-01-12 22:56:40 -05:00
  c1ac27d658
• Merge branch 'master' into mobile-fix-mania
  Salman Alshamrani · 2025-01-12 02:00:49 -05:00
  f121b03a78
• Merge branch 'master' into new-combo-editor
  Bartłomiej Dach · 2025-01-10 14:13:14 +01:00
  933f5db208
• Add combo colour override control to editor

  Closes https://github.com/ppy/osu/issues/25608.
  
  Logic mostly matching stable. All operations are done on `ComboOffset`
  which still makes overridden combo colours weirdly relatively dependent
  on each other rather than them be an "absolute" choice, but alas...
  
  As per stable, two consecutive new combos can use the same colour only
  if they are separated by a break:
  
      https://github.com/peppy/osu-stable-reference/blob/52f3f75ed7efd7b9eb56e1e45c95bb91504337be/osu!/GameModes/Edit/Modes/EditorModeCompose.cs#L4564-L4571
  
  This control is only available once the user has changed the combo
  colours from defaults; additionally, only a single new combo object
  must be selected for the colour selector to show up.

  Bartłomiej Dach · 2025-01-10 13:40:56 +01:00
  48196949e0
• Merge pull request #31462 from bdach/ternary-button-is-bad

  Simplify editor "ternary button" structure

  Dan Balasescu · 2025-01-10 14:24:41 +09:00
  38d95abc24
• Simplify editor "ternary button" structure

  As I look into re-implementing the ability to choose combo colour for an
  object (also known as "colourhax") from the editor UI, I stumble upon
  these wretched ternary items again and sigh a deep sigh of annoyance.
  
  The structure is overly rigid. `TernaryItem` does nothing that
  `DrawableTernaryItem` couldn't, except make it more annoying to add
  specific sub-variants of `DrawableTernaryItem` that could do more
  things.
  
  Yes you could sprinkle more levels of virtuals to
  `CreateDrawableButton()` or something, but after all, as Saint Exupéry
  says, "perfection is finally attained not when there is no longer
  anything to add, but when there is no longer anything to take away."
  So I'm leaning for taking one step towards perfection.

  Bartłomiej Dach · 2025-01-09 13:41:22 +01:00
  5c8ae6f851
• Fix rate adjustments changing the spacing between replay frames
  Dean Herbert · 2025-01-09 13:30:04 +09:00
  c8f72fdbe9
• Fix combo properties multiple reassignments
  Andrei Zavatski · 2025-01-07 14:00:31 +03:00
  8f4eafea4e
• Merge pull request #31306 from bdach/aspire-slider-breakage

  Fix slider event generator incorrectly not generating repeats when tick distance is zero

  Dan Balasescu · 2025-01-07 11:50:18 +09:00
  77d9c955ea
• Reduce HitSampleInfo constants allocations
  Andrei Zavatski · 2025-01-07 00:36:58 +03:00
  e8dc09f5bc
• Always block scroll input above editor toolbox areas

  Originally this was an intentional choice (see
  https://github.com/ppy/osu/pull/18088) when these controls were more
  transparent and didn't for a solid toolbox area.
  
  But this is no longer the case, so for now let's always block scroll to
  match user expectations.
  
  Closes #31262.

  Dean Herbert · 2025-01-02 14:31:27 +09:00
  cca63b599e
• Allow locking orientation on iOS in certain circumstances
  Salman Alshamrani · 2024-12-29 22:15:21 -05:00
  7563a18c7f
• Fix slider event generator incorrectly not generating repeats when tick distance is zero

  RFC. This closes https://github.com/ppy/osu/issues/31186.
  
  To explain why: The issue occurs on
  https://osu.ppy.sh/beatmapsets/594828#osu/1258033, specifically on the
  slider at time 128604. The failure site is
  
  	https://github.com/ppy/osu/blob/fa0d2f4af22fb9319e2a8773bf635368d86360be/osu.Game.Rulesets.Osu/Edit/Blueprints/Sliders/SliderCircleOverlay.cs#L65-L66
  
  wherein `LastRepeat` is `null`, even though the slider's `RepeatCount`
  is 1 and thus `SpanCount` is 2.
  
  In this case, `SliderEventGenerator` is given a non-zero `tickDistance`
  but a zero `length`. The former is clamped to the latter:
  
  	https://github.com/ppy/osu/blob/fa0d2f4af22fb9319e2a8773bf635368d86360be/osu.Game/Rulesets/Objects/SliderEventGenerator.cs#L34
  
  Because of this, a whole block of code pertaining to tick generation
  gets turned off, because of zero tick spacing - however, that block also
  includes within it *repeat* generation, for seemingly very little reason
  whatsoever:
  
  	https://github.com/ppy/osu/blob/fa0d2f4af22fb9319e2a8773bf635368d86360be/osu.Game/Rulesets/Objects/SliderEventGenerator.cs#L47-L77
  
  While a zero tick distance would indeed cause `generateTicks()` to loop
  forever, it should have absolutely no effect on repeats.
  
  While this *is* ultimately an aspire-tier bug caused by people pushing
  things to limits, I do believe that in this case a fix is warranted
  because of how hard the current behaviour violates invariants. I do not
  like the possibility of having a slider with multiple spans and no
  repeats.

  Bartłomiej Dach · 2024-12-27 12:38:31 +01:00
  e7225399a2
• Add setters to hitobject coordinate interfaces
  Bartłomiej Dach · 2024-12-27 11:01:47 +01:00
  0d16ed028b
• Merge branch 'master' into skinnable-mod-display
  Dean Herbert · 2024-12-20 14:08:51 +09:00
  55dff1f0ef
• Merge pull request #30984 from smoogipoo/fix-mania-spinner-conversion

  Fix "spinner" conversion for mania-specific beatmaps

  Bartłomiej Dach · 2024-12-19 15:30:10 +01:00
  1057aa867f
• Merge branch 'master' into bookmarks
  Bartłomiej Dach · 2024-12-07 22:22:04 +09:00
  459533aba6
• Implement skinnable mod display

  Also makes the mod display initialization sequence (start expanded, then
  unexpand) controlled by HUDOverlay rather than mod display itself. This
  enabled different treatment depending on whether the mod display is
  viewed in the skin editor or in the player.
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Thomas Müller · 2024-12-07 12:06:33 +09:00
  0a00f7a7c2
• Populate default LegacyType value on convert hitobjects

  Normally not an issue, but some tests create their own hitobjects
  deriving from `ConvertHitObject`.

  Dan Balasescu · 2024-12-06 17:47:14 +09:00
  8dda5aada8
• Merge branch 'master' into netcore-analyzer
  Huo Yaoyuan · 2024-12-05 17:18:56 +08:00
  d92ea910cf
• Move bookmarks out of BeatmapInfo

  Not sure why I didn't do that in https://github.com/ppy/osu/pull/28473...

  Bartłomiej Dach · 2024-12-03 14:17:14 +01:00
  808934581f
• Update for suggestions
  Huo Yaoyuan · 2024-12-03 00:03:59 +08:00
  7ece8ec1dc
• Merge pull request #28473 from bdach/beatmap-info-purge

  Move unnecessary properties from `BeatmapInfo` / realm to `IBeatmap`

  Dean Herbert · 2024-12-02 16:19:12 +09:00
  5b2558cec2
• Stop loudly logging backwards seek bug to sentry

  Several users have reported stutters when this happens. It's potentially
  from the error report overhead. We now know that this is a BASS level
  issue anyway, so having this logging is not helpful.

  Dean Herbert · 2024-11-30 21:01:22 +09:00
  1e2e364cd3
• Merge branch 'master'
  Huo Yaoyuan · 2024-11-30 01:07:08 +08:00
  fa3c95c296
• Centralise supported file extensions to one helper class

  As proposed in
  https://github.com/ppy/osu-server-beatmap-submission/pull/5#discussion_r1861680837.

  Bartłomiej Dach · 2024-11-29 08:42:45 +01:00
  110e4fbb30
• Apply minor performance rules
  Huo Yaoyuan · 2024-11-28 20:41:44 +08:00
  f5a7716509
• Add basic xmldoc to results class
  Dean Herbert · 2024-11-26 12:16:26 +09:00
  d6cf1db0f5
• Rename NextProcessableIndex to EventCount in line with actual functionality
  Dean Herbert · 2024-11-26 12:10:34 +09:00
  d903d381d5
• Only update unstable rate counter when an applicable hitobject is reached
  Dean Herbert · 2024-11-25 21:13:18 +09:00
  bbe8f2ec44
• Use class instead of record for lower allocations
  Dean Herbert · 2024-11-25 21:13:18 +09:00
  ea68d4b33a