1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-17 17:33:03 +08:00
Commit Graph

68331 Commits

Author SHA1 Message Date
Dean Herbert
e77489f2a9
Allow notification of new strings 2024-07-31 03:10:36 +09:00
Dean Herbert
bdc465e1c6
Reword notification text slightly 2024-07-31 03:06:35 +09:00
Dean Herbert
5ebb5ad670
Fix test failure due to TestMetadataClient providing null statistics array 2024-07-31 02:53:10 +09:00
Dean Herbert
d75c170ba1
Merge branch 'master' into daily-challenge/better-messaging 2024-07-30 19:04:48 +09:00
Dean Herbert
d5f9173288
Remove unused local variable 2024-07-30 19:04:43 +09:00
Dean Herbert
71acb7e9fc
Merge pull request #29137 from normalid-awa/feature/visual/chatline-background-altering
Alternate background colour of chat lines to better visually distinguish wrapped lines
2024-07-30 17:51:41 +09:00
Dean Herbert
c80f338893
Merge pull request #29198 from bdach/fix-difficulty-bindable
Fix incorrect `DifficultyBindable` logic
2024-07-30 17:50:58 +09:00
Bartłomiej Dach
1b57a2a136
Show new daily challenge notification globally 2024-07-30 10:36:26 +02:00
Dean Herbert
d48849040b
Merge pull request #29182 from bdach/revert-present-score
Force exit to main menu when presenting scores from within playlists / multiplayer
2024-07-30 17:24:27 +09:00
Bartłomiej Dach
a05f810724
Attempt to fix tests more 2024-07-30 10:07:38 +02:00
Dean Herbert
fc78dc9f38
Adjust paddings to avoid scrollbar overlap 2024-07-30 16:45:36 +09:00
Dean Herbert
bf10a91082
Adjust colouring to work better across multiple usages 2024-07-30 16:45:35 +09:00
Bartłomiej Dach
6813f5ee0a
Fix incorrect DifficultyBindable logic 2024-07-30 08:39:20 +02:00
Bartłomiej Dach
ae38e66036
Add failing test coverage 2024-07-30 08:39:01 +02:00
Joseph Madamba
9299f74c6c
Merge pull request #29193 from frenzibyte/split-position-inspector-lines
Enforce new line between X/Y coordinate in editor position inspector
2024-07-29 18:29:30 -07:00
Salman Ahmed
621f4dfece Enforce new line between X/Y coordinate in editor position inspector 2024-07-30 02:45:21 +03:00
Dean Herbert
aa2515763c
Merge pull request #29184 from bdach/daily-challenge/wrong-mods-after-replay
Fix mods persisting after watching replay from daily challenge screen
2024-07-29 23:23:45 +09:00
Bartłomiej Dach
48e38bd467
Merge pull request #29186 from peppy/fix-status-config
Fix online status not persisting correctly
2024-07-29 16:11:05 +02:00
Bartłomiej Dach
5032a149e7
Merge pull request #29187 from peppy/daily-challenge-pieces-not-always-present
Favour updating daily challenge statistics when they come on screen
2024-07-29 15:48:26 +02:00
Bartłomiej Dach
3a30ff7817
Merge pull request #29172 from kadambishreyas/handle-timestamp-mod-content
Handle timestamp mod content
2024-07-29 15:34:50 +02:00
Bartłomiej Dach
b77a10b6db
Fix tests maybe 2024-07-29 15:28:52 +02:00
Dean Herbert
1daeb7ebd0
Rename typo in test naming 2024-07-29 22:19:38 +09:00
Bartłomiej Dach
12e553a290
Merge pull request #29166 from normalid-awa/bugfix/visual/mod-preset-tooltips-text-being-cutoff
Fix mod preset tooltip's description text being cut off
2024-07-29 15:19:06 +02:00
Bartłomiej Dach
b46f3c97da
Add notification on daily challenge conclusion & start of new one
Because I wish to stop seeing "DAILY CHALLENGE WHERE" every day
on #general.

The notifications are constrained to the daily challenge screen only to
not spam users who may not care.
2024-07-29 14:30:10 +02:00
Dean Herbert
a6b442814d
Merge pull request #29185 from bdach/online-metadata-logging
Add logging when starting and stopping watch operations in online metadata client
2024-07-29 21:05:46 +09:00
Dean Herbert
7afcd72872
Fix potentially too many scores displaying in breakdown while in gameplay 2024-07-29 20:58:42 +09:00
Dean Herbert
05056f0e8a
Remove no longer required AlwaysPresent definition
This also reverts commit 7fedfd368c as
no-longer-necessary.
2024-07-29 20:43:56 +09:00
Dean Herbert
5a1002c1a0
Ensure score breakdown doesn't spam scores when not visible 2024-07-29 20:43:50 +09:00
Dean Herbert
76cd2df699
Add ability to test daily challenge carousel items when hidden 2024-07-29 20:43:47 +09:00
Dean Herbert
5bc02cc1c6
Fix background alternating not updating on message removal 2024-07-29 20:25:55 +09:00
Dean Herbert
997b3eb498
Fix typos and visuals 2024-07-29 20:24:51 +09:00
Bartłomiej Dach
8b96b0b9e4
Add logging when starting and stopping watch operations in online metadata client
For future use with debugging issues like
https://github.com/ppy/osu/issues/29138, hopefully.
2024-07-29 13:19:01 +02:00
jkh675
d51a53b051 Preventing the mod icon being squashed up 2024-07-29 19:08:14 +08:00
Dean Herbert
11265538c4
Reset online status on logout 2024-07-29 20:06:30 +09:00
Dean Herbert
c142adf926
Fix online status not persisting correctly
Regressed at some point.

I don't see much reason not to link the bindable directly with config.
It seems to work as you'd expect. Tested with logout (resets to
"Online") and connection failure (persists).

Closes https://github.com/ppy/osu/issues/29173.
2024-07-29 20:06:27 +09:00
Bartłomiej Dach
f1a84a5111
Fix mods persisting after watching replay from daily challenge screen
Closes https://github.com/ppy/osu/issues/29133.

Hope I can be forgiven for no tests. I had a brief try but writing them
is going to take hours.
2024-07-29 12:52:30 +02:00
jkh675
8f86681110 Replace OsuSpriteText with TextFlowContainer 2024-07-29 18:29:44 +08:00
jkh675
90fdf5599f Revert changes 2024-07-29 18:14:07 +08:00
Bartłomiej Dach
cebd38c6eb
Merge pull request #29163 from Joehuu/copy-lb-mods-daily
Add ability to copy leaderboard mods in daily challenge
2024-07-29 12:09:27 +02:00
Bartłomiej Dach
9b96bd1d73
Force exit to main menu when presenting scores from within playlists / multiplayer
- Closes https://github.com/ppy/osu/issues/29152
- Partially reverts https://github.com/ppy/osu/pull/29097
- Reopens https://github.com/ppy/osu/issues/26666

When testing I failed to predict that in multiplayer there can be a
different beatmap in the playlist queue. If this is the case,
`PresentScore()` will exit out to `Multiplayer`, whose `RoomSubScreen`
will update the selected item - and thus, the global beatmap - to the
next item in queue, at which point trying to play games with "not
touching the global beatmap bindable if we don't need to" fail to work,
because the bindable *must* be touched for correct operation, yet it
cannot (because `OnlinePlayScreen`s disable it).

I'm not sure what the fix is here:

- making replay player somehow independent of the global beatmap?
- not exiting out to multiplayer, but instead doing the present from the
  results screen itself? if so, then how to ensure the screen stack
  can't overflow to infinity?

so I'm just reverting the broken part. The daily challenge part is left
in because as is it should not cause issues.
2024-07-29 12:07:45 +02:00
jkh675
5ec46a79b4 Only create a new drawable object when the background is needed 2024-07-29 17:50:23 +08:00
Bartłomiej Dach
2ff0a89b4f
Convert into auto-property even more 2024-07-29 10:59:21 +02:00
Bartłomiej Dach
861b546562
Add vague test coverage 2024-07-29 10:58:05 +02:00
Bartłomiej Dach
54c904d439
Convert into auto-property 2024-07-29 10:40:29 +02:00
Bartłomiej Dach
aa7f6f81ef
Merge pull request #29127 from Joehuu/add-negative-horizontal-padding-daily
Fix daily challenge background clipping when settings/notifications is opened
2024-07-29 10:28:48 +02:00
Bartłomiej Dach
efd1919bfe
Merge pull request #29159 from frenzibyte/fix-daily-challenge-hover
Fix score breakdown tooltips appearing in other feeds
2024-07-29 10:14:32 +02:00
jkh675
63757a77a5 Extract update background method 2024-07-29 13:39:08 +08:00
Shreyas Kadambi
ae61df0abe Add back accidentally removed test 2024-07-28 11:47:00 -04:00
Shreyas Kadambi
dec6b190f2 Add optional 'suffix' to timestamp 2024-07-28 11:31:36 -04:00
Shreyas Kadambi
1c9c3c92fd Add tests for expected timestamp format 2024-07-28 11:30:42 -04:00