h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-17 07:22:55 +08:00
Code Issues Releases Wiki Activity
38,189 Commits 3 Branches 661 Tags 357 MiB
e543db9bee
Commit Graph

38189 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Dan Balasescu
3ec3624ac5
Merge branch 'master' into fix-editor-spinner-looping-too-long 2021-03-23 16:45:41 +09:00
Dan Balasescu
f6ed3c1b1e
Merge branch 'master' into perfect-curve-failure-testcase 2021-03-23 16:44:58 +09:00
Dan Balasescu
17a28f4f65
Merge pull request #12136 from peppy/remove-skin-sample-workarounds 
Remove local workarounds to attempt to avoid crashes on skin change
 2021-03-23 16:44:29 +09:00
Dean Herbert
08fcdc8ee4 Update difficulty calculator tests with floating point differences 2021-03-23 15:38:01 +09:00
Dan Balasescu
d758343a45
Merge pull request #12149 from peppy/fix-score-token-data-type 
Fix APIScoreToken's data type not matching server side
 2021-03-23 14:54:02 +09:00
Dean Herbert
1171214541 Update framework 2021-03-23 14:51:22 +09:00
Dean Herbert
a5842a5485 Merge branch 'master' into remove-skin-sample-workarounds 2021-03-23 14:51:14 +09:00
Dan Balasescu
5f2c6b8d59
Merge pull request #12145 from bdach/mania-auto-hold-note-release 
Remove release delay for hold notes when generating autoplay
 2021-03-23 14:24:56 +09:00
Owen Young
254b0f5dc3 removed line (?) - tried doing testing to see if it launched in fullscreen (i.e., overriding the method ppy mentioned), but to no avail :( 2021-03-23 00:24:33 -05:00
Dean Herbert
9c690f9545 Fix second usage 2021-03-23 14:08:00 +09:00
Dean Herbert
58c60100b4 Fix APIScoreToken's data type not matching server side 2021-03-23 14:04:47 +09:00
Owen Young
d9e2c44a34 implemented GetFrameworkConfigDefaults for overriding framework default, removed previous code that added a new OsuSetting and modified settings layout. 2021-03-22 23:36:55 -05:00
Owen Young
9f788f5854 removed code from OsuGameBase for fullscreen.....OsuSetting still exists but cannot figure out a way to set it to a default and have it actually work 2021-03-22 22:52:16 -05:00
Dean Herbert
c89199b38b
Merge pull request #12148 from Joehuu/fix-deleted-comments-trash-icon 
Fix incorrect trash icon being used on deleted comments counter
 2021-03-23 11:53:14 +09:00
Joehu
16b3f22caf Fix incorrect trash icon being used on deleted comments counter 2021-03-22 19:32:17 -07:00
Dean Herbert
098005393e Remove unnecessary null checks and debug code 2021-03-23 10:38:37 +09:00
Dean Herbert
d612964ac8
Merge pull request #12144 from bdach/remove-osutk-run-config 
Remove osuTK desktop rider run config
 2021-03-23 10:19:47 +09:00
Owen Young
bdcb9451f7 added code to OsuGameBase to default to fullscreen, but that might not be a good place to put it. 2021-03-22 20:17:05 -05:00
Owen Young
8ea7271d5c moved windowmode code to LoadComplete (?) 2021-03-22 19:48:52 -05:00
Bartłomiej Dach
29d4162e4e Remove release delay for hold notes when generating autoplay 
It was more intended for normal notes anyway (as they would be released
pretty much instantaneously, if it weren't for the delay).
 2021-03-22 22:45:21 +01:00
Bartłomiej Dach
d85929d721 Adjust autoplay generation tests to match expected behaviour 2021-03-22 22:45:21 +01:00
Bartłomiej Dach
a65e491768 Remove osuTK desktop rider run config 
No longer operational since 6eadae8.
 2021-03-22 20:00:36 +01:00
Naxess
e922e67c98 Fix inverted return statement 
Forgot to run tests, all passing now.
 2021-03-22 19:48:21 +01:00
Naxess
3fa5852e00 Add method documentation 2021-03-22 19:42:27 +01:00
Naxess
b11fd7972a Separate condition logic from math logic 2021-03-22 19:41:48 +01:00
Naxess
92f713a30e Improve fallback conditions 
It's possible to create a `PerfectCurve` type path with more than 3 points currently, so this accounts for that.
 2021-03-22 19:10:56 +01:00
Naxess
80e7c3aba7 Invert if statement 2021-03-22 19:09:28 +01:00
Bartłomiej Dach
779d2ed5d9
Merge pull request #12138 from smoogipoo/mania-legacy-key-fade-delay 2021-03-22 19:09:00 +01:00
Naxess
6911a1b415 Fix missing newline 2021-03-22 19:03:55 +01:00
Naxess
a7076c329c Fix null checks 2021-03-22 17:32:55 +01:00
Naxess
323b875cea Fix newlines/spaces 2021-03-22 17:32:40 +01:00
Naxess
15af57de95 Add path type recovery test 2021-03-22 15:59:59 +01:00
Naxess
3bddc4a75d Add path type test 2021-03-22 15:59:45 +01:00
Naxess
067178e537 Maintain path type when dragging/placing 2021-03-22 15:59:06 +01:00
Naxess
c82218627f Add path type update logic 
Only attempts to change points to bezier if points in the slider are modified.
 2021-03-22 15:57:57 +01:00
Naxess
7a2cb526e4 Add PointsInSegment method 2021-03-22 15:55:30 +01:00
Naxess
bee2f55d00 Undo subpath limiting 2021-03-22 15:54:33 +01:00
smoogipoo
e60ff45b73 Add another test for colinear perfect curves 2021-03-22 16:57:40 +09:00
Dean Herbert
5b1d9f4cf0 Fix constant case 2021-03-22 16:19:29 +09:00
Dean Herbert
690fb9224a Combine constants for readability 2021-03-22 16:18:31 +09:00
Dean Herbert
c4d08463ad Fix spinners playing looping sound too long in the editor 
The `OnComplete` event was never being run due to the transform playing
out longer than the spinner's lifetime. I've matched the durations, but
also moved the `Stop()` call to what I deem a safer place to run it (I
did notice that without this it would still potentially never fire).

Note that this is more noticeable in the editor because of lifetime
extension. In gameplay, the returning of a spinner to the pool will
clean things up (but in the editor that can take longer, depending on
timeline zoom level).

Another thing worth mentioning is that the fade doesn't actually work.
This is due to https://github.com/ppy/osu-framework/pull/4212.

Closes #12119.
 2021-03-22 16:04:51 +09:00
Owen Young
fc632fd48a Added WindowSetting setting to OsuSetting enum so that it can be set by default at startup. Modified LayoutSettings.cs so that when it is changed in the settings, it is written to the local settings as well. 2021-03-22 01:30:20 -05:00
smoogipoo
db64fac824 Delay key fade in legacy mania skins 2021-03-22 15:26:22 +09:00
Dean Herbert
7034289763
Merge pull request #12133 from bdach/hold-note-freezing-regression 2021-03-22 14:11:53 +09:00
Dean Herbert
073dba5330 Remove local workarounds to attempt to avoid crashes on skin change 2021-03-22 14:05:37 +09:00
owen-young
f7bf23dbe9 first attempt at changing windowMode to be fullscreen on default 2021-03-21 21:50:19 -05:00
Bartłomiej Dach
09bc7267c0
Merge pull request #12134 from Joehuu/add-comments-count 2021-03-21 20:24:16 +01:00
Joehu
9bc6cdf042 Fix singular format regression on forum post text 2021-03-21 11:19:07 -07:00
Joehu
e31d583a7f Add comments count to user profile overlay 2021-03-21 11:16:59 -07:00
Bartłomiej Dach
9a330c4c56 Fix mania hold note heads hiding when frozen 
This was an insidious regression from a3dc1d5. Prior to that commit,
`DrawableHoldNoteHead` had `UpdateStateTransforms()` overridden, to set
the hold note head's lifetime. When that method was split into
`UpdateInitialStateTransforms()` and `UpdateHitStateTransforms()`, the
lifetime set was moved to the former.

Unfortunately, that override served two purposes: both to set the
lifetime, and to suppress hit animations which would normally be added
by the base `DrawableManiaHitObject`. That fact being missed led to
`UpdateHitStateTransforms()` hiding the hold note head immediately on
hit and with a slight delay on miss.

To resolve, explicitly override `UpdateHitStateTransforms()` and
suppress the base call, with an explanatory comment.
 2021-03-21 18:46:41 +01:00