Dan Balasescu
3c3b0a15a6
Only run cleanup if directory was created
2023-10-20 18:58:32 +09:00
Dean Herbert
3fb74cb5f9
Move helper method to LegacyRulesetExtensions and stop applying rounding allowance to catch
...
As discussed, it isn't used in stable like this. Was a mistake.
2023-10-20 18:57:14 +09:00
Dean Herbert
2ba6286470
Merge branch 'master' into fix-circle-radius
2023-10-20 18:53:36 +09:00
Susko3
4a3a4ee17f
Change beatmap listing key to B to match Ctrl-B shortcut
2023-10-20 11:47:00 +02:00
Dean Herbert
6399e65f3f
Merge pull request #24966 from peppy/legacy-tick-test-coverage
...
Adjust slider ends to be more lenient during very fast sliders
2023-10-20 18:10:37 +09:00
Bartłomiej Dach
c89081589c
Fix insufficient leniency when querying sample points
2023-10-20 10:26:16 +02:00
Bartłomiej Dach
59a1915451
Add failing test case for insufficient sample query leniency
2023-10-20 10:25:28 +02:00
Dean Herbert
686c45e21b
Merge branch 'master' into legacy-tick-test-coverage
2023-10-20 16:41:32 +09:00
Dean Herbert
ca3a3f600e
Update visuals of spinner implementations to show MAX score differently
2023-10-20 16:11:09 +09:00
Dean Herbert
181a98e8ef
Remove duplicate definition of bonus text in ArgonSpinner
2023-10-20 16:10:54 +09:00
Dean Herbert
3986cec949
Cap bonus score more correctly
2023-10-20 16:10:54 +09:00
Dean Herbert
0da0855692
Add ability to change spin speed in spinner test
2023-10-20 16:10:54 +09:00
Dean Herbert
f16400929d
Update bindable flow to expose every spin, even after max bonus is reached
2023-10-20 15:38:04 +09:00
Dean Herbert
f36a671eb4
Fix a couple of silly inspections
2023-10-20 15:38:00 +09:00
Dean Herbert
d49639bec3
Merge pull request #25173 from bdach/floating-fruits-borked
...
Fix Floating Fruits not flipping playfield properly
2023-10-20 13:04:08 +09:00
Dan Balasescu
6c61894514
Cleanup in a step
2023-10-20 11:35:31 +09:00
Dan Balasescu
e3bbf29333
Add cleanup step
2023-10-20 11:34:08 +09:00
Dan Balasescu
6cf0cbf3a9
Remove repo checkout step
2023-10-20 11:32:11 +09:00
Dan Balasescu
634323e71e
Fix wrong variable
2023-10-20 11:24:16 +09:00
Dean Herbert
6e3e6207ba
Merge pull request #25176 from smoogipoo/diffcalc-isolate-action
2023-10-20 10:45:25 +09:00
Dan Balasescu
d73650331d
Isolate diffcalc workflow runs
2023-10-20 09:44:10 +09:00
Bartłomiej Dach
cd3ff2b74c
Merge pull request #25154 from peppy/taiko-beat-snap-grid
...
Add beat snap grid to osu!taiko editor
2023-10-19 21:34:24 +02:00
Bartłomiej Dach
2c6bf9e346
Remove unused using directive
2023-10-19 20:45:47 +02:00
Bartłomiej Dach
cc1f1d2270
Fix Floating Fruits not flipping playfield properly
...
Regressed by https://github.com/ppy/osu/pull/25070 .
2023-10-19 19:47:49 +02:00
Dean Herbert
74b86349d5
Tidy up CatchHitObjectComposer
2023-10-19 23:57:36 +09:00
Dean Herbert
013b5fa916
Move beat snap grid implementation details to ScrollingHitObjectComposer
2023-10-19 23:54:34 +09:00
Dean Herbert
52c2eb93de
Merge branch 'master' into taiko-beat-snap-grid
2023-10-19 23:53:01 +09:00
Dean Herbert
e8d0962197
Merge pull request #25171 from bdach/distance-snapping-composition
...
Replace `DistancedHitObjectComposer` with composition-based approach
2023-10-19 23:46:10 +09:00
Bartłomiej Dach
0c4e74c82d
Inherit ScrollingHitObjectComposer in catch
2023-10-19 11:58:25 +02:00
Bartłomiej Dach
144ef5a87c
Remove DistancedHitObjectComposer
2023-10-19 11:46:30 +02:00
Bartłomiej Dach
31849192c3
Remove DistancedHitObjectComposer inheritance from catch composer
2023-10-19 11:46:30 +02:00
Bartłomiej Dach
dcfd6a0a8a
Remove DistancedHitObjectComposer inheritance from osu! composer
2023-10-19 11:46:30 +02:00
Bartłomiej Dach
3ab083b696
Split IPositionSnapProvider from IDistanceSnapProvider
...
In preparation to remove `DistancedHitObjectComposer`, split off
`IPositionSnapProvider` from `IDistanceSnapProvider`.
`DistancedHitObjectComposer` was not touching `IPositionSnapProvider`'s
only interface member at all, it was just forwarding it for subclasses
to override to their own leisure.
2023-10-19 11:45:24 +02:00
Bartłomiej Dach
0b8b87d6bd
Merge pull request #25169 from smoogipoo/fix-diffcalc-pr-command
...
Fix invalid PR URL in diffcalc GitHub action
2023-10-19 08:29:28 +02:00
Dan Balasescu
832ba861bb
Fix incorrect PR url in diffcalc workflow
2023-10-19 15:19:51 +09:00
Dean Herbert
66421a55ab
Merge pull request #25159 from smoogipoo/improve-diffcalc-command
...
Fix + improve diffcalc command for comment-based execution
2023-10-19 12:11:16 +09:00
Dan Balasescu
14cadd1eeb
Pin third-party actions
2023-10-19 02:39:34 +09:00
Dean Herbert
42087037ae
Fix Catcher code change not accounting for double sizing requirement
2023-10-18 23:56:17 +09:00
Dean Herbert
040d0970f2
Use DifficultyRange helper method in one more place
2023-10-18 23:54:18 +09:00
Dean Herbert
78d3c3723d
Ignore instead of retry tests
2023-10-18 20:12:14 +09:00
Bartłomiej Dach
12f343f0e2
Merge pull request #24640 from Givikap120/pitch_change
...
Add an "Adjust pitch" switch to DT/HT
2023-10-18 13:07:22 +02:00
Dean Herbert
3a5490892c
Centralise and repair circle size calculations game-wide
2023-10-18 19:50:42 +09:00
Bartłomiej Dach
f1a16c50b8
Merge branch 'master' into pitch_change
2023-10-18 12:27:27 +02:00
Bartłomiej Dach
cff69d63a6
Add inline commentary in Mod{Day,Night}core about different speed adjustments
2023-10-18 12:27:16 +02:00
Dean Herbert
6ae82c5e73
Fix circle scale not matching stable due to missing multiplier
...
This multiplier has to exist.
I'm not guaranteeing that the rest is correct here. Should we be doing
proper cross-testing on this? Maybe, but it's going to be hard to get
right. We could likely check as far as "game pixels", but there's still
a chance that the osu-framework could be doing something weird in the
rest of the hierarchy where playfield scale is involved.
Closes https://github.com/ppy/osu/issues/25162 . Tested to fix the linked
replay.
2023-10-18 18:35:14 +09:00
Dean Herbert
54da6f1048
Merge pull request #25160 from bdach/repeat-arrow-hidden-fade
...
Adjust slider repeat transforms to closer match stable
2023-10-18 18:03:48 +09:00
Dean Herbert
be321e34e9
Attempt to fix flaky tests with egregious retry rule
2023-10-18 17:46:14 +09:00
Dean Herbert
92524d4299
Remove incorrect plural from variable
2023-10-18 17:44:01 +09:00
Dean Herbert
9907adc337
Take in IBindables and tidy up multiplier handling
2023-10-18 17:39:13 +09:00
Dean Herbert
161890292f
Move audio adjustment hookup to own method for clarity
2023-10-18 17:38:11 +09:00
