67193 Commits

This Branch

This Branch

All Branches

• Use sender's realm (because we can)
  Dean Herbert · 2023-12-19 17:27:52 +09:00
  7e9c1b2acb
• Fix sliding sample playing before Slider's start time
  Dan Balasescu · 2023-12-19 17:01:52 +09:00
  fe5e071e70
• Add more detail to exception
  Bartłomiej Dach · 2023-12-19 08:57:18 +01:00
  7c05d66bd7
• Give sliders in test scene a sample
  Dan Balasescu · 2023-12-19 16:47:49 +09:00
  011bd61e7d
• Roll back incorrect change in ShouldMigrateToNewStandardised()
  Bartłomiej Dach · 2023-12-19 08:13:02 +01:00
  ddb67c87a8
• Fix incorrect ordering of items at song select when certain sort modes are used
  Dean Herbert · 2023-12-19 15:09:03 +09:00
  44efa2c540
• Rename class/file (this is not a test scene)
  Dan Balasescu · 2023-12-19 14:27:29 +09:00
  30957f847c
• Add test
  Dan Balasescu · 2023-12-19 14:01:08 +09:00
  f2edb3ea54
• Make taiko OKs worth 150 points
  Dan Balasescu · 2023-12-19 14:01:05 +09:00
  35c0eaee1c
• Add ScoreProcessor methods to override numeric result
  Dan Balasescu · 2023-12-19 13:50:31 +09:00
  c1b55c7fac
• Fix arrow pointing to wrong place
  Dean Herbert · 2023-12-19 13:35:02 +09:00
  469a659938
• Update bug-issue.yml with new workflow for exporting logs
  Dean Herbert · 2023-12-19 13:33:45 +09:00
  ee8a5d5a30
• Merge pull request #25871 from Susko3/fix-logfile-notification

  Fix opening log files from notification not presenting the correct file

  Dan Balasescu · 2023-12-19 10:21:18 +09:00
  b6ed792a41
• Run score conversion for previously-imported scores
  Bartłomiej Dach · 2023-12-18 22:27:51 +01:00
  9c8df4e6d1
• Fix osu! standardised score conversion sometimes exceeding bounds

  Co-authored-by: Zyf <zyfarok@gmail.com>
  
  Closes https://github.com/ppy/osu/issues/25860
  
  Users reported that some stable scores would convert to large negative
  total scores in lazer after the introduction of combo exponent. Those
  large negative total scores were actually mangled NaNs.
  
  The root cause of this was the following calculation going below zero
  unexpectedly:
  
  	https://github.com/ppy/osu/blob/8e8d9b2cd96be4c4b3d8f1f01dc013fc9d41f765/osu.Game/Database/StandardisedScoreMigrationTools.cs#L323
  
  which then propagates negative numbers onward until
  
  	https://github.com/ppy/osu/blob/8e8d9b2cd96be4c4b3d8f1f01dc013fc9d41f765/osu.Game/Database/StandardisedScoreMigrationTools.cs#L337
  
  which yields a NaN due to attempting to take the square root of a
  negative number.
  
  To fix, clamp `comboPortionInScoreV1` to sane limits: to
  `comboPortionFromLongestComboInScoreV1` from below, and to
  `maximumAchievableComboPortionInScoreV1` from above. This is a less
  direct fix than perhaps imagined, but it seems like a better one as it
  will also affect the calculation of both the lower and the upper
  estimate of the score.

  Bartłomiej Dach · 2023-12-18 22:05:19 +01:00
  017003deea
• Fix opening log files from notification not presenting the correct file
  Susko3 · 2023-12-18 21:11:00 +01:00
  cc800a18b2
• Merge pull request #25832 from peppy/more-background-processing-progress-notifications

  Show more comprehensive background processing progress notifications

  Bartłomiej Dach · 2023-12-18 20:05:47 +01:00
  8e8d9b2cd9
• Merge pull request #25856 from peppy/fix-keybaord-adjust-nc-dc

  Fix keyboard precision of nightcore/daycore adjustments being incorrect

  Bartłomiej Dach · 2023-12-18 19:54:17 +01:00
  b8bcf7a097
• Update framework
  Dean Herbert · 2023-12-19 03:22:22 +09:00
  9594ae7802
• Use nunit constraints in test for transparency
  Bartłomiej Dach · 2023-12-18 19:02:23 +01:00
  bf668174ec
• Add realm refresh steps in an attempt to stabilise failing test

  I think this is required because there is a higher chance of batched
  updates with the new structure (and less calls to `BeatmapSetsChanged`
  which causes re-selection).

  Dean Herbert · 2023-12-19 02:08:29 +09:00
  41485c19cf
• Fix mod search textbox having focus while settings are visible

  Stopped arrow key adjust on slider bars from working.
  
  Also just felt wrong that you could type into an off-screen textbox.

  Dean Herbert · 2023-12-19 01:32:34 +09:00
  51f4c7254c
• Fix keyboard precision of nightcore/daycore adjustments being incorrect

  Closes https://github.com/ppy/osu/issues/25854.

  Dean Herbert · 2023-12-19 01:07:33 +09:00
  374425ea75
• Merge pull request #25821 from bdach/fix-collection-dropdown-crash

  Fix collections dropdown crashing during storage migration

  Dean Herbert · 2023-12-19 01:01:23 +09:00
  c466775f78
• Merge pull request #25848 from 65-7a/dropdown-search-padding

  Fix padding on dropdown search bar

  Dean Herbert · 2023-12-19 00:36:14 +09:00
  c88c25e77f
• Merge pull request #25839 from bdach/collection-name-clashes-crashes

  Fix crash when creating collections named "All beatmaps" or "Manage collections..."

  Dean Herbert · 2023-12-19 00:32:18 +09:00
  da658bbf25
• Don't show progress notifications when there are too few items to be worthwhile
  Dean Herbert · 2023-12-19 00:01:09 +09:00
  9aaaa12809
• Revert "Improve performance of attemptSelection using new cached count and LastSelected"

  This reverts commit 25df42630e.

  Dean Herbert · 2023-12-18 22:46:02 +09:00
  d81cabc063
• Fix a few of silly issues
  Dean Herbert · 2023-12-18 22:45:58 +09:00
  25e3a8e82e
• Fix padding on dropdown search bar
  65-7a · 2023-12-19 00:28:23 +11:00
  17f1f8bb43
• Fix crash when creating collections named "All beatmaps" or "Manage collections..."

  Closes https://github.com/ppy/osu/issues/25834
  
  The name fallback that was there previously since
  https://github.com/ppy/osu/pull/11892 was half broken. This way should
  be a lot less prone to failure.

  Bartłomiej Dach · 2023-12-18 12:52:39 +01:00
  eeeb5aa3d4
• Add failing test for adding collection w/ name colliding w/\ default items
  Bartłomiej Dach · 2023-12-18 12:47:42 +01:00
  be16e0e538
• Improve performance of attemptSelection using new cached count and LastSelected
  Dean Herbert · 2023-12-18 20:47:08 +09:00
  25df42630e
• Cache non-filtered beatmap counts to massively improve count performance
  Dean Herbert · 2023-12-18 20:44:08 +09:00
  5755fa214a
• Debounce count updates for good measure
  Dean Herbert · 2023-12-18 20:43:23 +09:00
  034c5cd654
• Simplify invalidation logic

  The only case where this was checking is guaranteed by realm to only be called once.

  Dean Herbert · 2023-12-18 20:31:02 +09:00
  6fa1f5ef9b
• Avoid calling invalidation logic per beatmap set updated

  Realm will batch the updates. We don't want to do expensive operations per set when we don't need to.

  Dean Herbert · 2023-12-18 20:31:02 +09:00
  87b7699fcc
• Combine multiple similar invalidation logic into single event
  Dean Herbert · 2023-12-18 20:31:02 +09:00
  32cc3f9ef7
• Merge pull request #25833 from peppy/fix-song-select-position-reset

  Fix song select's carousel scroll position getting reset on background processing

  Bartłomiej Dach · 2023-12-18 12:27:48 +01:00
  41f5a6e292
• Remove some excessive logging
  Dean Herbert · 2023-12-18 19:20:57 +09:00
  03ac2c3094
• Fix song select's carousel scroll position getting reset on background processing

  This only happened for users using absolute right-click scroll.

  Dean Herbert · 2023-12-18 19:17:59 +09:00
  62444c3d04
• Fix progress notifications queueing up infinite text changes when not visible
  Dean Herbert · 2023-12-18 19:00:44 +09:00
  e3251b40b3
• Add logging of progress every so often
  Dean Herbert · 2023-12-18 18:45:49 +09:00
  5ab3815123
• Also populate ObjectCounts when running a full beatmap process

  Saves running things twice on an old install

  Dean Herbert · 2023-12-18 18:41:41 +09:00
  bfa90e9dcb
• Add progress notifications for background tasks which don't already have them
  Dean Herbert · 2023-12-18 18:41:41 +09:00
  e7d1cf7868
• Add helper method to handle progress notifications for background jobs
  Dean Herbert · 2023-12-18 18:41:41 +09:00
  7462a9f4ab
• Merge pull request #25823 from cl8n/taiko-random-mod-legacy-conversion

  Don't convert TaikoModRandom to/from legacy mods

  Dan Balasescu · 2023-12-18 18:27:35 +09:00
  27ae7d77f4
• Fix collections dropdown crashing during storage migration

  Closes https://github.com/ppy/osu/issues/25815.
  
  `CollectionDropdown.collectionsChanged()` was assuming that if it
  received `null` changes, then it must mean that the change subscription
  is being initialised and the `filters` list will not contain any items.
  
  However, that is not the only circumstance wherein a realm subscription
  can fire with `null` changes; that can also happen after the main realm
  instance gets recycled via the notification registration flow:
  
  	https://github.com/ppy/osu/blob/2f28a92f0a03c8aed6fac2ec7fb41f7ed865f798/osu.Game/Database/RealmAccess.cs#L545-L549
  
  	https://github.com/ppy/osu/blob/2f28a92f0a03c8aed6fac2ec7fb41f7ed865f798/osu.Game/Database/RealmAccess.cs#L1228-L1251
  
  Therefore, to fix the crash, just ensure that the list is cleared every
  time.

  Bartłomiej Dach · 2023-12-18 09:11:00 +01:00
  ef230884a8
• Don't convert TaikoModRandom to/from legacy mods
  clayton · 2023-12-17 23:47:50 -08:00
  f84c181573
• Merge pull request #25776 from smoogipoo/slider-late-hit-lenience

  Add slider head circle late hit lenience

  Dean Herbert · 2023-12-18 13:05:31 +09:00
  2023.1218.0 2f28a92f0a