4654 Commits

• Refactor InputCountController to not require being added to foreign body via Attach

  I've made the flow match `ClicksPerSecondCalculator` as close as
  possible. Hopefully this reads better.

  Dean Herbert · 2023-06-27 16:36:00 +09:00
  e21583ff1b
• Fix incorrect indent size
  Bartłomiej Dach · 2023-06-26 22:40:25 +02:00
  40ceb4dfac
• Rename {KeyCounter -> InputCount}Controller
  Bartłomiej Dach · 2023-06-26 19:27:42 +02:00
  8d91580dc1
• Mark IHasRecordingHandler.Recorder nullable
  Bartłomiej Dach · 2023-06-26 18:52:05 +02:00
  cc45ec4fff
• Split out interfaces from RulesetInputManager and improve xmldoc
  Dean Herbert · 2023-06-26 16:34:57 +09:00
  084354a8dc
• Remove unused interface
  Dean Herbert · 2023-06-26 16:32:19 +09:00
  c8e081c2b6
• Merge branch 'master' into hud/kc-skinnable
  tsrk · 2023-06-25 15:42:08 +02:00
  350d722c8d
• revert: bring back old attachment flow

  As discussed, this would bring more problems that anything.
  
  Refs: 4c39708, f83a4f4

  tsrk · 2023-06-25 15:21:55 +02:00
  a7088ffe22
• Merge pull request #23976 from peppy/gameplay-sample-trigger-source-correctness

  Adjust `GameplaySampleTriggerSource` to only switch samples when close enough to the next hit object

  Bartłomiej Dach · 2023-06-25 08:23:55 +02:00
  25842105ce
• Merge branch 'master' into framework-update
  Bartłomiej Dach · 2023-06-24 18:47:52 +02:00
  d7ae430ec2
• Fix some more missed CI inspections
  Bartłomiej Dach · 2023-06-24 17:11:38 +02:00
  e273c223a8
• Merge branch 'master' into mass-nrt
  Dean Herbert · 2023-06-24 09:59:15 +09:00
  2bda63c2c8
• Fix a couple of remaining issues
  Dean Herbert · 2023-06-24 09:58:36 +09:00
  58e6b3782b
• Manual fixes to reduce warnings to zero
  Dean Herbert · 2023-06-24 01:52:53 +09:00
  df5b389629
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• Change "floating fruits" mod to only apply adjustments to the playfield

  Avoids things like touch screen inputs also being flipped.
  
  Note that these adjustments can't be applied directly to the playfield
  due to how playfields are used in various rulesets (basically relying on
  the `PlayfieldAdjustContainer` to get things in the right place).
  
  Closes #24000.

  Dean Herbert · 2023-06-23 14:18:43 +09:00
  08b3c0cce0
• Fix nested logic not being completely correct (favouring already-passed rather than near-future)
  Dean Herbert · 2023-06-23 13:48:13 +09:00
  64b726d5ec
• Remove redundant parentheses
  Bartłomiej Dach · 2023-06-22 20:02:10 +02:00
  79606317ab
• Make IGameplayClock optional in GameplaySampleTriggerSource to ease testing
  Dean Herbert · 2023-06-21 17:33:42 +09:00
  4ff5275208
• Apply NRT to GameplaySampleTriggerSource
  Dean Herbert · 2023-06-20 21:03:55 +09:00
  cb07f2399f
• Use IGameplayClock to ensure our clock source is correct
  Dean Herbert · 2023-06-20 20:47:56 +09:00
  04dad6c6e8
• Fix nested lookups
  Dean Herbert · 2023-06-20 20:45:02 +09:00
  0e86102681
• Add back optimisation and increase time allowance slightly
  Dean Herbert · 2023-06-20 20:30:07 +09:00
  786d5a394b
• Adjust GameplaySampleTriggerSource to only switch samples when close enough to the next hit object

  Closes #23963.
  
  To simplify things, I've removed the optimisation of using
  `AliveObject`s because it would break the way this whole lookup works.

  Dean Herbert · 2023-06-20 20:06:07 +09:00
  555ce7684b
• Merge branch 'master' into snap-colour-mod
  Dean Herbert · 2023-06-19 20:01:36 +09:00
  aa96fefae2
• refactor: tidy up attachement flow

  TODO: find better naming and improve XMLDocs

  tsrk · 2023-06-18 22:57:21 +02:00
  f83a4f4952
• style(KeyCounterController): remove reliance on Receptor
  tsrk · 2023-06-18 21:26:16 +02:00
  141f9efad5
• refactor: remove detachment logic

  No real use case, cleaning up the diff

  tsrk · 2023-06-15 12:24:37 +02:00
  b4cbcb210e
• Merge branch 'master' into hud/kc-skinnable
  tsrk · 2023-06-14 22:19:45 +02:00
  42b740a175
• refactor: decouple Trigger logic from KeyCounterDisplay

  This allows to keep a coeherent state regardless of the progress of the play

  tsrk · 2023-06-14 21:13:35 +02:00
  c637fddf73
• Run updateScore on Reset for good measure
  Dean Herbert · 2023-06-14 01:54:57 +09:00
  3334323eb7
• Fix score not updating when TrackHitEvents is set to false
  Dean Herbert · 2023-06-13 11:44:52 +09:00
  0ab9a48f00
• Avoid tracking hit events altogether during migration
  Dean Herbert · 2023-06-13 02:15:41 +09:00
  e9fb1f8932
• Avoid unnecessary operations during score processor simulation
  Dean Herbert · 2023-06-13 02:05:11 +09:00
  e0ebb000d6
• Fix weird right-toolbox distance snapping display in osu!catch editor
  Dean Herbert · 2023-06-09 14:36:17 +09:00
  1ab3b43b59
• Added recommendations from bdach:

  Fixed null checking in ApplyToDrawableHitObject
  Renamed mod to "Synesthesia"
  Moved to the "Fun" mod category

  John Biddle · 2023-06-08 00:52:28 -07:00
  d07437f810
• Refactor IWorkingBeatmap.Background to GetBackground()
  Dean Herbert · 2023-06-08 16:19:32 +09:00
  a842f79ad4
• Remove redundant nullable suppression directives
  Salman Ahmed · 2023-06-07 08:20:41 +03:00
  62cb6a98ca
• Merge pull request #23767 from peppy/fix-playfield-border-animation-in-editor

  Fix gameplay playfield border being affected by beatmap track time

  Bartłomiej Dach · 2023-06-06 22:10:18 +02:00
  244e6cc008
• Add IHasNoTimedInputs interface to scope change further
  Dean Herbert · 2023-06-06 22:22:42 +09:00
  247fa088db
• Fix gameplay playfield border being affected by beatmap track time

  Closes https://github.com/ppy/osu/issues/23470.

  Dean Herbert · 2023-06-06 16:08:24 +09:00
  c0016fa5d2
• feat: integrate attachment flow in SkinComponentsContainer
  tsrk · 2023-06-06 00:27:43 +02:00
  6fc6729677
• refactor: improve attachement flow

  This removes the hard reliance on individual classes and makes its usage easiser to ingreate anywhere
  else.

  tsrk · 2023-06-06 00:12:53 +02:00
  4c397085c5
• Merge branch 'master' into tidy-results-grid-usage
  Bartłomiej Dach · 2023-06-03 19:45:23 +02:00
  331e90f720
• Fix legacy diffcalc creating all mods unnecessarily
  Dan Balasescu · 2023-06-02 17:37:43 +09:00
  bfe80fe143
• Return StatisticItems rather than StatisticRows from ruleset

  There were no usages of more than one column being provided per row, so
  it seemed like unnecessarily complexity. I'm currently trying to reduce
  complexity so we can improve the layout of the results screen, which
  currently has up to three levels of nested `GridContainer`s.
  
  Of note, I can't add backwards compatibility because the method
  signature has not changed in `Ruleset` (only the return type). If we do
  want to keep compatibility with other rulesets, we could designate a new
  name for the updated method.

  Dean Herbert · 2023-06-01 14:35:15 +09:00
  985604fab5
• Reverted to applying the color change in OnUpdate, removed EnableComboColour flag from DrawableHitObject.cs
  John · 2023-05-30 01:43:08 -07:00
  ed850196d9
• Merge branch 'master' into scorev2
  Dean Herbert · 2023-05-30 14:34:43 +09:00
  14a376c041
• Merge branch 'master' into acc-challenge
  Bartłomiej Dach · 2023-05-29 22:33:57 +02:00
  5604dfb758
• Reword setting name & description
  Bartłomiej Dach · 2023-05-29 22:12:37 +02:00
  314a0f80f3