61 Commits

• Refactor layout code to be a bit less haphazard

  Visually the same, functionally much saner.

  Bartłomiej Dach · 2024-09-08 16:30:09 +02:00
  7ec2e0e866
• Code quality fix: added type
  schiavoanto · 2024-09-07 16:23:23 +02:00
  2bc6547d49
• Fixed ControlPointTable items being blocked by buttons
  schiavoanto · 2024-09-07 16:15:00 +02:00
  32de8e9b2d
• Redesign timing table tracking

  - On entering the screen, the timing point active at the current instant
    of the map is selected. This is the *only* time where the selected
    point is changed automatically for the user.
  
  - The ongoing automatic tracking of the relevant point after the initial
    selection is *gone*. Even knowing the fact that it was supposed to
    track the supposedly relevant "last selected type" of control point,
    I always found the tracking to be fairly arbitrary in how it works.
    Removing this behaviour also incidentally fixes
    https://github.com/ppy/osu/issues/23147.
  
    In its stead, to indicate which timing groups are having an effect,
    they receive an indicator line on the left (coloured using the
    relevant control points' representing colours), as well as a slight
    highlight effect.
  
  - If there is no control point selected, the table will autoscroll to
    the latest timing group, unless the user manually scrolled the table
    before.
  
  - If the selected control point changes, the table will autoscroll to
    the newly selected point, *regardless* of whether the user manually
    scrolled the table before.
  
  - A new button is added which permits the user to select the latest
    timing group. As per the point above, this will autoscroll the user
    to that group at the same time.

  Bartłomiej Dach · 2024-08-20 11:14:42 +02:00
  a33294ac42
• Remove dead row attribute classes

  These aren't shown on the control point table since difficulty and
  sample control points were moved into objects.

  Bartłomiej Dach · 2024-08-20 09:53:40 +02:00
  373ff47a94
• Fix incorrect editor screen padding
  Dean Herbert · 2024-07-16 18:20:33 +09:00
  4ad7d900c1
• Fix scroll-into-view on control point table not working as it is supposed to
  Bartłomiej Dach · 2024-06-27 09:46:35 +02:00
  9384cbcdd8
• Rewrite ControlPointTable to use virtualised list
  Bartłomiej Dach · 2024-06-26 10:40:02 +02:00
  5c2d446767
• Schedule control point switch for settings modifications to apply first
  Salman Ahmed · 2024-01-17 08:15:01 +03:00
  46429c5074
• Add test coverage and refactor to better handle equality edge case
  Dean Herbert · 2023-12-26 21:21:08 +09:00
  03e2463b06
• Fix selection not being retained in control point list when undoing / redoing
  Dean Herbert · 2023-12-26 21:04:42 +09:00
  1f2f749db6
• Adjust sizing to allow for timing point information now being longer than before
  Dean Herbert · 2023-03-02 18:57:54 +09:00
  6ff1fb6b1a
• Avoid need for implicit null casting
  Dean Herbert · 2022-11-30 14:21:04 +09:00
  2a3b24d058
• Rename method to be more in line with project naming
  Dean Herbert · 2022-11-30 14:17:49 +09:00
  0659c84341
• Don't use verbatim string literals
  Jai Sharma · 2022-11-29 18:22:07 +00:00
  7dbf379351
• Code quality
  Jai Sharma · 2022-11-27 03:23:08 +00:00
  218c04c174
• Add OnRowSelected event to EditorTable
  Jai Sharma · 2022-11-27 02:47:54 +00:00
  3c56b9c93a
• Move Control Group timing data into it's own component
  Jai Sharma · 2022-11-27 02:47:02 +00:00
  792334a190
• Remove #nullable disabled from EditorTable and it's derived classes
  Jai Sharma · 2022-11-27 02:45:56 +00:00
  b6d7bec240
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Split group selection to separate method
  Dan Balasescu · 2022-06-21 12:53:06 +09:00
  046b848bcd
• Change to use ReferenceEquals
  Dan Balasescu · 2022-06-21 12:05:52 +09:00
  9763a58392
• Convert == usages to ReferenceEquals
  Dan Balasescu · 2022-06-20 16:56:19 +09:00
  e0c82d11ab
• Fix group deselected when table is recreated
  Dan Balasescu · 2022-06-20 16:56:19 +09:00
  ca287d0936
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Add TODO about scroll behaviour which is missing
  Dean Herbert · 2022-05-31 15:10:55 +09:00
  ebb83a5e49
• Remove unused parameter from createContent()

  No longer used since 513e470b52.

  Bartłomiej Dach · 2022-02-01 21:35:40 +01:00
  c6a65ccfed
• Clean up unused resolved properties
  Dean Herbert · 2021-12-03 18:49:49 +09:00
  1eed2436e6
• Give more space for time values to allow for negative offsets
  Dean Herbert · 2021-06-11 13:25:09 +09:00
  38bf04d7ff
• Add a touch more space in the timing column
  Dean Herbert · 2021-04-19 18:53:06 +09:00
  a40dcd4b8d
• Adjust Add different background colour for timing area
  Dean Herbert · 2021-04-19 18:25:30 +09:00
  097a347533
• Add new display for effect row attribute
  Dean Herbert · 2021-04-19 16:35:36 +09:00
  f8b20ca8aa
• Add new display for sample row attribute
  Dean Herbert · 2021-04-19 16:23:28 +09:00
  ec249a0edb
• Add new display for difficulty row attribute
  Dean Herbert · 2021-04-19 16:23:06 +09:00
  3aad0a8b9c
• Add new display for timing row attributes
  Dean Herbert · 2021-04-19 16:23:06 +09:00
  a10a8680d0
• Adjust grid spacing to allow attributes to use more width
  Dean Herbert · 2021-04-19 13:24:53 +09:00
  513e470b52
• Move common table layout logic into EditorTable abstract class
  Dean Herbert · 2021-04-13 23:26:19 +09:00
  21e8e5fbca
• Split out common EditorTable base class
  Dean Herbert · 2021-04-13 23:05:58 +09:00
  0edc1a850d
• Small refactoring to use .Trim() instead
  smoogipoo · 2021-02-09 12:00:03 +09:00
  3ce605b5e5
• Fix editor effect attribute tooltip having unnecessary whitespace when only one is enabled
  Joehu · 2021-02-08 10:16:16 -08:00
  414e05affd
• Fix attributes content being zero size and disappearing after being half off-screen
  Joehu · 2021-02-08 01:37:34 -08:00
  5e7823b289
• Fix attributes header not being aligned with content in editor timing mode
  Joehu · 2021-02-08 01:34:32 -08:00
  6b26a18a23
• Rename and add xmldoc for smooth seeking method
  Dean Herbert · 2021-01-15 16:14:21 +09:00
  04fa32bc34
• Replace all usage of IBindableList.GetBoundCopy
  Dean Herbert · 2020-11-04 15:29:14 +09:00
  487a5ecdba
• Change editor timing screen seek behaviour to only occur on clicking table rows

  Previously it would react to any selection changed event, which could in
  lude time changes (which is done by removing then adding the
  ControlPointGroup).
  
  Closes #10590.

  Dean Herbert · 2020-10-27 12:28:12 +09:00
  e1f578c590
• Move event subscription to LoadComplete

  Prevents attempting to read from the `colours` field before it is
  actually injected.

  Bartłomiej Dach · 2020-10-07 22:57:20 +02:00
  b1029a124c
• Move control point colour specifications to common location and use for formatting timing screen table
  Dean Herbert · 2020-10-01 19:29:34 +09:00
  e96e30a19d
• Standardise time display formats across the editor
  Dean Herbert · 2020-09-30 12:45:43 +09:00
  1386c9fe66
• Update BindableList usages
  Dean Herbert · 2020-09-01 11:56:23 +09:00
  d45a1521a1