73007 Commits

This Branch

This Branch

All Branches

• Update existing test cases
  Salman Alshamrani · 2025-04-30 02:24:37 +03:00
  dcbb7209df
• Remove pre-rate rounding in BPM display
  Salman Alshamrani · 2025-04-30 02:23:28 +03:00
  901c1b2650
• Merge pull request #32976 from frenzibyte/fix-footer-content-alignment

  Fix overlay buttons in screen footer not correctly aligned with back button

  Dean Herbert · 2025-04-30 04:56:16 +09:00
  48e74a26e1
• Merge pull request #32977 from frenzibyte/tags-overflow-button-sound

  Add hover click sounds to tag overflow button

  Dean Herbert · 2025-04-29 23:12:24 +09:00
  8e7fb46112
• Share constant more correctly
  Dean Herbert · 2025-04-29 23:02:30 +09:00
  c01ff9f845
• Add hover click sounds to tag overflow button
  Salman Alshamrani · 2025-04-29 06:17:27 +03:00
  dd86620ae3
• Cull out magic numbers in specs
  Salman Alshamrani · 2025-04-29 03:39:26 +03:00
  39bb3105ec
• Fix overlay buttons in screen footer not correctly aligned with back button
  Salman Alshamrani · 2025-04-29 03:33:29 +03:00
  c1bc3d7ff4
• Merge pull request #32949 from bdach/exclude-non-user-playable-mods-from-leaderboard-filter

  Exclude non-user-playable mods from mod filter in beatmap leaderboard

  Dean Herbert · 2025-04-28 18:30:49 +09:00
  3ee8eb2809
• Merge pull request #32967 from Stedoss/fix-taglib-mime-type-culture-variance

  Fix culture variance for MIME type resolution in TagLib file creation

  Bartłomiej Dach · 2025-04-28 10:26:00 +02:00
  ced12d90e8
• Fix ID3 metadata half-applying on audio file switch

  Should be self-explanatory (feedback loop between `reloadMetadata()`
  changing text box current, and text box current changing calling
  `applyMetadata()`).

  Bartłomiej Dach · 2025-04-28 09:41:38 +02:00
  8ea89b9d52
• Use another property when reading artist as fallback

  I was testing with mp3s ripped via Apple Music and for whatever reason
  the artist was in `JoinedPerformers` rather than `JoinedAlbumArtist`.
  I'm not about to go down and do research on id3 so I'm just going to try
  this and see if anyone complains.

  Bartłomiej Dach · 2025-04-28 09:40:34 +02:00
  16b658b322
• Ban culture-unsafe taglib APIs
  Bartłomiej Dach · 2025-04-28 09:26:39 +02:00
  dad04d1661
• Fix missing disposal of TagLib.File in ChangeAudioTrack
  Dean Herbert · 2025-04-28 15:52:55 +09:00
  aab2df1704
• Simplify taglib interactions further
  Dean Herbert · 2025-04-28 15:52:31 +09:00
  40faa3fc99
• Merge pull request #32968 from peppy/user-tag-scale-effect-fix

  Fix user tags potentially re-flowing on mouse down

  Bartłomiej Dach · 2025-04-28 08:48:11 +02:00
  136f951d91
• Fix user tags potentially re-flowing on mouse down

  Closes https://github.com/ppy/osu/issues/32954.

  Dean Herbert · 2025-04-28 14:48:05 +09:00
  4dcc63df9d
• Split UserTagControl out into partial classes
  Dean Herbert · 2025-04-28 14:36:43 +09:00
  61b77f9dd1
• Add manual MIME type resolution for TagLib file creation
  Stedoss · 2025-04-28 13:38:38 +09:00
  c2efda20d7
• Merge pull request #32956 from frenzibyte/metdata-fix-transition

  Fix metadata subwedges pop out transition being back-to-front

  Dean Herbert · 2025-04-27 00:40:21 +09:00
  296ea031f8
• Fix metadata subwedges pop out transition back to front
  Salman Alshamrani · 2025-04-26 17:33:46 +03:00
  230daf7289
• Merge pull request #32896 from bdach/more-hit-window-testing

  Add more test cases covering correct legacy replay playback with respect to hitwindow treatment with mods active

  Dean Herbert · 2025-04-26 06:22:29 +09:00
  d26c94cfac
• Merge pull request #32938 from bdach/ruleset-skin-combo-testing

  Add test scene coverage of HUD layouts on various ruleset/skin combinations

  Dean Herbert · 2025-04-26 05:48:26 +09:00
  4d3631cf96
• Adjust variables for legibility

  I found the previous way things were written a bit awkward. Easier to
  just enforce non-null here.

  Dean Herbert · 2025-04-26 05:18:24 +09:00
  0301463810
• Fix TriangleSkin not always returning a container for GlobalSkinnableContainerLookup

  We have other safeties which mean that this is not an issue during
  gameplay, but in the new `TestSceneHUDOverlayRulesetLayouts` it became
  apparent that allowing this to fallback (via `null` return) could lead
  to weirdness.

  Dean Herbert · 2025-04-26 05:14:36 +09:00
  54e0e1420f
• Fix filename not matching test scene
  Dean Herbert · 2025-04-26 04:51:03 +09:00
  0287ca285c
• Exclude non-user-playable mods from mod filter in beatmap leaderboard

  For easier understanding, substitute "non-user-playable" with
  "autoplay".
  
  The reason that I'm bothering to do this is that if you put autoplay on
  and turn on the "Selected Mods" filter, the request will actually go
  through and hit web, and web will obviously return no scores. On song
  select that's *maybe* fine, even though probably unintended still, but
  now with the leaderboard state being global this also means gameplay
  gets impacted. Which also means that if you Ctrl-Enter to start a map in
  autoplay you're not going to get any gameplay leaderboard scores at all.

  Bartłomiej Dach · 2025-04-25 13:06:01 +02:00
  3eb1ae225d
• Merge pull request #32946 from bdach/new-combo-collapsed
  Dean Herbert · 2025-04-25 17:40:08 +09:00
  3cbdf2b890
• Merge pull request #32845 from nekodex/bss-audio-feedback

  Add audio feedback to the BSS process

  Dean Herbert · 2025-04-25 17:25:12 +09:00
  85a5033454
• Remove unnecessary try-finally usage
  Dean Herbert · 2025-04-25 17:22:25 +09:00
  c6a11a56a3
• Update resources
  Dean Herbert · 2025-04-25 16:35:34 +09:00
  40f6283fb5
• Add test mode which allow more realistic testing of samples
  Dean Herbert · 2025-04-25 16:25:27 +09:00
  032459ea4e
• Attempt to improve appearance of new combo toggle / combo colour control when contracted

  Follow-up to
  https://discord.com/channels/188630481301012481/188630652340404224/1364909125812617258.
  
  Not sure if better, but an attempt was made?

  Bartłomiej Dach · 2025-04-25 08:52:59 +02:00
  bc03a2a930
• Merge pull request #32941 from peppy/user-cover-delayed-load-failure
  Bartłomiej Dach · 2025-04-24 15:23:13 +02:00
  8023bbd5e7
• Merge pull request #32674 from smoogipoo/freestyle-mods

  Allow mods/freemods in combination with freestyle

  Bartłomiej Dach · 2025-04-24 14:51:04 +02:00
  d8a69e462c
• Fix user covers not loading if one corner is off-screen
  Dean Herbert · 2025-04-24 21:40:20 +09:00
  4bf5e9a4dd
• Update 404ing cover image URLs
  Dean Herbert · 2025-04-24 21:27:30 +09:00
  c149a6efd6
• Rework logic to use a looping sample for progress instead
  Jamie Taylor · 2025-04-24 20:38:15 +09:00
  9c56ee3e19
• Remove (currently) unused resolved dependency
  Bartłomiej Dach · 2025-04-24 13:23:00 +02:00
  9818f859cb
• Add test scene coverage of HUD layouts on various ruleset/skin combinations

  As time goes on, default skin layouts are getting more and more
  complicated because of per-ruleset overrides. This was already sort of
  apparent in https://github.com/ppy/osu/pull/31527, and I'm about to make
  it worse, so before I do, this is a test scene that is supposed to make
  it easier to check all possible combinations at a glance.

  Bartłomiej Dach · 2025-04-24 12:50:34 +02:00
  33f45b0a6d
• Merge pull request #32937 from bdach/ternary-selection-fixes

  Fix multiple issues with editor ternary toggle state management

  Dean Herbert · 2025-04-24 19:23:00 +09:00
  a0044116f3
• Merge pull request #32936 from bdach/fix-present-score-dying

  Fix presenting score potentially dying due to deleted beatmap

  Dean Herbert · 2025-04-24 19:17:43 +09:00
  fbb7460322
• Fix deselecting single item from a multiple selection not updating ternary states correctly

  I'm not sure why this condition was written this obtusely, but
  importantly it was also wrong. It fires when the selection contains
  multiple items and only some are removed from it, like when
  ctrl-click-unselecting an item from a multiple selection.

  Bartłomiej Dach · 2025-04-24 09:25:36 +02:00
  5a3ff11710
• Reset sample ternary states on deselection

  Closes https://github.com/ppy/osu/issues/32928.
  
  Appears to match stable:
  
  	https://github.com/peppy/osu-stable-reference/blob/996648fba06baf4e7d2e0b248959399444017895/osu!/GameModes/Edit/Modes/EditorModeCompose.cs#L4137-L4143
  	https://github.com/peppy/osu-stable-reference/blob/996648fba06baf4e7d2e0b248959399444017895/osu!/GameModes/Edit/Modes/EditorModeCompose.cs#L1615-L1618
  	https://github.com/peppy/osu-stable-reference/blob/996648fba06baf4e7d2e0b248959399444017895/osu!/GameModes/Edit/Modes/EditorModeCompose.cs#L4323

  Bartłomiej Dach · 2025-04-24 09:25:27 +02:00
  5c04f427a5
• Fix code quality
  Bartłomiej Dach · 2025-04-24 08:54:10 +02:00
  72dd3513fc
• Fix presenting score potentially dying due to deleted beatmap

  - Closes https://github.com/ppy/osu/issues/27168
  - Closes https://github.com/ppy/osu/issues/32930
  
  It's a little manual (if you perform any of the scenarios in the issues
  above on this branch, the first click will re-import the beatmap but not
  start the replay, and only the second will play it), but maybe fine?

  Bartłomiej Dach · 2025-04-24 08:47:08 +02:00
  c52dce0f38
• Merge pull request #32922 from peppy/fix-tablet-adjust-precision

  Fix tablet settings adjusting with too much precision

  Dean Herbert · 2025-04-24 15:23:56 +09:00
  4a95973b6e
• Change samples to be declared nullable
  Jamie Taylor · 2025-04-24 11:31:02 +09:00
  15a4ffe344
• Move playback logic to Update()
  Jamie Taylor · 2025-04-24 10:48:32 +09:00
  f6f098a0dc
• Merge branch 'master' into freestyle-mods
  Bartłomiej Dach · 2025-04-23 13:49:32 +02:00
  6da4e09717