h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2026-05-25 12:30:17 +08:00
Code Issues Releases Wiki Activity

Fix ID3 metadata half-applying on audio file switch

Browse Source 
Should be self-explanatory (feedback loop between `reloadMetadata()`
changing text box current, and text box current changing calling
`applyMetadata()`).
This commit is contained in:
Bartłomiej Dach
2025-04-28 09:41:38 +02:00
Unverified
parent 16b658b322
commit 8ea89b9d52
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
osu.Game/Screens/Edit/Setup/MetadataSection.cs
+8
View File
@@ -25,6 +25,7 @@ namespace osu.Game.Screens.Edit.Setup
private FormTextBox sourceTextBox = null!;
private FormTextBox tagsTextBox = null!;
private bool reloading;
private bool dirty;
public override LocalisableString Title => EditorSetupStrings.MetadataHeader;
@@ -105,6 +106,8 @@ namespace osu.Game.Screens.Edit.Setup
private void reloadMetadata()
{
reloading = true;
var metadata = Beatmap.Metadata;
RomanisedArtistTextBox.ReadOnly = false;
@@ -120,10 +123,15 @@ namespace osu.Game.Screens.Edit.Setup
tagsTextBox.Current.Value = metadata.Tags;
updateReadOnlyState();
reloading = false;
}
private void applyMetadata()
{
if (reloading)
return;
Beatmap.Metadata.ArtistUnicode = ArtistTextBox.Current.Value;
Beatmap.Metadata.Artist = RomanisedArtistTextBox.Current.Value;
Beatmap.Metadata.TitleUnicode = TitleTextBox.Current.Value;