Bartłomiej Dach
dc9c68b642
Merge pull request #24438 from peppy/multi-spectator-flow-fixes
...
Fix issues switching to new beatmap in multiplayer spectator
2023-08-01 19:38:37 +02:00
Bartłomiej Dach
5b6c3321cf
Merge branch 'master' into multi-spectator-flow-fixes
2023-08-01 19:03:48 +02:00
Bartłomiej Dach
cecb3845e7
Merge pull request #24439 from peppy/multi-spectator-extended-results
...
Show extended statistics in multiplayer spectator automatically
2023-08-01 19:00:28 +02:00
Bartłomiej Dach
a75f42f5a9
Merge branch 'master' into multi-spectator-extended-results
2023-08-01 18:25:41 +02:00
Bartłomiej Dach
d65f08a048
Merge pull request #24427 from peppy/fix-skin-editor-crash-multi-spectator
...
Fix game crashing when entering skin editor in multiplayer spectator
2023-08-01 18:25:11 +02:00
Bartłomiej Dach
e591c7273b
Merge pull request #24440 from peppy/multi-spectator-animation-fix
...
Fix centred player not animating correctly
2023-08-01 18:19:15 +02:00
Bartłomiej Dach
f7d5ac9f92
Privatise setter
2023-08-01 18:09:48 +02:00
Bartłomiej Dach
bcfc76b469
Add visual-only test coverage for centred player case
2023-08-01 17:41:07 +02:00
Dean Herbert
70bd1d3cf4
Fix centred player not animating correctly
2023-08-01 20:18:21 +09:00
Dean Herbert
df504e1fc2
Show extended statistics in multiplayer spectator automatically
2023-08-01 20:02:36 +09:00
Dean Herbert
fe47dc291b
Fix onLoadRequested getting early-exited too early in spectator scenarios
...
In some scenarios, multiplayer spectator would not tick over to the next
beatmap.
Here's an example:
- Room has two items queued
- Local user starts download of both
- First beatmap starts and download is complete
- First beatmap ends (spectating is active)
- Second beatmap starts but download is not complete
In this scenario, the local client will get stuck at the spectator
screen due to the `onLoadRequested`-invoked screen change being early
exited.
It would require manual recovery (clicking back button) to return to a
sane state.
2023-08-01 19:22:41 +09:00
Dean Herbert
9fe9ea2c90
Fix potential crash on multiple StartGameplay calls in multiplayer spectator
2023-08-01 19:22:41 +09:00
Dean Herbert
ed0c7e8880
Add failing test coverage showing crash on multiple StartGameplay invocations
2023-08-01 19:21:58 +09:00
Bartłomiej Dach
52730f7cd6
Merge pull request #24430 from peppy/update-framework
...
Update framework
2023-08-01 01:05:49 +02:00
Dean Herbert
528298bc39
Update test in line with framework changes
2023-08-01 07:17:12 +09:00
Dean Herbert
d78cc60851
Update framework
2023-08-01 07:12:40 +09:00
Dean Herbert
a3afb198a1
Merge pull request #24341 from bdach/selection-operations-refactor
...
Refactor rotation handling in editor to facilitate reuse
2023-07-31 17:18:05 +09:00
Dean Herbert
0e59cdc771
Merge pull request #24424 from bdach/exit-logo-hide
...
Fix osu! logo suddenly disappearing during rapid exit
2023-07-31 17:10:49 +09:00
Dean Herbert
72005bef7c
Fix skin editor crashing if the same component is provided twice
2023-07-31 15:10:58 +09:00
Bartłomiej Dach
ebe5dd2ac9
Interface with SelectionRotationHandler via DI rather than explicit passing
2023-07-30 20:21:41 +02:00
Bartłomiej Dach
262f25dce8
Make SelectionRotationHandler a Component
2023-07-30 20:18:33 +02:00
Bartłomiej Dach
821cd08f34
Merge branch 'master' into selection-operations-refactor
2023-07-30 19:29:06 +02:00
Bartłomiej Dach
7763f3dd40
Fix osu! logo suddenly disappearing during rapid exit
2023-07-30 19:05:37 +02:00
Dean Herbert
a6343a669c
Merge pull request #24422 from bdach/multiplayer-exit-reliability
...
Fix multiplayer match screen being exited from when not current
2023-07-30 23:33:32 +09:00
Bartłomiej Dach
d3435483eb
Fix multiplayer match screen being exited from when not current
...
This was supposed to be fixed by #24255 , but has popped up as a
regression on Sentry since:
https://sentry.ppy.sh/organizations/ppy/issues/22749/?project=2&referrer=regression_activity-email
On a fifteen-minute check I cannot figure out how to reproduce, so
rather than spending further brain cycles on this, just apply the same
explicit guard that like fifteen other places do.
2023-07-30 15:50:10 +02:00
Bartłomiej Dach
3e801d8696
Merge pull request #24419 from peppy/fix-replay-export-queued-op
...
Fix replay being unexpected exported at results screen after score switch
2023-07-30 15:31:17 +02:00
Bartłomiej Dach
1f7f336fd5
Merge branch 'master' into fix-replay-export-queued-op
2023-07-30 14:58:14 +02:00
Dean Herbert
15b5b481aa
Merge pull request #24421 from bdach/fix-nrt
2023-07-30 21:43:08 +09:00
Bartłomiej Dach
1981e49a40
Fix nullability inspection
2023-07-30 14:28:16 +02:00
Bartłomiej Dach
b51e577239
Merge pull request #24418 from peppy/now-playing-async-fix
...
Fix now playing overlay background occasionally showing incorrect background
2023-07-30 14:05:49 +02:00
Bartłomiej Dach
898913f32a
Merge pull request #24415 from peppy/multi-spectator-improvements
...
General visual improvements to mutliplayer spectatator screen
2023-07-30 12:43:26 +02:00
Bartłomiej Dach
e208f38bcb
Merge pull request #24361 from peppy/fix-editor-global-music-hotkey-conflicts
...
Disallow interacting with the global track state in `Player` and `Editor`
2023-07-30 12:28:53 +02:00
Dean Herbert
6d5b3617b3
Remove pending export operation if active score is changed
2023-07-30 16:41:45 +09:00
Dean Herbert
35ec55c1f6
Don't queue export replay operations if button is disabled
2023-07-30 16:41:33 +09:00
Dean Herbert
de61b74e91
Add proper cancellation and out-of-order blocking logic to NowPlayingOverlay's background carousel
2023-07-30 16:21:35 +09:00
Dean Herbert
07d224ecb6
Apply NRT to NowPlayingOverlay
2023-07-30 16:17:04 +09:00
Dean Herbert
4f83c8661a
Remove unnecessary async fetch of beatmap in NowPlayingOverlay
...
No idea if this was historically required for some reason, but it's
definitely not required now.
2023-07-30 16:16:25 +09:00
Dean Herbert
45ceaba00d
Disable multiplayer spectator zoom when there's only one player's screen visible
2023-07-30 14:40:58 +09:00
Dean Herbert
feea412bec
Add test with only one player
2023-07-30 14:40:24 +09:00
Dean Herbert
7138291636
Adjust xmldoc to explicitly metnion it only affects end user control
2023-07-30 13:52:58 +09:00
Dean Herbert
945d89e955
Move disables to loading screens for better coverage of edge cases
2023-07-30 13:45:42 +09:00
Dean Herbert
75625f089e
Hide toolbar when entering multiplayer spectator
2023-07-30 02:29:14 +09:00
Dean Herbert
38244c081f
Further refactorings along with shadow implementation
2023-07-30 02:29:14 +09:00
Dean Herbert
84bc14c1dd
Improve animation and sizing of maximised screen display
2023-07-30 02:29:14 +09:00
Dean Herbert
1826819663
Move Facade to nested class
2023-07-30 02:29:14 +09:00
Dean Herbert
5fa0a21b56
Add corner radius around player areas
2023-07-30 02:29:14 +09:00
Bartłomiej Dach
55cb400674
Merge pull request #24386 from peppy/fix-autoplay-mod-revert
...
Fix temporary auto mod (ctrl+enter at song select) not reverting in all scenarios
2023-07-29 16:43:46 +02:00
Bartłomiej Dach
579b0bc570
Merge branch 'master' into fix-autoplay-mod-revert
2023-07-29 16:12:11 +02:00
Bartłomiej Dach
43a51671ac
Fix wrong test step name
2023-07-29 16:12:02 +02:00
Dean Herbert
a7ff084be2
Merge pull request #24405 from bdach/spinner-input-test
2023-07-29 11:34:45 +09:00
