1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-16 09:17:48 +08:00
Commit Graph

69598 Commits

Author SHA1 Message Date
Dean Herbert
502192ff6f
Merge pull request #29529 from frenzibyte/fix-mania-stuff
Fix mania combo counter positioning break on centre anchor
2024-08-22 11:08:18 +09:00
Salman Ahmed
922814fab3 Fix flag reset on connection dropouts 2024-08-22 06:00:37 +09:00
Salman Ahmed
a669c53df7 Add failing test cases 2024-08-22 06:00:07 +09:00
Salman Ahmed
1efa6b7221 Merge if branches 2024-08-22 05:40:43 +09:00
Salman Ahmed
fc02b4b942 Alter NRT usage 2024-08-22 05:39:57 +09:00
Dean Herbert
ac5a3a0959
Remove one unused parameter 2024-08-22 02:17:11 +09:00
Dean Herbert
87123d99bf
Move URL implementation to extension methods and share with other usages 2024-08-22 02:08:01 +09:00
Dean Herbert
18a3ab2ffd
Use "link" instead of "URL" 2024-08-22 01:45:43 +09:00
Dean Herbert
a943000579
Merge pull request #29435 from OliBomby/improve-snaps
Fix timeline snapping ignoring nearby timing points
2024-08-22 01:36:30 +09:00
Dean Herbert
fb5fb78fd3
Move zero marker below control points to avoid common overlap scenario 2024-08-22 01:09:22 +09:00
Dean Herbert
843b10ef34
Add back incorrectly removed control point display toggle 2024-08-22 01:05:47 +09:00
Dean Herbert
2876cb73bd
Merge pull request #28991 from Layendan/master
Add collection and favourite buttons to results screen
2024-08-21 23:59:26 +09:00
Bartłomiej Dach
5f88435d96
Add support for retrieving submit/rank date from local metadata cache in version 2
Closes https://github.com/ppy/osu/issues/22416.
2024-08-21 15:42:22 +02:00
OliBomby
423feadd64 Revert "add arrow indicator"
This reverts commit 1ce9e97fd4.
2024-08-21 14:12:58 +02:00
OliBomby
094b184191 snap the slider duration in normal drag 2024-08-21 12:28:56 +02:00
Bartłomiej Dach
28d0a24555
Fix the fix
The more proper way to do this would be to address the underlying issue,
which is https://github.com/ppy/osu/issues/29546, but let's do this
locally for now.
2024-08-21 12:27:56 +02:00
OliBomby
eefd7cf083 add back protection against perfect curve segments with > 3 points 2024-08-21 12:03:15 +02:00
Salman Ahmed
c92af71029 Add in-gameplay version of kiai star fountains/burst 2024-08-21 17:34:38 +09:00
jkh675
3d5b57454e Fix null reference 2024-08-21 16:21:49 +08:00
Dean Herbert
fef56cc29e
Remove expanding behaviour of timeline completely 2024-08-21 16:57:52 +09:00
Dean Herbert
7e6490133d
Adjust visuals of tick display (and fine tune some other timeline elements) 2024-08-21 16:46:14 +09:00
Dean Herbert
1a48a6f654
Reduce size of hit objects on timeline 2024-08-21 16:46:13 +09:00
Dean Herbert
3065f808a7
Simplify timing point display on timeline 2024-08-21 16:46:13 +09:00
Dean Herbert
a0002943a1
Adjust centre marker visuals a bit 2024-08-21 16:46:12 +09:00
Bartłomiej Dach
c4f08b42ab
Use colours to distinguish buttons better 2024-08-21 09:05:33 +02:00
Dan Balasescu
4ee5a1225e
Merge pull request #29540 from frenzibyte/fix-resume-overlay
Fix resume overlay appearing behind HUD/skip overlays
2024-08-21 08:56:01 +09:00
OliBomby
8d72ec8bd6 move timing point binary search back inline 2024-08-21 01:50:52 +02:00
OliBomby
db568bfb79 add tests 2024-08-21 01:01:17 +02:00
OliBomby
ff3bffc7d9 add test 2024-08-21 00:30:57 +02:00
OliBomby
09ca190b8d re-implement ConvexHull 100% original 2024-08-21 00:10:15 +02:00
OliBomby
1ce9e97fd4 add arrow indicator 2024-08-20 23:38:38 +02:00
OliBomby
ae6d855f8d Merge remote-tracking branch 'upstream/master' into doubleclick 2024-08-20 23:19:27 +02:00
Salman Ahmed
637c9aeef0 Add DailyChallengeIntroPlayed session static 2024-08-21 03:37:04 +09:00
Salman Ahmed
b7599dd1f8 Keep mod customisation panel open when dragging a drawable 2024-08-21 03:23:23 +09:00
Salman Ahmed
ae4fefeba1 Add failing test case 2024-08-21 03:22:03 +09:00
Salman Ahmed
0d358a1dae Fix resume overlay appearing behind HUD/skip overlays 2024-08-21 02:53:11 +09:00
Dan Balasescu
f4b8fc6165
Merge pull request #29536 from frenzibyte/fix-legacy-key-counter-position
Fix legacy key counter position not matching stable
2024-08-21 01:05:46 +09:00
Salman Ahmed
20658ef4ee Fix legacy key counter position not matching stable 2024-08-21 00:10:16 +09:00
jkh675
8e273709f1 Implement copy url in beatmap and beatmap set carousel 2024-08-20 22:48:11 +08:00
Dan Balasescu
2011d5525f
Add flaky test attribute to some tests
See occurences like https://github.com/ppy/osu/actions/runs/10471058714.
2024-08-20 22:21:10 +09:00
Dan Balasescu
5bb94000d3
Merge pull request #29534 from bdach/fix-divisor-crash
Fix crash on attempting to edit particular beatmaps
2024-08-20 22:06:32 +09:00
Dan Balasescu
44213a34ae
Merge pull request #29508 from peppy/hold-for-menu-sometimes
Change "hold for menu" button to only show for touch by default
2024-08-20 21:45:50 +09:00
Bartłomiej Dach
c2dd2ad978
Clamp beat divisor to sane range when decoding
In my view this is a nice change, but do note that on its own it does
nothing to fix https://github.com/ppy/osu/issues/29492, because of
`BeatmapInfo` reference management foibles when opening the editor. See
also: https://github.com/ppy/osu/issues/20883#issuecomment-1288149271,
https://github.com/ppy/osu/pull/28473.
2024-08-20 13:52:29 +02:00
Bartłomiej Dach
bb964e32fa
Fix crash on attempting to edit particular beatmaps
Closes https://github.com/ppy/osu/issues/29492.

I'm not immediately sure why this happened, but some old locally
modified beatmaps in my local realm database have a `BeatDivisor` of 0
stored, which is then passed to
`BindableBeatDivisor.SetArbitraryDivisor()`, which then blows up.

To stop this from happening, just refuse to use values outside of a sane
range.
2024-08-20 13:51:58 +02:00
Bartłomiej Dach
c9f1ef5361
Fix incorrect bank set / sample addition logic
Closes https://github.com/ppy/osu/issues/29361.

Typical case of a few early-returns gone wrong leading to `NodeSamples`
not being checked correctly.
2024-08-20 12:37:01 +02:00
Bartłomiej Dach
3202c77279
Add failing test 2024-08-20 12:36:05 +02:00
Dean Herbert
ebff2ebf01
Merge pull request #29528 from smoogipoo/invert-snapping-binds
Make grid/distance snap binds T/Y respectively
2024-08-20 19:23:42 +09:00
Dean Herbert
a633fcdb49
Merge branch 'master' into redesign-timing-table-tracking 2024-08-20 19:16:03 +09:00
Bartłomiej Dach
f0ddb6daa4
Merge pull request #29445 from OliBomby/transparent-break
Make break periods in bottom timeline transparent
2024-08-20 11:46:02 +02:00
Bartłomiej Dach
2a22049fec
Merge branch 'master' into redesign-timing-table-tracking 2024-08-20 11:38:12 +02:00