Aurelian
f3cae73e2e
Added tests for difficulty clamping
2024-05-22 13:26:00 +02:00
tsunyoku
97fe59cb24
set Ranked to true for OsuModTraceable
2024-05-22 10:38:47 +01:00
Aurelian
b25987ffe7
Changed allowed mania keys, and reverted 0af32c5
2024-05-22 11:37:55 +02:00
Dean Herbert
d0b1ebff5a
Revert "Temporary rollback of framework / SDL3"
...
This reverts commit d7d569cf4e
2024-05-22 16:29:39 +08:00
Dean Herbert
3a608aa815
Merge pull request #28194 from bdach/daily-challenge-models
...
Add client/server models & operations for "daily challenge" feature
2024-05-22 15:48:23 +08:00
Dean Herbert
f979200712
Use null conditional rather than implicit not-null
2024-05-22 12:06:51 +08:00
Dean Herbert
1fdebe94ac
Merge branch 'master' into lazer-speedkeys
2024-05-22 12:05:04 +08:00
Dean Herbert
02a388cba6
Fix enum not being at end (and adjust naming)
2024-05-22 12:03:48 +08:00
Dean Herbert
99d99cede0
Basic cleanup
...
Before I gave up on attempting to fix the method.
2024-05-22 11:59:34 +08:00
Fabian van Oeffelt
3403789c6f
Toast now only shows when speed is actually changed
2024-05-21 16:11:20 +02:00
Fabian van Oeffelt
148afd1201
Change Speedchange behaviour to keep changing while holding key, Add Toast to nofity user what just happend
2024-05-21 14:47:34 +02:00
Bartłomiej Dach
45fcbea182
Compute total score without mods during standardised score conversion
...
This is going to be used by server-side flows. Note that the server-side
overload of `UpdateFromLegacy()` was not calling
`LegacyScoreDecoder.PopulateTotalScoreWithoutMods()`.
Computing the score without mods inline reduces reflection overheads
from constructing mod instances, which feels pretty important for
server-side flows.
There is one weird kink in the treatment of stable scores with score V2
active - they get the *legacy* multipliers unapplied for them because
that made the most sense. For all intents and purposes this matters
mostly for client-side replays with score V2. I'm not sure whether
scores with SV2 ever make it to submission in stable.
There may be minute differences in converted score due to rounding
shenanigans but I don't think it's worth doing a reverify for this.
2024-05-21 13:11:08 +02:00
Aurelian
1127a69359
Moved DIfficulty Clamping to occur after the file has been parsed
...
This is to handle potential issues with the ruleset being parsed after circle size has been parsed.
2024-05-21 10:15:53 +02:00
Dean Herbert
20a539bc4b
Merge pull request #28262 from bdach/fix-present-confusion-on-empty-hash
...
Do not attempt to match score by equality of empty hash when presenting it
2024-05-21 14:44:10 +08:00
Dean Herbert
d7d569cf4e
Temporary rollback of framework / SDL3
2024-05-21 14:36:16 +08:00
Dean Herbert
e740b8bcc3
Fix single frame glitching in skin editor
...
https://github.com/ppy/osu/pull/28257#discussion_r1606999574
2024-05-21 14:36:11 +08:00
Dean Herbert
3b86da443b
Merge pull request #28257 from bdach/fix-skin-editor-spaz
...
Fix closest anchor selection spazzing out in multiple scenarios
2024-05-21 14:35:29 +08:00
Aurelian
db8b72eb37
Clamped Difficulty Ranges to [0,10]
2024-05-20 16:23:16 +02:00
Bartłomiej Dach
ed498f6eed
Do not attempt to match score by equality of hash if it's empty
...
Closes https://github.com/ppy/osu/issues/28216 .
The affected user's database contained six sentakki scores with an empty
hash. When an online score is being imported, an online model (which
does not have a hash) will be transmogrified into a `ScoreInfo` with
an empty hash, which would end up accidentally matching those scores
and basically breaking everything at that point.
To fix, avoid attempting to match anything on empty hash. This does not
break online score matching because for those cases the actual online ID
of the score will be used.
2024-05-20 15:05:41 +02:00
Bartłomiej Dach
3b15c223be
Add failing test case
2024-05-20 15:05:39 +02:00
Dan Balasescu
e6baa06f2e
Merge pull request #28228 from Susko3/show-mouse-joystick-settings-mobile
...
Show mouse and joystick settings on mobile
2024-05-20 21:49:27 +09:00
Bartłomiej Dach
85f85dee9e
Enable NRT in TestScenePresentScore
2024-05-20 14:46:28 +02:00
Dan Balasescu
2aa9328830
Merge pull request #28260 from bdach/discord-rpc-i-swear-to-god
...
Fix unnecessary padding of empty strings for discord RPC purposes
2024-05-20 20:36:07 +09:00
Dan Balasescu
976c6c4f25
Merge pull request #28235 from tsunyoku/optimise-rhythm-evaluator-loop-logic
...
Reduce `Previous` calls in `RhythmEvaluator` by optimising loop logic
2024-05-20 20:31:46 +09:00
Bartłomiej Dach
fe0af7e720
Fix unnecessary padding of empty strings for discord RPC purposes
...
Closes https://github.com/ppy/osu/issues/28248 .
Destroy all software.
2024-05-20 11:37:35 +02:00
Bartłomiej Dach
3da3b91be5
Improve closest origin selection to include effects of rotation/flip
...
Closes https://github.com/ppy/osu/issues/28237 .
Solution as proposed here:
https://github.com/ppy/osu/pull/28089#issuecomment-2095372157
For flips and rotations by 90 degrees this does what you would expect it
to. For arbitrary rotations it *sort of kind of* attempts to do this but
the results are a bit wonky - probably still better than what was there
before, though?
2024-05-20 10:23:12 +02:00
Bartłomiej Dach
c03f68413a
Fix skin editor closest origin selection spazzing out on scaled sprites
...
Closes https://github.com/ppy/osu/issues/28215 .
`drawable.Position` is a location in the parent's coordinate space, and
`drawable.OriginPosition` is in the drawable's local space and
additionally does not take scale into account.
2024-05-20 10:23:07 +02:00
Dan Balasescu
dedc2d2aa0
Merge pull request #28230 from tsunyoku/remove-extra-rhythm-previous-calls
...
Remove unneeded `Previous` calls from `RhythmEvaluator`
2024-05-20 04:37:14 +09:00
James Wilson
f31928875b
Reduce Previous calls in RhythmEvaluator by optimising loop logic
2024-05-19 16:26:51 +01:00
James Wilson
609268786f
remove unneeded extra Previous calls from RhythmEvaluator
2024-05-19 13:29:49 +01:00
Susko3
04acc58b74
Don't show warning on android
...
Unsure about iOS.
2024-05-19 14:12:21 +02:00
Susko3
e4858a975d
Show mouse and joystick settings on mobile
2024-05-19 14:07:40 +02:00
Dean Herbert
5e1f6964d1
Merge pull request #28213 from bdach/fix-realm-migration-fail
...
Fix total score without mods migration failing on custom ruleset scores when custom ruleset cannot be loaded
2024-05-19 15:55:36 +08:00
Bartłomiej Dach
be642c8c42
Fix total score without mods migration failing on custom ruleset scores when custom ruleset cannot be loaded
...
Closes https://github.com/ppy/osu/issues/28209 .
Yes this means that such scores will have a zero total score without
mods in DB and thus might up getting their total recalculated to zero
when we try a mod multiplier rebalance (unless we skip scores with zero
completely I suppose). I also don't really care about that right now.
2024-05-19 09:43:33 +02:00
Dean Herbert
9fcd3b562a
Merge pull request #28201 from frenzibyte/fix-settings-padding
...
Fix checkboxes looking misaligned when placed next to a slider bar
2024-05-19 10:36:54 +08:00
Dean Herbert
9c559d91f1
Merge pull request #28205 from EVAST9919/control-point-nesting
...
Reduce container nesting inside `PathControlPointPiece`
2024-05-19 08:37:57 +08:00
Andrei Zavatski
614cbdf0a4
Reduce container nesting in PathControlPointPiece
2024-05-18 22:51:58 +03:00
Fabian van Oeffelt
3fdbd735ce
change to single Function,
...
Nightcore now switches into Daycore, keep Adjustpitch after change
2024-05-18 18:40:51 +02:00
Fabian van Oeffelt
99f30d92c8
Add Unit Tests
2024-05-18 18:38:31 +02:00
Fabian van Oeffelt
80064c4b98
Speedchange now also works in Modselect
2024-05-18 18:38:23 +02:00
Fabian van Oeffelt
a12a20e8b5
Change Inputkeys to Ctrl+Up/Ctrl+Down
2024-05-18 18:37:44 +02:00
Dean Herbert
37fdfbfaa0
Merge branch 'master' into footer-v2-back-button
2024-05-18 22:15:32 +08:00
Dean Herbert
7b847ad815
Merge pull request #28182 from frenzibyte/footer-v2-renamings
...
Rename and move new footer classes to appropriate places
2024-05-18 22:14:45 +08:00
Salman Ahmed
a912e56ca9
Fix checkboxes applying extra padding
2024-05-18 11:06:29 +03:00
Aurelian
0af32c5d4b
Added a minimum value for the scale calculated by the CS value.
2024-05-18 07:45:01 +02:00
Salman Ahmed
0a391d5c4e
Remove duplicate back button class
2024-05-18 08:39:45 +03:00
Dan Balasescu
9532725eb7
Merge pull request #28198 from frenzibyte/remove-warnaserror-from-local-builds
...
Remove `TreatWarningsAsErrors` flags from local builds for developer convenience
2024-05-18 13:40:11 +09:00
Salman Ahmed
2027d481ee
Remove TreatWarningsAsErrors flags from local builds for developer convenience
2024-05-18 06:38:25 +03:00
Bartłomiej Dach
a4142937e7
Update resources
2024-05-17 12:53:25 +02:00
Bartłomiej Dach
c9b7aaf442
Fix formatting
2024-05-17 11:50:23 +02:00
