Dean Herbert
1814a325d8
Move GetSettingUnderlyingValue to a SettingSource extension method
2022-03-15 14:54:00 +09:00
Bartłomiej Dach
08b3bc222d
Revert "Fix potential crash in tests when attempting to lookup key bindings in cases the lookup is not available"
...
This reverts commit 8115a4bb8f
2022-03-05 16:42:51 +01:00
Bartłomiej Dach
e4b4c3c5c4
Merge branch 'master' into offset-ui-improvements
2022-03-05 16:10:18 +01:00
Bartłomiej Dach
346cec3577
Merge branch 'add-offset-adjust-tooltip-text' into combine-time-slider-implementation
2022-03-05 14:58:56 +01:00
Dean Herbert
c1c9482077
Add note about how global audio offset is currently applied
2022-03-04 12:44:02 +09:00
Dean Herbert
8115a4bb8f
Fix potential crash in tests when attempting to lookup key bindings in cases the lookup is not available
2022-03-04 12:44:02 +09:00
Dean Herbert
ac914878b8
Move default function specifications to OsuConfigManager
...
This ensures that running tests in release configuration will not fail
due to the same issue being fixed in this PR.
2022-03-04 12:31:58 +09:00
Dean Herbert
7854a0a913
Use double instead of float for UIHoldActivationDelay configuration value
...
All times use double, so let's also use double here.
2022-03-04 12:22:56 +09:00
Dean Herbert
f09a4e9c5b
Fix potential crash in tests when attempting to lookup key bindings in cases the lookup is not available
2022-03-03 16:29:37 +09:00
Dean Herbert
6eb2c28e41
Rename RealmContextFactory to RealmAccess
2022-01-24 20:38:07 +09:00
Dean Herbert
623d6d6d2d
Add migration of positional hitsounds setting to new level based setting
2022-01-03 12:46:20 +09:00
Dean Herbert
5dd024aab7
Remove outdated settings migration
2022-01-03 12:46:02 +09:00
Dean Herbert
bb54f438aa
Merge branch 'master' into positional-sounds-strength-adjustment
2022-01-03 12:40:56 +09:00
Bartłomiej Dach
979624160f
Do not reset last hover sound playback time on inactivity
2021-12-21 08:47:41 +01:00
Bartłomiej Dach
cd10af633c
Remove unused private method
2021-12-21 08:47:26 +01:00
Dean Herbert
981158ed88
Rename method and simplify SetDefault calling code
2021-12-21 15:34:32 +09:00
dekrain
9344897542
Split session statics reset method to prevent unloading seasonal backgrounds while idle
2021-12-20 16:51:51 +01:00
Dean Herbert
8d9c37a825
Merge branch 'master' into primary-key-consistency
2021-12-08 21:34:38 +09:00
Dean Herbert
fb2310f826
Specify config file default as DEFAULT_SKIN's guid
2021-12-01 12:45:47 +09:00
Dean Herbert
3db5646fa8
Create Guid constants for system skins (and store skin choice to configuration as guid)
2021-11-29 18:28:25 +09:00
mk-56
c3fb793762
Fixed the problems that were brought up and deleted the old bind logic
2021-11-28 14:06:53 +01:00
mk-56
e83115ad5e
Binding logic fix, nullification of unnecessary path
2021-11-28 03:25:11 +01:00
mk-56
eaa464e548
Initial implementation of adjustable positional hitobject audio strength
2021-11-28 02:58:08 +01:00
Dean Herbert
f264b128c2
Merge branch 'master' into realm-ruleset-setting-short-name
2021-11-23 14:55:36 +09:00
Dean Herbert
329bae50b0
Switch realm ruleset configuration to use ruleset's ShortName as key
2021-11-22 18:52:00 +09:00
Dean Herbert
f1926c6d27
Store preferred ruleset to configuration using ShortName instead of ID
2021-11-22 17:45:31 +09:00
Dean Herbert
eecf6ad558
Add IsManaged helper method to EF classes to match realm implementation
2021-11-19 21:56:06 +09:00
Dean Herbert
6944151486
Apply batch fixing of built-in types using var
2021-10-27 13:04:41 +09:00
Joseph Madamba
1ae6621c85
Fix a missed toast shortcut string not localising correctly
2021-10-22 15:45:48 -07:00
Dean Herbert
8672b3325a
Fix a couple more weird variable names
2021-10-19 17:22:50 +09:00
Dean Herbert
61670a70b6
Tidy up tracked settings code syntax and fix remaining issue
2021-10-19 17:21:07 +09:00
Dean Herbert
192cfe8717
Replace unnecessary ToString call
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-10-19 16:42:07 +09:00
Dean Herbert
c97cfdd978
Merge branch 'master' into localise-toasts
2021-10-19 16:37:14 +09:00
Dean Herbert
59202d27c7
Add some missing labels
2021-10-12 15:09:59 +09:00
Joseph Madamba
4fc84e71cd
Localise more toast related strings
2021-10-11 01:02:26 -07:00
Joseph Madamba
4b01c23c11
Track ui scale setting
2021-10-10 19:55:02 -07:00
Joseph Madamba
545cfc7bf1
Localise tracked setting toasts
2021-10-10 19:35:25 -07:00
Dean Herbert
4f1db5af40
Attach migration memo to DatabasedSetting class for visibility
2021-09-15 17:25:07 +09:00
Dean Herbert
a1d325cb22
Mark key and value non-nullable (at realm end) and simplify Value logic
2021-09-15 17:16:05 +09:00
Dean Herbert
a150fb2996
Add nullability directive and make variant non-nullable
2021-09-15 17:16:05 +09:00
Dean Herbert
dcfe9c67e3
Make ruleset id non-nullable
2021-09-15 17:12:04 +09:00
Dean Herbert
80ecf81be3
Rename all databased setting classes to be specific to rulesets for now
2021-09-15 17:12:04 +09:00
Dean Herbert
520e550764
Bring back SettingsStore to avoid changing ruleset API for now
...
Also fixes some remaining test failures due to locally constructed
rulesets that are not being tracked by the game.
2021-09-15 17:12:02 +09:00
Dean Herbert
ac377a2e3c
Remove unused SettingsStore
2021-09-15 16:31:13 +09:00
Dean Herbert
a2f1752344
Make settings works with current caching structure
...
Will likely pull out that `RulesetConfigCache` next, but this is an
"everything works" state.
2021-09-15 16:31:13 +09:00
Dean Herbert
187c557ea8
Begin migrating settings implementation across to realm
2021-09-15 16:22:14 +09:00
Dean Herbert
41a2e6eeeb
Fix cache not actually caching anything
2021-09-09 14:56:39 +09:00
Dean Herbert
a622a0b660
Use a more traditional method of caching
2021-09-08 23:18:17 +09:00
Dean Herbert
81c9d831f4
Cache reflection portion of SettingSource lookups
...
Fixes the mod-related overhead portion of https://github.com/ppy/osu/issues/14638 . There's still a significant performance issue that will be addressed separately.
2021-09-08 13:26:11 +09:00
Dean Herbert
71fab416d8
Add a note against OsuSetting
2021-08-16 16:59:59 +09:00
