67049 Commits

This Branch

This Branch

All Branches

• Temporary rollback of framework / SDL3
  Dean Herbert · 2024-05-21 14:36:16 +08:00
  2024.521.1 d7d569cf4e
• Fix single frame glitching in skin editor

  https://github.com/ppy/osu/pull/28257#discussion_r1606999574

  Dean Herbert · 2024-05-21 14:36:11 +08:00
  e740b8bcc3
• Merge pull request #28257 from bdach/fix-skin-editor-spaz

  Fix closest anchor selection spazzing out in multiple scenarios

  Dean Herbert · 2024-05-21 14:35:29 +08:00
  3b86da443b
• Merge pull request #28228 from Susko3/show-mouse-joystick-settings-mobile

  Show mouse and joystick settings on mobile

  Dan Balasescu · 2024-05-20 21:49:27 +09:00
  e6baa06f2e
• Merge pull request #28260 from bdach/discord-rpc-i-swear-to-god

  Fix unnecessary padding of empty strings for discord RPC purposes

  Dan Balasescu · 2024-05-20 20:36:07 +09:00
  2aa9328830
• Merge pull request #28235 from tsunyoku/optimise-rhythm-evaluator-loop-logic

  Reduce `Previous` calls in `RhythmEvaluator` by optimising loop logic

  Dan Balasescu · 2024-05-20 20:31:46 +09:00
  976c6c4f25
• Fix unnecessary padding of empty strings for discord RPC purposes

  Closes https://github.com/ppy/osu/issues/28248.
  
  Destroy all software.

  Bartłomiej Dach · 2024-05-20 11:37:35 +02:00
  fe0af7e720
• Improve closest origin selection to include effects of rotation/flip

  Closes https://github.com/ppy/osu/issues/28237.
  
  Solution as proposed here:
  https://github.com/ppy/osu/pull/28089#issuecomment-2095372157
  
  For flips and rotations by 90 degrees this does what you would expect it
  to. For arbitrary rotations it *sort of kind of* attempts to do this but
  the results are a bit wonky - probably still better than what was there
  before, though?

  Bartłomiej Dach · 2024-05-20 10:23:12 +02:00
  3da3b91be5
• Fix skin editor closest origin selection spazzing out on scaled sprites

  Closes https://github.com/ppy/osu/issues/28215.
  
  `drawable.Position` is a location in the parent's coordinate space, and
  `drawable.OriginPosition` is in the drawable's local space and
  additionally does not take scale into account.

  Bartłomiej Dach · 2024-05-20 10:23:07 +02:00
  c03f68413a
• Merge pull request #28230 from tsunyoku/remove-extra-rhythm-previous-calls

  Remove unneeded `Previous` calls from `RhythmEvaluator`

  Dan Balasescu · 2024-05-20 04:37:14 +09:00
  dedc2d2aa0
• Reduce Previous calls in RhythmEvaluator by optimising loop logic
  James Wilson · 2024-05-19 16:26:51 +01:00
  f31928875b
• remove unneeded extra Previous calls from RhythmEvaluator
  James Wilson · 2024-05-19 13:29:49 +01:00
  609268786f
• Don't show warning on android

  Unsure about iOS.

  Susko3 · 2024-05-19 14:12:21 +02:00
  04acc58b74
• Show mouse and joystick settings on mobile
  Susko3 · 2024-05-19 14:07:40 +02:00
  e4858a975d
• Merge pull request #28213 from bdach/fix-realm-migration-fail

  Fix total score without mods migration failing on custom ruleset scores when custom ruleset cannot be loaded

  Dean Herbert · 2024-05-19 15:55:36 +08:00
  2024.519.1 5e1f6964d1
• Fix total score without mods migration failing on custom ruleset scores when custom ruleset cannot be loaded

  Closes https://github.com/ppy/osu/issues/28209.
  
  Yes this means that such scores will have a zero total score without
  mods in DB and thus might up getting their total recalculated to zero
  when we try a mod multiplier rebalance (unless we skip scores with zero
  completely I suppose). I also don't really care about that right now.

  Bartłomiej Dach · 2024-05-19 09:43:33 +02:00
  be642c8c42
• Merge pull request #28201 from frenzibyte/fix-settings-padding

  Fix checkboxes looking misaligned when placed next to a slider bar

  Dean Herbert · 2024-05-19 10:36:54 +08:00
  2024.519.0 9fcd3b562a
• Merge pull request #28205 from EVAST9919/control-point-nesting

  Reduce container nesting inside `PathControlPointPiece`

  Dean Herbert · 2024-05-19 08:37:57 +08:00
  9c559d91f1
• Reduce container nesting in PathControlPointPiece
  Andrei Zavatski · 2024-05-18 22:51:58 +03:00
  614cbdf0a4
• Merge pull request #28182 from frenzibyte/footer-v2-renamings

  Rename and move new footer classes to appropriate places

  Dean Herbert · 2024-05-18 22:14:45 +08:00
  7b847ad815
• Fix checkboxes applying extra padding
  Salman Ahmed · 2024-05-18 11:06:29 +03:00
  a912e56ca9
• Merge pull request #28198 from frenzibyte/remove-warnaserror-from-local-builds

  Remove `TreatWarningsAsErrors` flags from local builds for developer convenience

  Dan Balasescu · 2024-05-18 13:40:11 +09:00
  9532725eb7
• Remove TreatWarningsAsErrors flags from local builds for developer convenience
  Salman Ahmed · 2024-05-18 06:38:25 +03:00
  2027d481ee
• Merge pull request #28191 from bdach/fix-mismatching-localisation-xmldoc

  Fix xmldoc mismatches in localisation files

  Bartłomiej Dach · 2024-05-17 09:22:55 +02:00
  badda23dde
• Merge branch 'master' into fix-mismatching-localisation-xmldoc
  Bartłomiej Dach · 2024-05-17 08:47:14 +02:00
  e604a99053
• Bump once more
  Dan Balasescu · 2024-05-17 11:15:17 +09:00
  2f9d74286d
• Merge pull request #28190 from bdach/fix-duped-translation-keys

  Fix duplicated localisation key in `DeleteConfirmationContentStrings`

  Dan Balasescu · 2024-05-17 11:03:15 +09:00
  06d6df95de
• Merge pull request #28193 from bdach/what-is-discord-doing

  Fix discord arbitrarily refusing to work on "too short" strings

  Dan Balasescu · 2024-05-17 11:01:36 +09:00
  a2e67ee699
• Fix discord arbitrarily refusing to work on "too short" strings

  Closes https://github.com/ppy/osu/issues/28192.

  Bartłomiej Dach · 2024-05-16 18:24:51 +02:00
  a3dfd99f7d
• Fix xmldoc mismatches in localisation files

  This is enforced by the localisation analyser after
  https://github.com/ppy/osu-localisation-analyser/pull/62, but it appears
  the analyser was never actually bumped game-side after that change and
  I'm not super sure why, as there does not appear to be a reason to _not_
  do that. So this commit does it.

  Bartłomiej Dach · 2024-05-16 17:39:27 +02:00
  f2f03f08cb
• Fix duplicated localisation key in DeleteConfiormationContentStrings

  Noticed via `osu-resources` build warnings.
  
  There are also a few other warnings about
  https://github.com/ppy/osu/pull/27472. Seems something in crowdin
  innards may still be exporting those strings even though they have been
  fixed already. Not sure how to address that.
  
  Probably need these to be detected via static analysis at this point
  since it's happened again. Might look into the feasibility of making
  that happen.

  Bartłomiej Dach · 2024-05-16 14:49:56 +02:00
  5dd64a7c86
• Merge pull request #28186 from bdach/revert-wide-columns-on-mobile
  Dean Herbert · 2024-05-16 19:15:35 +08:00
  f9fd1b957f
• Do not change mania column width on mobile platforms

  - Closes https://github.com/ppy/osu/issues/25852
  - Reverts https://github.com/ppy/osu/pull/25336 /
    https://github.com/ppy/osu/pull/25777
  
  With the columns not being directly touchable anymore after
  https://github.com/ppy/osu/pull/28173 I see very little point to this
  continuing to exist.

  Bartłomiej Dach · 2024-05-16 08:21:52 +02:00
  97de73b99c
• Rename and move footer classes to appropriate places
  Salman Ahmed · 2024-05-16 04:41:16 +03:00
  21f5d891bb
• Add inline comment explaining LifetimeEnd set for future visitors
  Dean Herbert · 2024-05-15 14:17:28 +08:00
  a3960bf715
• Merge pull request #28173 from peppy/mania-touch-input-revised

  Add more usable osu!mania touch input system

  Bartłomiej Dach · 2024-05-14 19:28:48 +02:00
  d52dffefbc
• Merge pull request #28170 from peppy/fix-catch-dho-performance

  Set a rudimentary lifetime end to improve seek performance in scrolling rulesets

  Bartłomiej Dach · 2024-05-14 19:27:40 +02:00
  7c1640e124
• Remove redundant cast
  Bartłomiej Dach · 2024-05-14 18:41:15 +02:00
  3d190f7e88
• Merge pull request #28174 from peppy/load-while-logo-drag

  Continue loading even when osu! logo is being dragged at loading screen

  Bartłomiej Dach · 2024-05-14 18:39:03 +02:00
  dae1686e7b
• Continue loading even when osu! logo is being dragged at loading screen

  Closes https://github.com/ppy/osu/issues/28130.

  Dean Herbert · 2024-05-14 23:54:07 +08:00
  cff865b556
• Merge pull request #28171 from bdach/present-score-different-hashes

  Use hash rather than online ID as primary lookup key when presenting score

  Dean Herbert · 2024-05-14 23:39:54 +08:00
  c31b503f2a
• Merge pull request #28172 from bdach/nrt-results-classes

  Apply NRT to results-related components

  Dean Herbert · 2024-05-14 23:01:24 +08:00
  d74be8b920
• Remove touch mod addition to mania

  Feels a bit pointless? I dunno.

  Dean Herbert · 2024-05-14 22:38:31 +08:00
  f781dc3300
• Update tests in line with new structure
  Dean Herbert · 2024-05-14 22:34:05 +08:00
  636e200471
• Tidy class and change to be a VisibilityContainer similar to taiko implementation
  Dean Herbert · 2024-05-14 22:34:05 +08:00
  5c9a90cb40
• Rename touch area class to match existing usage (see taiko)
  Dean Herbert · 2024-05-14 22:34:05 +08:00
  390557634a
• Move out of playfield so touch overlay is not affected by playfield position
  Dean Herbert · 2024-05-14 22:34:05 +08:00
  12e98fe55d
• Apply NRT to results statistics displays
  Bartłomiej Dach · 2024-05-14 15:21:12 +02:00
  ee9144c3bd
• Apply NRT to RankText
  Bartłomiej Dach · 2024-05-14 15:21:05 +02:00
  414f023817
• Apply NRT to RankBadge
  Bartłomiej Dach · 2024-05-14 15:20:56 +02:00
  b937b94bd2