58549 Commits

This Branch

This Branch

All Branches

• Fix beatmaps with multiple osb files potentially reading the storyboard from the wrong one

  In stable, the storyboard filename is fixed. In lazer, we were always
  looking for the first `.osb` in the database. In the case a beatmap
  archive housed more than one `.osb` files, this may load the incorrect
  one.
  
  Using `GetDisplayString` here feels like it could potentially go wrong
  in the future, so I'm open to hard-coding this locally (or using string
  manipulation to remove the ` [creator_name]` portion of the beatmap's
  filename). Open to opinions on that.
  
  Fixes storyboard playback in https://osu.ppy.sh/beatmapsets/1913687#osu/3947758

  Dean Herbert · 2023-01-25 17:11:15 +09:00
  d15f8c2f3a
• Merge pull request #22318 from naoey/fix-copy-difficulty-moving-collections

  Fix creating a copy of a difficulty in the editor removing the original beatmap from user collections

  Dean Herbert · 2023-01-25 15:06:46 +09:00
  4674956ccf
• Merge pull request #22383 from jai-x/wikimarkdown-update-tests

  Update `WikiMarkdownContainer` tests

  Dean Herbert · 2023-01-25 14:20:47 +09:00
  73d7043201
• Merge branch 'master' into fix-copy-difficulty-moving-collections
  Dean Herbert · 2023-01-25 14:11:32 +09:00
  6efab635d8
• Reword comment regarding hash transfer to make more sense
  Dean Herbert · 2023-01-25 14:11:02 +09:00
  392ff2ffea
• Make transferCollections argument to private method explicitly required
  Dean Herbert · 2023-01-25 14:09:13 +09:00
  741ca96853
• Add argument hint for nondescript bool

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2023-01-25 14:04:30 +09:00
  739ec8d81d
• Merge pull request #22325 from sw1tchbl4d3r/sv_scaling

  Move fixed scroll speed change out of classic mod for taiko

  Dean Herbert · 2023-01-25 12:55:43 +09:00
  b182178340
• Merge pull request #22400 from frenzibyte/fix-ios-ci

  Fix iOS workflow still targeting old Xcode version

  Dean Herbert · 2023-01-25 10:30:23 +09:00
  7e9b3fb253
• Fix iOS workflow still targeting old Xcode version
  Salman Ahmed · 2023-01-25 02:15:08 +03:00
  4d4dfd9e8b
• Revert a few more relative to absolute changes

  Because not sure why they were changed in the first place.

  Bartłomiej Dach · 2023-01-25 00:00:23 +01:00
  a3bb6d1fab
• Fix TestAbsoluteImage() no longer actually testing absolute image URL
  Bartłomiej Dach · 2023-01-24 23:58:39 +01:00
  4d7cd59df3
• TestSceneWikiMarkdownContainer: Revert CurrentPath changes and update markdown img links only
  Jai Sharma · 2023-01-24 22:01:53 +00:00
  c991aa5ca4
• Merge pull request #22385 from peppy/touchscreen-settings-keyword

  Fix touch input handler settings not matching search for "touchscreen"

  Bartłomiej Dach · 2023-01-24 20:50:53 +01:00
  edb9c76edf
• Merge pull request #22387 from peppy/beatmap-leaderboard-cancel-request-eagerly

  Fix beatmap leaderboard potentially showing incorrect leaderboard

  Bartłomiej Dach · 2023-01-24 19:49:11 +01:00
  054938be02
• Merge pull request #22390 from Joehuu/fix-changelog-depth

  Fix changelog overlay potentially showing up behind mod select overlay

  Dean Herbert · 2023-01-24 18:35:00 +09:00
  d56f528a3d
• Change some order and assert for positive visibility before scheduling an operation in changelog overlay
  Dean Herbert · 2023-01-24 17:59:25 +09:00
  b9291cb116
• Remove IsPresent override from ChangelogOverlay
  Joseph Madamba · 2023-01-24 00:22:29 -08:00
  c6bf755e68
• Always make settings footer build display clickable
  Joseph Madamba · 2023-01-24 00:21:39 -08:00
  df895c4fd6
• Merge pull request #18402 from ggliv/mod-accuracy-challenge

  Add accuracy challenge mod

  Dean Herbert · 2023-01-24 16:00:55 +09:00
  a966d6c330
• increase min minimum accuracy to 60%
  Gabe Livengood · 2023-01-24 00:31:46 -05:00
  b46ef67a14
• Fix beatmap leaderboard potentially showing incorrect leaderboard
  Dean Herbert · 2023-01-24 13:52:59 +09:00
  bb15ee50e0
• Merge pull request #22265 from Wleter/SliderEnd-Snap

  Add snapping sliderends with nearby objects

  Dean Herbert · 2023-01-24 13:43:43 +09:00
  3cd810f332
• Fix touch input handler settings not matching search for "touchscreen"
  Dean Herbert · 2023-01-24 13:37:12 +09:00
  fc558278cc
• Merge pull request #22381 from Susko3/fix-osu-touch-with-screen-scaling

  Fix touches not being handled outside `OsuTouchInputMapper` when using screen scaling

  Dean Herbert · 2023-01-24 11:07:11 +09:00
  bc717b1f25
• Add commentary as to why ReceivePositionalInputAt override is required
  Dean Herbert · 2023-01-24 11:06:54 +09:00
  949610c8a4
• TestSceneWikiMarkdownContainer: Add visual test for inline and fenced code syntax
  Jai Sharma · 2023-01-24 00:53:45 +00:00
  2454eb8cd9
• TestSceneWikiMarkdowContainer: Update image paths
  Jai Sharma · 2023-01-24 00:51:07 +00:00
  f067a84631
• Revert split and make collections boolean internal to BeatmapManager
  naoey · 2023-01-24 07:27:26 +09:00
  e6de167adb
• Fix OsuTouchInputMapper not handling all touches when using screen scaling
  Susko3 · 2023-01-23 21:46:01 +01:00
  a992682276
• Merge branch 'master' into SliderEnd-Snap
  Bartłomiej Dach · 2023-01-23 21:33:16 +01:00
  7483967157
• Clean up xmldocs
  Bartłomiej Dach · 2023-01-23 21:22:18 +01:00
  1f40b2daf6
• Merge pull request #22371 from peppy/more-settings-keywords

  Add more keywords to settings based on feedback

  Bartłomiej Dach · 2023-01-23 20:19:53 +01:00
  9f2ed853eb
• Merge pull request #22277 from stanriders/level-badge-colour

  Add tiered level badge colouring

  Dean Herbert · 2023-01-23 16:21:28 +09:00
  d695214ae1
• Merge branch 'master' into level-badge-colour
  Dean Herbert · 2023-01-23 15:46:15 +09:00
  432e0a6a37
• Fix test scene potentially overflowing visible region
  Dean Herbert · 2023-01-23 15:45:44 +09:00
  736965e009
• Rename fetch method to be non-plural to match all others
  Dean Herbert · 2023-01-23 15:43:52 +09:00
  9c2494383f
• Merge pull request #22032 from frenzibyte/fix-potential-difficulty-failure-alt

  Fix advanced statistics display potentially performing invalid difficulty calculation

  Dean Herbert · 2023-01-23 15:39:47 +09:00
  e3932c077b
• Add more keywords to settings based on feedback
  Dean Herbert · 2023-01-23 15:14:16 +09:00
  7ebd31d42f
• Add support for externally specified keywords in SettingsButtons
  Dean Herbert · 2023-01-23 15:10:26 +09:00
  2ed9fe3747
• Refactor how additional points are provided to avoid confusion
  Dean Herbert · 2023-01-23 14:13:46 +09:00
  73f083a316
• Merge pull request #22340 from EXtremeExploit/groups-modes

  Add modes text to groups tooltip

  Dean Herbert · 2023-01-23 01:10:25 +09:00
  2023.123.0 f87bb589a2
• Merge pull request #22339 from shinobu-uwu/fix-fail-sample-playing-after-leaving-dialog

  Fix skin fail sound continuing to play after leaving gameplay

  Dean Herbert · 2023-01-22 22:27:26 +09:00
  9a89dfb7d1
• Merge branch 'master' into groups-modes
  Bartłomiej Dach · 2023-01-22 10:09:34 +01:00
  e1acf85bb3
• Privatise setter
  Bartłomiej Dach · 2023-01-22 10:09:08 +01:00
  9bde1ef9bf
• Fix code quality inspection
  Bartłomiej Dach · 2023-01-22 10:07:47 +01:00
  b98da506c1
• Merge branch 'master' into fix-fail-sample-playing-after-leaving-dialog
  Bartłomiej Dach · 2023-01-22 09:35:37 +01:00
  31e7d7333b
• Rename Stop{SampleAndRemoveFilters -> }()

  Now that just one method for stopping samples is left, let's just
  repurpose st as the general "stop global effects" method rather than
  have it there with a hyperspecific name. It also has good symmetry, as
  there already was a `Start()` method in the class.

  Bartłomiej Dach · 2023-01-22 09:29:22 +01:00
  06aa3f7798
• Inline StopSample() into StopSampleAndRemoveFilters()

  The first method no longer has any callers except for the second one.

  Bartłomiej Dach · 2023-01-22 09:26:01 +01:00
  9e4e85e3e3
• Remove unnecessary sample stop in Restart()

  It is unnecessary, as a successful restart will exit the current player
  screen, and `OnExiting()` has another `StopSampleAndRemoveFilters()`
  call, which means that in the restart flow the sample was actually
  getting stopped twice.
  
  Standard exit flow is fine, it only stopped the sample once.

  Bartłomiej Dach · 2023-01-22 09:24:12 +01:00
  0edfd24410