1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-14 04:17:25 +08:00
Commit Graph

66617 Commits

Author SHA1 Message Date
Joseph Madamba
d08b1e5ae7 Add xmldoc to GetScore() and Export() and remove xmldoc from private getDatabasedScoreInfo() 2024-04-17 21:52:36 -07:00
Joseph Madamba
514e316b49 Make getDatabasedScoreInfo() private and move to GetScore() and Export() 2024-04-15 20:48:51 -07:00
Joseph Madamba
67cfcddc77 Use another beatmap query to not depend on databased score info 2024-04-15 20:18:24 -07:00
Joseph Madamba
ed8b596325 Fix replay export not working correctly from online leaderboards 2024-04-14 16:22:58 -07:00
Joseph Madamba
f282152f99 Enable NRT to ScoreManager 2024-04-14 15:53:29 -07:00
Dan Balasescu
d34834af05
Merge pull request #27853 from Drison64/mask-volume-bar
Fix toolbar volume bar masking
2024-04-15 03:36:31 +09:00
Ondřej Vajďák
ed6680a61d Fixed type inconsistency and rounding 2024-04-14 15:10:05 +02:00
Ondřej Vajďák
9833dd955f Fix toolbar volume bar masking 2024-04-14 01:30:59 +02:00
Dan Balasescu
e14e2a4629
Merge pull request #27845 from Loreos7/beatmap_hash
Fix missing underscore in `invalid beatmap_hash` notification message
2024-04-13 21:16:55 +09:00
Loreos7
5a8b8908dd fix missing underscore 2024-04-13 14:53:51 +03:00
Dean Herbert
b7b3401b34
Merge pull request #27839 from smoogipoo/fix-macos-crash
Fix crash when entering multiplayer on macOS
2024-04-13 12:54:00 +08:00
Dan Balasescu
c7f3a599c9
Fix crash when entering multiplayer on macOS 2024-04-13 13:17:06 +09:00
Dan Balasescu
3793a552b8
Merge pull request #27832 from peppy/skin-editor-new-items-apply
Fix newly placed items in skin editor not getting correct anchor placement
2024-04-12 21:00:52 +09:00
Dean Herbert
c0dce94f15
Fix newly placed items in skin editor not getting correct anchor placement 2024-04-12 17:08:49 +08:00
Dean Herbert
da1a07fb45
Merge pull request #27827 from smoogipoo/fix-ios-build
Update Sentry to fix iOS build
2024-04-12 08:48:12 +08:00
Dean Herbert
3ec93745a4
Fix test failures due to sentry oversight 2024-04-12 01:10:42 +08:00
Dan Balasescu
8b2017be45
Update Sentry to fix iOS build 2024-04-12 01:02:40 +09:00
Dean Herbert
3e8ddbd2a9
Add new entries to dotsettings (Rider 2024.1) 2024-04-11 11:33:16 +08:00
Bartłomiej Dach
b559bec49f
Merge pull request #27734 from smoogipoo/fix-catmull-bulbs
Fix bulbs on Catmull sliders
2024-04-10 11:49:29 +02:00
Bartłomiej Dach
518addf323
Merge branch 'master' into fix-catmull-bulbs 2024-04-10 11:25:02 +02:00
Dean Herbert
6cb5bffdfc
Update resources 2024-04-10 13:03:37 +08:00
Dean Herbert
6c5fad8638
Merge pull request #27810 from smoogipoo/fix-discord-rpc-crash
Fix possible crash due to race in DiscordRichPresence
2024-04-08 23:37:44 +08:00
Dan Balasescu
7d8fe51178
Fix possible crash due to race in DiscordRichPresence 2024-04-08 23:33:42 +09:00
Bartłomiej Dach
b226a05637
Merge pull request #27787 from peppy/update-hit-error-icons
Update hit error metre to use new icons
2024-04-05 09:58:12 +02:00
Bartłomiej Dach
d6b1e68ee7
Merge branch 'master' into update-hit-error-icons 2024-04-05 09:36:18 +02:00
Dean Herbert
6093b50641
Merge pull request #27797 from smoogipoo/revert-storyboard-optimisation
Revert recent storyboard optimisations
2024-04-05 14:56:44 +08:00
Dan Balasescu
7b92c725b1
Revert "Merge pull request #27454 from EVAST9919/sb-lifetime-improvements"
This reverts commit 0881e7c8c1, reversing
changes made to 29a37e3585.
2024-04-05 14:45:49 +09:00
Dean Herbert
673882f64b
Merge pull request #27789 from smoogipoo/disable-discord-uri-macos
Disable Discord URI registration on macOS for now
2024-04-04 15:58:19 +08:00
Dan Balasescu
fb8fb4f34e
Disable Discord URI registration on macOS for now 2024-04-04 16:43:26 +09:00
Dean Herbert
6ec5c1d7e2
Merge pull request #27788 from smoogipoo/update-framework
Update osu.Framework package
2024-04-04 15:18:23 +08:00
Dean Herbert
10d1308a0a
Update resources 2024-04-04 15:05:59 +08:00
Dan Balasescu
cd474de61f
Update osu.Framework package 2024-04-04 15:55:05 +09:00
Dean Herbert
9521c1e3e4
Update hit error metre to use new icons
- [ ] Depends on https://github.com/ppy/osu-resources/pull/317.
2024-04-04 14:31:40 +08:00
Dean Herbert
2e1d63a1c2
Merge pull request #27783 from 64ArthurAraujo/add-invalid-beatmap-hash-custom-message
Add custom message in the case of a `invalid beatmap_hash`
2024-04-04 10:47:22 +08:00
Arthur Araujo
9e92ebaa43
Make message more general
Co-authored-by: Walavouchey <36758269+Walavouchey@users.noreply.github.com>
2024-04-03 19:15:22 -03:00
Dean Herbert
2f64c16088
Merge pull request #27784 from bdach/double-skip-yet-again
Fix some maps requiring multiple intro skips that weren't there on stable
2024-04-04 04:14:03 +08:00
Arthur Araujo
8e00368f7c Add custom message in the case of a invalid beatmap_hash 2024-04-03 11:30:14 -03:00
Bartłomiej Dach
9d54f1a092
Fix some maps requiring multiple intro skips that weren't there on stable
Closes https://github.com/ppy/osu/issues/25633.

The reason why that particular beatmap did not have a double skip
on stable is here:

    e53980dd76/osu!/GameModes/Play/Player.cs#L1761-L1770

The particular place of interest is the `leadInTime < 10000` check.
If `leadInTime < 10000`, then `leadIn == leadInTime`, and it turns out
that `AudioEngine.Time` will always be more than or equal to `leadIn`,
because it's also the gameplay start time:

    e53980dd76/osu!/GameModes/Play/Player.cs#L2765

This essentially means that if the `leadInTime` is less than 10000,
that particular check is just dead. So a double skip can only occur
if the gameplay starts at time -10000 or earlier due to the storyboard.
2024-04-03 16:12:20 +02:00
Bartłomiej Dach
524a5815bc
Add test coverage 2024-04-03 16:11:40 +02:00
Bartłomiej Dach
ca525f6a91
Merge pull request #27779 from smoogipoo/fix-skineditor-external-event-bind
Fix SkinEditor binding event to external bindable
2024-04-03 12:05:41 +02:00
Bartłomiej Dach
6d6412afdf
Merge branch 'master' into fix-skineditor-external-event-bind 2024-04-03 11:42:15 +02:00
Bartłomiej Dach
05fe8968d8
Only interact with clipboard via bound copy 2024-04-03 11:39:12 +02:00
Bartłomiej Dach
3b7d427c52
Merge pull request #27778 from smoogipoo/fix-spectator-player-rentention
Fix SpectatorClient holding references to Player
2024-04-03 11:30:34 +02:00
Dan Balasescu
ce68f6adb7
Fix SkinEditor binding event to external bindable 2024-04-03 17:46:26 +09:00
Dan Balasescu
b5adcf2e0e
Fix SpectatorClient holding references to Player 2024-04-03 17:32:02 +09:00
Bartłomiej Dach
fd9b890a94
Merge pull request #27747 from smoogipoo/mania-key-count-mod-query
Consider keymods in beatmap filtering + panel display
2024-04-03 09:49:35 +02:00
Bartłomiej Dach
cb82fb0487
Merge branch 'master' into mania-key-count-mod-query 2024-04-03 09:29:32 +02:00
Dean Herbert
94cbe1838f
Replace usages of is null with == null 2024-04-03 01:50:39 +08:00
Dean Herbert
aa7b357063
Merge pull request #27768 from 64ArthurAraujo/editor-fix-sliders-same-start-time-merge
Fix merging sliders with the same `StartTime` causing a Unhandled Exception
2024-04-03 01:45:55 +08:00
Arthur Araujo
9315aefe41 Fix remove additional blank line 2024-04-02 08:48:01 -03:00