57159 Commits

This Branch

This Branch

All Branches

• Always use current timing point for circle piece animation

  Using `LifetimeStart` seemed arbitrary and wrong not only in a
  compatibility-with-stable sense, but also in a general sanity sense (why
  would each object potentially be using a different timing point to
  animate?)

  Bartłomiej Dach · 2022-11-22 20:39:22 +01:00
  ce7af0df63
• Split animation logic to its own method

  Also add a guard, to bypass all of it if the foreground layer is not in
  fact animatable.

  Bartłomiej Dach · 2022-11-22 20:39:05 +01:00
  38f2a27f53
• Set combo immediately rather than via repeat steps

  Doesn't help anyone to be waiting literal minutes for combo to hit 50 or
  150 in a test scene supposed to quickly visually demonstrate a
  component. Doesn't help for CI runtime, either.

  Bartłomiej Dach · 2022-11-22 20:30:27 +01:00
  8ac0a759f0
• Restructure tests not to call each other

  Bit weird to have tests call other tests. Private helper methods is
  better, if unavoidable.

  Bartłomiej Dach · 2022-11-22 20:28:41 +01:00
  5a5b0ed4ef
• Add tests and clean up inefficient code
  Joppe27 · 2022-11-22 17:22:34 +01:00
  db34fa99b1
• Add legacy circle piece animations based on combo
  Joppe27 · 2022-11-22 17:22:00 +01:00
  5343f6922c
• Merge pull request #21371 from peppy/fix-mania-hold-note-stuck

  Fix osu!mania hold notes occasionally getting in a visually incorrect hit state

  Dan Balasescu · 2022-11-22 17:14:39 +09:00
  2e4dc7c467
• Fix osu!mania hold notes occasionally getting in a visually incorrect hit state

  To correctly end a mania hold note, `endHold()` needs to be called. This
  was not happening in a very specific scenario:
  
  - The hold note's head is not hit
  - The user pressed the column's key within the hold note's tail's window,
    but does so to hit the next object (a note in proximity to the hold note's tail).
  - The hit policy forces a miss on the hold note, but `endHold()` is not called
  - `CheckForResult` is not called after this point due to `Judged` being `true`.
  
  Closes #21311.

  Dean Herbert · 2022-11-22 16:15:34 +09:00
  57723107dd
• Merge pull request #21366 from bdach/broken-rank-graph-test

  Fix broken rank graph test

  Dan Balasescu · 2022-11-22 14:35:14 +09:00
  6b75f529c7
• Merge pull request #21356 from peppy/standardise-broken-storyboard-paths

  Add support for storyboards with incorrect path specifications (`\\` instead of `\`)

  Dan Balasescu · 2022-11-22 14:33:51 +09:00
  985781bc3b
• Merge pull request #21344 from peppy/tablet-settings-test-scene

  Fix `TestSceneTabletSettings` falling off the bottom of the screen

  Bartłomiej Dach · 2022-11-21 21:46:15 +01:00
  cd43e83494
• Fix rank graphs not showing in test due to unset IsRanked
  Bartłomiej Dach · 2022-11-21 21:00:06 +01:00
  41039340cf
• Add failing assertions
  Bartłomiej Dach · 2022-11-21 20:58:52 +01:00
  1777a60136
• Rewrite rank graph test to use more modern style
  Bartłomiej Dach · 2022-11-21 20:56:38 +01:00
  735cac3104
• Merge branch 'master' into tablet-settings-test-scene
  Bartłomiej Dach · 2022-11-21 20:42:04 +01:00
  f36ccab84e
• Merge pull request #21346 from peppy/higher-aspect-ratio-max

  Increase maximum aspect ratio for tablet settings to 23:9 / 2.55

  Bartłomiej Dach · 2022-11-21 20:41:47 +01:00
  4490504104
• Merge branch 'master' into higher-aspect-ratio-max
  Bartłomiej Dach · 2022-11-21 19:51:39 +01:00
  8dbe31a172
• Merge pull request #21350 from peppy/hide-no-spin-bonus

  Hide spinner ticks / bonus from results screen when not applicable to score

  Bartłomiej Dach · 2022-11-21 19:50:56 +01:00
  f75353d8f4
• Fix weird scroll container sizing
  Bartłomiej Dach · 2022-11-21 19:27:06 +01:00
  ff5cb116f0
• Merge branch 'master' into hide-no-spin-bonus
  Bartłomiej Dach · 2022-11-21 19:14:54 +01:00
  c0f65d83b3
• Merge pull request #21360 from peppy/mania-argon-hold-better

  Realign white line on argon hold note ends to match hit target

  Bartłomiej Dach · 2022-11-21 18:53:05 +01:00
  c79841dad2
• Merge branch 'master' into mania-argon-hold-better
  Bartłomiej Dach · 2022-11-21 18:17:35 +01:00
  c805eb330a
• Merge pull request #21352 from peppy/avoid-null-audio-device-name-crahs

  Avoid crashing when a system audio device provides a `null` name

  Bartłomiej Dach · 2022-11-21 17:16:30 +01:00
  d5e9cb2477
• Merge branch 'master' into avoid-null-audio-device-name-crahs
  Bartłomiej Dach · 2022-11-21 16:37:13 +01:00
  206aece77b
• Merge pull request #21304 from EVAST9919/beatmap-bar

  Rework BarGraph to use Quads

  Bartłomiej Dach · 2022-11-21 16:24:18 +01:00
  7944d9cefa
• Realign white line on argon hold note ends to match hit target
  Dean Herbert · 2022-11-21 18:26:53 +09:00
  b404b87f68
• Merge pull request #21215 from jai-x/triangles-bundled-beatmap

  Add winner of Triangles mapping competition as a bundled beatmap

  Dean Herbert · 2022-11-21 16:22:23 +09:00
  2774c1ea49
• Add support for storyboards with incorrect path specifications (\\ instead of \)

  Closes https://github.com/ppy/osu/issues/21204.

  Dean Herbert · 2022-11-21 16:12:01 +09:00
  3da21e596a
• Avoid crashing when a system audio device provides a null name
  Dean Herbert · 2022-11-21 14:51:41 +09:00
  981264b011
• Hide spinner ticks / bonus from results screen when not applicable to score
  Dean Herbert · 2022-11-21 14:20:36 +09:00
  93a189603a
• Merge pull request #21338 from RATCM/fix-leaderboard-filter

  Match leaderboard filter behaviour to web

  Dean Herbert · 2022-11-21 14:01:55 +09:00
  4a79141824
• Merge pull request #21326 from bdach/fix-phantom-beatmap-sets

  Fix phantom beatmap sets appearing on carousel after delete/update

  Dean Herbert · 2022-11-21 13:25:14 +09:00
  dfa92b3de9
• Increase maximum aspect ratio for tablet settings to 23:9 / 2.55
  Dean Herbert · 2022-11-21 12:45:54 +09:00
  c7ae837687
• Merge pull request #21340 from vegguid/MetadataLanguage-FirstSetup

  Added PreferOriginalMetadataLanguage to FirstRunSetup

  Dean Herbert · 2022-11-21 12:16:56 +09:00
  92aea22cd3
• Fix TestSceneTabletSettings falling off the bottom of the screen
  Dean Herbert · 2022-11-21 12:15:43 +09:00
  d0ff5be7e6
• Merge pull request #21343 from goodtrailer/nonsquare-smoke

  Add support for nonsquare smoke textures

  Dean Herbert · 2022-11-21 12:06:49 +09:00
  85167d8de6
• Add support for nonsquare smoke textures
  Alden Wu · 2022-11-20 16:50:15 -08:00
  815cd56f13
• Added PreferOriginalMetadataLanguage to FirstRunSetup
  vegguid · 2022-11-20 23:18:19 +01:00
  a431b793b9
• Move all the logic into BarsInfo class
  Andrei Zavatski · 2022-11-20 23:00:13 +03:00
  18c79dfda3
• Changed comments
  RATCM · 2022-11-20 19:27:40 +01:00
  f5fbb7c8de
• Fixed ordering bug
  RATCM · 2022-11-20 19:24:51 +01:00
  d20a357c0e
• Match leaderboard filter behaviour to web
  RATCM · 2022-11-20 17:39:46 +01:00
  9040dfbd4e
• Merge pull request #21307 from frenzibyte/disable-scroll-speed-on-osu

  Hide scroll speed control from effects section on rulesets which don't support it

  Bartłomiej Dach · 2022-11-20 16:17:55 +01:00
  1269afd0c5
• Remove unnecessary #nullable disable
  Bartłomiej Dach · 2022-11-20 15:31:51 +01:00
  0f382590e6
• Fix timing screen test scene not creating editor beatmap properly
  Salman Ahmed · 2022-11-20 15:20:35 +03:00
  793d5b117e
• Fix phantom beatmap sets appearing on carousel after delete/update

  Regressed in c40c70509e.
  
  As it turns out, `item.Item.Filtered.Value` is not the only condition
  that should be checked to determine if a carousel item should be hidden
  or not - `item.Item.State.Value != CarouselItemState.Collapsed` should
  also be true. This was even available as the `item.Item.Visible`
  convenience property, which is used in this commit.
  
  Failing to check `item.Item.State.Value` led to setting non-zero alpha
  on collapsed carousel items, leading to phantom beatmap sets appearing,
  as the alpha was set in the entire carousel's `Update()` method, thus
  firing every frame.

  Bartłomiej Dach · 2022-11-20 10:08:34 +01:00
  7b274083d3
• Add failing test case
  Bartłomiej Dach · 2022-11-20 10:07:32 +01:00
  b3667821eb
• Make BarsInfo a class
  Andrei Zavatski · 2022-11-20 05:14:07 +03:00
  36141cb2a4
• Identify scrolling rulesets using temporary DrawableRuleset instances
  Salman Ahmed · 2022-11-20 04:12:52 +03:00
  4b0ba86bd0
• Introduce IDrawableScrollingRuleset for editor consumption
  Salman Ahmed · 2022-11-20 04:11:10 +03:00
  58296bd4f0