75505 Commits

This Branch

This Branch

All Branches

• Add comment for wiggle bonus multiplier (#36373)

  It's a common mistake by newer pp dev contributors to increase the
  wiggle multiplier not knowing its at its maximum, so I added a comment
  to try to avoid more people doing it.
  
  ---------
  
  Co-authored-by: StanR <8269193+stanriders@users.noreply.github.com>

  kwotaq · 2026-01-18 13:56:23 +00:00
  cda52cdae8
• Fix legacy score base multiplier being calculated using modded difficulty values (#36209)

  Fun correctness bug.
  
  ScoreV1 multiplier uses the **nomod** peppy stars (i.e the beatmap's
  "base" HP, OD and CS) in all cases, which was generally the intention
  with this code but it passes the wrong beatmap resulting in it using
  modded values for this.
  
  Cross referenced with stable and this now results in the expected
  multipliers.
  
  Results in some very minor (<3pp from my testing) changes for HR and EZ
  scores with combo breaks.

  James Wilson · 2026-01-17 09:30:37 +00:00
  7fc24c6566
• Improve fullcombo threshold formula (#35724)

  * Implement new portion formula
  
  * Change the formula
  
  * Use base value of 5 sliders
  
  * Make the threshold harsher
  
  ---------
  
  Co-authored-by: StanR <8269193+stanriders@users.noreply.github.com>

  Givy120 · 2026-01-04 00:51:45 +05:00
  bcaf35dae7
• Change the doubletapness scaling to be more punishing on the low end of the hitwindow (#36148)
  StanR · 2025-12-29 10:11:25 +00:00
  dd261623cd
• Add HarmonicSkill (#36153)

  * Add `OsuHarmonicSkill`
  
  * Make `ProcessInternal` a sealed override
  
  * Move to main game project

  James Wilson · 2025-12-28 17:42:26 +00:00
  c6441723b3
• Extend Skill to include ObjectDifficulties (#36152)

  * Extend `Skill` to include `ObjectDifficulties`
  
  * Remove generic
  
  * Change `ObjectDifficulties` to be modifiable by children skills
  
  * Fix tests

  StanR · 2025-12-28 13:56:55 +00:00
  a07d7ad4cb
• Reduce calls to DifficultyValue where possible (#36112)
  James Wilson · 2025-12-23 00:41:24 +00:00
  d150e27381
• Use number calculated at runtime from DecayWeight (#33733)

  Replaces a constant that assumes DecayWeight == 0.9
  
  Co-authored-by: James Wilson <tsunyoku@gmail.com>
  Co-authored-by: StanR <8269193+stanriders@users.noreply.github.com>

  Nathan Corbett · 2025-12-23 00:16:01 +00:00
  6356d50f13
• change FL calc depending on HD settings (#33019)

  Co-authored-by: StanR <8269193+stanriders@users.noreply.github.com>

  Givy120 · 2025-12-23 04:50:35 +05:00
  906df15cbe
• Uses real distance in speed instead of mishandling variables (#35387)

  Co-authored-by: StanR <8269193+stanriders@users.noreply.github.com>

  Nathan Corbett · 2025-12-22 22:58:31 +00:00
  90e820b76a
• Simplify osu! star rating calculations (#36063)

  * Simplify star rating calculations
  
  * Refactor

  StanR · 2025-12-19 12:59:22 +00:00
  99daec3835
• Use DifficultyCalculationUtils.Norm (#36064)
  StanR · 2025-12-18 18:19:16 +00:00
  16c1adf0f7
• Skip score-based miss count estimation for ScoreV2 (#35962)

  * Add basic scorev2 support
  
  * Revert unnecessary score statistic changes
  
  * Fix CI
  
  * Revert changes
  
  * Disable score-based misscount for scoreV2

  Givy120 · 2025-12-13 12:29:20 +00:00
  346461ffdc
• Remove drain rate attribute (#35817)
  Givy120 · 2025-11-29 19:01:15 +00:00
  1b230b3fdd
• Reading bonus hotfix for Traceable mod (#35266)

  * Pass slider factor to visibility bonus correctly for TC
  
  * Decrease reading bonuses for TC

  James Wilson · 2025-10-13 13:34:57 +09:00
  2025.1013.0 28c846b4d9
• Quick play forward design work (#35253)

  * Remove unnecessary information from matchmaking beatmap panel
  
  * Move avatar overlay inside card for better layout
  
  * Allow higher jumping when jumping in succession
  
  * Exclude player panel avatars from masking
  
  * Adjust player panel animations a bit further
  
  * Add avatar-only display mode
  
  * Fix round warmup test not working
  
  * Remove dead test scenes
  
  * Fix edge case where users are added to not-yet-loaded card
  
  * Decouple `PlayerPanel` from `UserPanel`
  
  * Fix remaining test failure (and rename test to match new naming)

  Dean Herbert · 2025-10-13 13:28:09 +09:00
  8e36533f65
• Merge pull request #35255 from dnfd1/rotate

  Fix default origin in skin editor when rotating multiple objects

  Bartłomiej Dach · 2025-10-10 12:19:53 +02:00
  9ebc5b0a35
• Merge pull request #35252 from bdach/song-select-present-sometimes-fails

  Fix wrong beatmap shown when presenting a beatmap from results screen

  Dean Herbert · 2025-10-10 14:54:50 +09:00
  1f2928bf2f
• Add some logging when FindWithRefresh triggers a slow realm refresh
  Dean Herbert · 2025-10-10 13:36:28 +09:00
  94c7489c1c
• Merge branch 'ppy:master' into rotate
  dnfd1 · 2025-10-09 08:52:21 -07:00
  3bb6685e75
• convert origin of rotation to screen space for selections multiple objects in skin editor
  dnfd1 · 2025-10-09 08:36:01 -07:00
  e3459eccf2
• Merge pull request #35240 from bdach/song-select-preserve-selection-on-update-attempt-3

  Fix song select V2 not preserving selection after an update operation

  Dean Herbert · 2025-10-09 17:30:28 +09:00
  52f82c7e56
• Fix weird xmldoc issue

  Rider was fine with it...

  Bartłomiej Dach · 2025-10-09 10:17:55 +02:00
  3fc3a53521
• Merge pull request #35251 from smoogipoo/fix-broken-tests

  Fix test failures during individual runs

  Dean Herbert · 2025-10-09 17:09:01 +09:00
  2136d95087
• Merge pull request #35250 from smoogipoo/fix-test-leaks

  Fix test scene leaks through RealmRulesetStore/RealmAccess

  Dean Herbert · 2025-10-09 17:08:07 +09:00
  c58d13b802
• Fix wrong beatmap shown when presenting a beatmap from results screen

  - Closes https://github.com/ppy/osu/issues/35023.
  - Supersedes / closes https://github.com/ppy/osu/pull/35107.

  Bartłomiej Dach · 2025-10-09 09:52:22 +02:00
  b477790d3e
• Add test demonstrating failure scenario
  Bartłomiej Dach · 2025-10-09 09:46:32 +02:00
  e33de9b658
• Fix test failures during individual runs
  Dan Balasescu · 2025-10-09 16:34:55 +09:00
  6eaf91d31a
• Fix shift-clicking not working on extra size beatmap cards

  Was broken due to double assignment to `Action`.

  Bartłomiej Dach · 2025-10-09 08:59:26 +02:00
  6da6edd1d1
• Fix undisposed Realm subscription
  Dan Balasescu · 2025-10-09 15:56:34 +09:00
  6af5158bb4
• Fix test scene leaks through RealmRulesetStore/RealmAccess
  Dan Balasescu · 2025-10-09 15:28:15 +09:00
  79c367d208
• Merge pull request #35241 from bdach/song-select-crash-on-missing-group

  Fix carousel sometimes crashing when attempting to select next random set

  Dean Herbert · 2025-10-09 06:20:22 +09:00
  91019dcdf7
• Update framework
  Dean Herbert · 2025-10-08 23:18:35 +09:00
  422392233b
• Fix carousel sometimes crashing when attempting to select next random set

  I'm not exactly sure on the reproduction scenario here, but I have had
  switching ruleset with converts disabled crash on me a few times
  today. It appears to happen sometimes when after the switch the expanded
  group no longer exists in the set mapping, because a filter just ran and
  removed that group from set of possible groups because there'd be no
  beatmaps under it.
  
  I tried to manufacture a quick test but it's not a quick one to test
  because filtering intereference is required to reproduce, I think.
  I will try again on request but I mostly just want to get this fix out
  ASAP before I finish up for the day.

  Bartłomiej Dach · 2025-10-08 15:13:00 +02:00
  7b1e3cd537
• Fix song select V2 not preserving selection after an update operation

  Because the detached store exists and has a chance to actually
  semi-reliably intercept a beatmap update operation, I decided to try
  this. It still uses a bit of a heuristic in that it checks for
  transactions that delete and insert one beatmap each, but probably the
  best effort thus far?
  
  Notably old song select that was already doing the same thing locally to
  itself got a bit broken by this, but with some tweaking that *looks* to
  be more or less harmless I managed to get it unbroken. I'm not too
  concerned about old song select, mind, mostly just want to keep it
  *vaguely* working if I can help it.

  Bartłomiej Dach · 2025-10-08 14:42:26 +02:00
  30412ba3f2
• Merge pull request #35233 from diquoks/quick-fix/sfx-mute-on-restart

  Mute SFX when holding restart beatmap bind

  Dean Herbert · 2025-10-08 21:39:07 +09:00
  4622d39f41
• Merge pull request #35234 from diquoks/quick-fix/spinner-rpm-layering

  Fix `spinner-rpm` being layered above `spinner-spin` / `spinner-clear`

  Dean Herbert · 2025-10-08 21:21:21 +09:00
  0d5c041cac
• Merge pull request #35239 from bdach/song-select-weirdness

  Fix current beatmap set being incorrectly expanded after collapsing group with current selection

  Dean Herbert · 2025-10-08 21:19:08 +09:00
  ffe8b9f4c3
• Fix current beatmap set being incorrectly expanded after collapsing group with current selection

  Noticed in passing. See preceding commit for failure scenario.
  
  Regressed in https://github.com/ppy/osu/pull/35163.

  Bartłomiej Dach · 2025-10-08 13:42:43 +02:00
  9ba9966078
• Add failing test
  Bartłomiej Dach · 2025-10-08 13:42:31 +02:00
  f1ec04114f
• Add test assets covering correct layering of spinner SPM metre
  Bartłomiej Dach · 2025-10-08 12:39:48 +02:00
  4337046680
• Disallow zero-length sliders from specifying a non-zero number of repeats (#35220)
  Bartłomiej Dach · 2025-10-08 16:01:04 +09:00
  1a522a19f1
• Fix spinner-rpm layering
  Denis Titovets · 2025-10-07 19:01:50 +03:00
  568ddc2d2d
• Mute SFX when holding restart beatmap bind
  Denis Titovets · 2025-10-07 18:42:42 +03:00
  0ebc90462d
• Merge pull request #35029 from ppy/pp-dev

  Q3 SR & PP release

  Dean Herbert · 2025-10-07 19:07:58 +09:00
  2025.1007.0 a08f7327b1
• Merge pull request #35216 from diquoks/quick-fix/mods-deselection-diff

  Fix mods deselection difference

  Dean Herbert · 2025-10-07 18:38:40 +09:00
  533c61e719
• Invert conditional to read a bit better
  Dean Herbert · 2025-10-07 18:07:58 +09:00
  64fba9470d
• Re-remove duplicate error functions
  Dean Herbert · 2025-10-07 16:30:40 +09:00
  743a94bd22
• Merge branch 'master' into pp-dev
  Dean Herbert · 2025-10-07 16:11:54 +09:00
  bda5737135
• Merge pull request #35221 from bdach/adjust-tag-threshold

  Adjust display tag threshold to match web

  Dean Herbert · 2025-10-06 20:57:26 +09:00
  19718c706a