Dean Herbert
cad18ebc58
Reword comment to better explain what we are guarding against
2022-07-12 16:46:19 +09:00
Dean Herbert
cafe30fc4d
Fix potential crash during shutdown sequence if intro playback was aborted
...
Fixes one of the audio related `ObjectDisposedException`s
(https://sentry.ppy.sh/organizations/ppy/issues/92/events/12f282f048cb4a4fae85810e8a70b68d/?project=2&query=is%3Aunresolved&sort=freq&statsPeriod=7d ).
Ran into this while testing locally. See
`IntroScreen.ensureEventuallyArrivingAtMenu` for the related cause of
this happening (forced continuing to next screen if the intro doesn't
load in time).
2022-07-12 15:20:30 +09:00
Dean Herbert
9e40e50d93
Merge pull request #19039 from Cwazywierdo/mod-icon-colors
...
Update mod icon colors
2022-07-12 15:08:07 +09:00
Dean Herbert
779d512b44
Merge branch 'master' into mod-icon-colors
2022-07-12 14:36:55 +09:00
Dean Herbert
8dbe24fd7c
Simplify colour assigning logic and remove system mod colour for now
2022-07-12 14:36:50 +09:00
Dean Herbert
90fecbc9c7
Add test showing all mod icons for reference
2022-07-12 14:32:39 +09:00
Dean Herbert
aac3c166de
Merge pull request #19038 from novialriptide/replay-user-bug-fix
...
Populate user ID for locally imported scores
2022-07-12 13:55:11 +09:00
Dan Balasescu
d82d50e308
Merge pull request #19065 from Ludio235/master
...
Fix playlist room creation screen pushing content on opening dropdowns
2022-07-12 13:22:38 +09:00
Dan Balasescu
3ca10ac02c
Merge pull request #19063 from Joehuu/fix-samples-cancel-exit
...
Fix editor playing object samples while paused after cancelling exit
2022-07-12 12:51:27 +09:00
Bartłomiej Dach
cca208b3c7
Merge branch 'master' into replay-user-bug-fix
2022-07-11 21:51:09 +02:00
Bartłomiej Dach
2eb79f38af
Merge pull request #19074 from peppy/fix-multiplayer-spectator-crash
...
Fix crash when currently played beatmap finishes download while multiplayer spectating
2022-07-11 21:43:44 +02:00
Bartłomiej Dach
0da4ab765a
Merge branch 'master' into fix-multiplayer-spectator-crash
2022-07-11 21:14:45 +02:00
Salman Ahmed
4f009419b8
Simplify population logic and match code style
2022-07-11 21:51:09 +03:00
Salman Ahmed
09bfca4e4a
Fix build failing on tests
2022-07-11 21:45:39 +03:00
Salman Ahmed
1ac794dcf1
Merge pull request #19073 from peppy/update-deps
...
Update dependencies
2022-07-11 19:53:55 +03:00
Dean Herbert
44d2e001ed
Update various dependencies
2022-07-11 20:16:49 +09:00
Joseph Madamba
6220650ea3
Fix dialog overlay not loading in time for headless test
2022-07-11 02:29:56 -07:00
Andrew Hong (홍준원)
56896e8b41
Move PostImport()
2022-07-11 02:36:52 -04:00
Andrew Hong
10d6027c89
Assign missing UserID to RealmUser
2022-07-11 02:36:51 -04:00
Dean Herbert
958c0fb390
Remove Appveyor.TestLogger
2022-07-11 15:01:16 +09:00
Dean Herbert
0434c10914
Use global WorkingBeatmap in PlayerArea for the time being
2022-07-11 02:57:44 +09:00
Dean Herbert
8b6665cb5b
Ensure initial beatmap processing is done inside the import transaction
2022-07-11 02:51:54 +09:00
Dean Herbert
8116a4b6f6
Fix multiplayer spectator crash due to track potentially not being loaded in time
2022-07-11 02:51:40 +09:00
Ludio235
52aef09cd6
Update PlaylistsRoomSettingsOverlay.cs
2022-07-10 02:05:40 +00:00
Joseph Madamba
834bb1f187
Fix editor playing object samples while paused after cancelling exit
2022-07-09 12:14:39 -07:00
Joseph Madamba
5fcc4bf713
Add failing sample playback disabled check
2022-07-09 12:10:18 -07:00
Dean Herbert
315a73fb1b
Merge pull request #19059 from andy840119/remove-the-nullable-disable-in-the-benchmark-project
...
Remove the nullable disable annotation in the benchmark project
2022-07-10 03:00:48 +09:00
為什麼
378be99fe1
Remove un-need null check.
2022-07-09 21:12:35 +08:00
為什麼
8fcc33936c
Mark the parameter as non-nullable.
2022-07-09 21:07:47 +08:00
為什麼
086388ec4e
Remove nullable disable annotation in the benchmark project.
2022-07-09 21:06:47 +08:00
Dean Herbert
200f0d9f55
Merge pull request #19050 from peppy/fix-mono-fuck-off
...
Fix crash on mobile releases when attempting to read any file
2022-07-09 06:01:43 +09:00
Dean Herbert
66f314915d
Fix crash on mobile releases when attempting to read any file
2022-07-09 06:01:22 +09:00
Salman Ahmed
26b9352aeb
Merge pull request #19025 from peppy/custom-ruleset-score-import
...
Fix custom rulesets not importing scores at all
2022-07-08 20:01:14 +03:00
Salman Ahmed
7c77be80f7
Merge branch 'master' into custom-ruleset-score-import
2022-07-08 19:25:37 +03:00
Salman Ahmed
667b1d795d
Ensure score has custom ruleset
2022-07-08 19:15:03 +03:00
Salman Ahmed
8c7aabccb0
Fix custom legacy ID in test scene not overriding base value
2022-07-08 19:01:21 +03:00
Dean Herbert
8071335f3a
Merge pull request #18596 from hlysine/fix-random-mod-slider
...
Fix random mod generating off-screen sliders
2022-07-08 19:28:34 +09:00
Dean Herbert
ac3cdf103a
Fix test not failing against master
2022-07-08 19:17:51 +09:00
Dean Herbert
5651eca06c
Merge branch 'master' into custom-ruleset-score-import
2022-07-08 19:03:47 +09:00
Dean Herbert
3c8f06403c
Make test work properly
2022-07-08 19:03:26 +09:00
Dean Herbert
13e16530a6
Revert most changes to PlayerTestScene
2022-07-08 18:45:18 +09:00
Dan Balasescu
113fdf5491
Merge pull request #19032 from peppy/fix-background-loading-too-much
...
Fix background loading excessively on startup
2022-07-08 18:25:41 +09:00
Adam Baker
7ced84b7ef
Replace switch statement with ForModType
...
In order to make `highlightedColour` dependent on the mod type color, the color is converted to an `osu.Framework.Graphics.Colour4` and calls `Lighten`.
2022-07-08 03:23:58 -05:00
Dean Herbert
e64b2b1682
Assert that test is run headless when required
2022-07-08 15:45:01 +09:00
Dean Herbert
eab3eba70e
Move event handlers to LoadComplete
2022-07-08 15:09:16 +09:00
Dean Herbert
32c77ddf71
Avoid triggering SeasonalBackgroundChanged unless actually required
2022-07-08 15:07:30 +09:00
Dean Herbert
5454171de1
Merge pull request #19041 from smoogipoo/fix-music-tests
...
Fix intermittent MusicController tests
2022-07-08 15:01:32 +09:00
Dan Balasescu
26d88aa326
Fix intermittent MusicController tests
2022-07-08 14:29:15 +09:00
Dan Balasescu
0bc332e90b
Merge pull request #19029 from peppy/fix-skin-import-duplicate
...
Fix skins potentially being duplicated on batch import
2022-07-08 14:18:14 +09:00
Adam Baker
89f1c75f7a
Update mod icon colors
2022-07-07 21:57:18 -05:00
