113 Commits

• Fix slider length not updating when adding new anchor via ctrl-click
  Bartłomiej Dach · 2023-11-23 10:07:40 +09:00
  e8d3d26d16
• Merge pull request #25520 from peppy/context-menu-spacers

  Allow context menus to have visible spacers

  Dean Herbert · 2023-11-21 16:56:36 +09:00
  21bf288277
• Fix spacer appearing on top of menu
  Bartłomiej Dach · 2023-11-21 16:14:41 +09:00
  ed38746823
• Add visible spacer between "inherit" and other curve types
  Dean Herbert · 2023-11-21 14:24:19 +09:00
  9718a80249
• Simplify null checks
  Dean Herbert · 2023-11-21 00:18:36 +09:00
  750bbc8a19
• Remove unnecessary null override
  Dean Herbert · 2023-11-20 19:21:23 +09:00
  492fd06c62
• Show Catmull as a control point type option if selection already contains it
  Bartłomiej Dach · 2023-11-20 15:53:25 +09:00
  43dbd65708
• Hide catmull curve type when possible
  cs · 2023-11-15 07:45:28 +01:00
  360864fd7b
• Fix control point hover text and context menu
  cs · 2023-11-15 07:45:09 +01:00
  520642975b
• Fix code style/quality issues
  cs · 2023-11-13 08:25:27 +01:00
  fa976a5aa0
• CI Fixup
  cs · 2023-11-11 15:02:06 +01:00
  54b8244a18
• Generalize Bezier curves to BSplines of Nth degree
  Thomas Müller-Höhne · 2023-11-11 13:32:53 +01:00
  926636cc03
• Split IPositionSnapProvider from IDistanceSnapProvider

  In preparation to remove `DistancedHitObjectComposer`, split off
  `IPositionSnapProvider` from `IDistanceSnapProvider`.
  
  `DistancedHitObjectComposer` was not touching `IPositionSnapProvider`'s
  only interface member at all, it was just forwarding it for subclasses
  to override to their own leisure.

  Bartłomiej Dach · 2023-10-19 11:45:24 +02:00
  3ab083b696
• Bypass Parent nullability checks for now
  Dean Herbert · 2023-10-17 17:48:45 +09:00
  5341a335a6
• Fix slider path placement snapping non-head nodes to distanced snapping grid

  As discussed at https://github.com/ppy/osu/discussions/23531.

  Dean Herbert · 2023-05-25 21:41:43 +09:00
  1cd69220ef
• Move where class specs to next line
  Dean Herbert · 2023-01-26 17:12:41 +09:00
  7344d34d5b
• Merge branch 'master' into stream-tool-2
  Dean Herbert · 2023-01-26 16:08:20 +09:00
  13937cf555
• Fix some more inspections
  Dean Herbert · 2022-12-16 20:21:19 +09:00
  192536643c
• Fix variable which didnt get renamed
  OliBomby · 2022-12-07 10:13:40 +01:00
  d458c3a012
• made PathControlPointVisualiser generic
  OliBomby · 2022-12-07 10:13:40 +01:00
  10b5900710
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Fix sliders not correctly taking on full available length after changing curve type
  Dean Herbert · 2022-11-17 13:59:07 +09:00
  12606122e3
• Always use Parent.ToScreenSpace() in PathControlPointVisualiser
  B3nn1 · 2022-09-21 18:56:22 +02:00
  112bbe2296
• Remove unnecessary brackets
  B3nn1 · 2022-09-21 01:25:01 +02:00
  368229f324
• Fix snapping of already existing slider control points in the editor
  B3nn1 · 2022-09-21 01:04:39 +02:00
  fe9e8635fc
• Enable snapping for slider control points in the editor
  B3nn1 · 2022-09-19 21:33:38 +02:00
  b0a3c9152a
• Merge branch 'master' into slider-splitter
  Dean Herbert · 2022-08-26 19:10:33 +09:00
  03dcfed384
• Refactor splitting logic and comments slightly
  Dean Herbert · 2022-08-26 19:09:03 +09:00
  47cb163015
• Add ToArray() calls to removal iteration for safety
  Dean Herbert · 2022-08-25 15:13:38 +09:00
  3ca4bdc087
• Fix SliderPath.Version bindings not being correctly cleaned up on path changes
  Dean Herbert · 2022-08-25 15:00:32 +09:00
  091c51e664
• Reorder context menu items and tidy up surrounding code
  Dean Herbert · 2022-08-20 14:03:54 +09:00
  885ea4270b
• added slider splitting option
  OliBomby · 2022-08-18 01:29:03 +02:00
  cb6339a20b
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Add xmldoc and rename methods in IPositionSnapProvider for legibility
  Dean Herbert · 2022-05-05 15:58:21 +09:00
  f6fc926f1a
• Move distancing methods from IPositionSnapProvider to IDistanceSnapProvider
  Salman Ahmed · 2022-04-28 05:48:45 +03:00
  59cf3ff50f
• Use slider snapping more liberally to match user expectations

  Previously the slider path length would be snapped using the current
  beat snap setting on *every* change of the slider path. As it turns out
  this is unexpected behaviour in some situations (e.g. when reversing a
  path, which is expected to preserve the previous duration, even though
  the slider may be technically "unsnapped" at that point in time due to a
  different beat snap setting being selected afterwards).

  Bartłomiej Dach · 2022-01-07 16:02:04 +01:00
  c09f6ee052
• Move public method up and add xmldoc to second public method
  Dean Herbert · 2021-12-23 14:13:57 +09:00
  b0df787b1a
• Select newly created control point
  Bartłomiej Dach · 2021-12-22 10:33:07 +01:00
  6330fa5dc5
• Fix selections including head not correctly dragging if not started from head
  Bartłomiej Dach · 2021-12-21 12:35:48 +01:00
  e715bff535
• Implement drag operation for multiple path control points
  Bartłomiej Dach · 2021-12-20 21:29:57 +01:00
  d2417beeac
• Move slider path point drag handling to visualiser
  Bartłomiej Dach · 2021-12-20 20:56:06 +01:00
  b0ca82e1e5
• Update with keybinding changes
  smoogipoo · 2021-09-16 18:26:12 +09:00
  f9d5abff8a
• Fix missed cases of incorrect .Value usage

  Changing from `Bindable` to `Nullable` comes with its issues...

  Dean Herbert · 2021-08-26 14:02:57 +09:00
  17f6efc6fe
• Remove bindable usage in PathControlPoint

  This is quite a breaking change, but I think it is beneficial due to the large amount of usage of this class.
  
  I originally intended just to remove the allocations of the two delegates handling the `Changed` flow internally, but as nothing was really using the bindables for anything more than a general "point has changed" case, this felt like a better direction.

  Dean Herbert · 2021-08-26 12:33:53 +09:00
  6dcd9427ac
• Adapt to PlatformAction type change
  ekrctb · 2021-07-21 16:12:53 +09:00
  1bac471b49
• Create base implementations of the two most common TernaryStateMenuItems
  Dean Herbert · 2021-05-20 19:34:53 +09:00
  df5970fab4
• Carry over the previous path type
  Naxess · 2021-04-09 11:04:00 +02:00
  f64b2095bf
• Fix index out of range possibility
  Naxess · 2021-04-08 11:46:00 +02:00
  be4520fe33
• Improve UX of selecting PerfectCurve
  Naxess · 2021-04-08 09:06:28 +02:00
  0341023d13
• Add path type menu change method
  Naxess · 2021-04-08 09:05:35 +02:00
  725edfcbf3