1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-16 22:32:55 +08:00
Commit Graph

68733 Commits

Author SHA1 Message Date
Salman Ahmed
b33e54d064 Enforce IBeatmap.Breaks to be sorted chronologically 2024-07-08 16:06:38 +03:00
Salman Ahmed
da4067d059 Add failing test case 2024-07-08 16:06:34 +03:00
Bartłomiej Dach
baff790b4c
Merge pull request #28772 from OliBomby/time-accurate
Fix CurrentTimeAccurate being inaccurate
2024-07-08 14:50:13 +02:00
Bartłomiej Dach
2cad8d3684
Merge branch 'master' into time-accurate 2024-07-08 14:19:57 +02:00
Dan Balasescu
5cae005027
Merge pull request #28770 from bdach/really-now
Fix editor playback control not removing correct adjustment
2024-07-08 20:45:17 +09:00
Bartłomiej Dach
d5158d1035
Fix incorrect changes around success callback refactor 2024-07-08 13:36:30 +02:00
OliBomby
2822ba2377 Fix CurrentTimeAccurate being inaccurate if seeking smoothly in the same frame and a transform is already active 2024-07-08 13:30:11 +02:00
Bartłomiej Dach
0fe2c45e1d
Fix editor playback control not removing correct adjustment
Closes https://github.com/ppy/osu/issues/28768.

great job past me 🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦
2024-07-08 13:21:42 +02:00
Bartłomiej Dach
6433f29651
Add failing test case 2024-07-08 13:21:38 +02:00
Dean Herbert
c0a1696538
Merge pull request #28762 from frenzibyte/change-chevron-display
Change display of "expanded" chevrons in many UI components to use scale instead of rotation
2024-07-08 20:05:59 +09:00
Dean Herbert
8f271170e9
Coalesce beatmap updates 2024-07-08 20:05:18 +09:00
Dean Herbert
1095137a5b
Simplify tracking of hidden beatmaps
Handling a few extra events is preferrable to keeping a second realm
subscription live.
2024-07-08 20:05:18 +09:00
Dean Herbert
151c448535
Simplify tracking of beatmap sets in BeatmapCarousel 2024-07-08 20:05:18 +09:00
Dean Herbert
e51d510ea3
Add failing test for beatmap set hard deletion 2024-07-08 20:05:17 +09:00
Dean Herbert
910153c2e0
Fix sizing / padding of collection dropdown header 2024-07-08 19:32:28 +09:00
Dan Balasescu
b2bdb67a3e
Merge pull request #28765 from bdach/editor-menu-max-height
Fix editor menus overflowing off screen
2024-07-08 19:13:30 +09:00
Dan Balasescu
44ebec07bb
Merge pull request #28767 from bdach/editor-test-play-ur-counter-crash
Fix editor player crashing with UR counter present in skin
2024-07-08 19:13:19 +09:00
Salman Ahmed
2f4e447cba
Merge pull request #28547 from nekodex/audio-ducking-fx
Add a 'ducking' effect to the currently playing track when changing ruleset
2024-07-08 13:12:04 +03:00
Salman Ahmed
2fcc61edfa
Merge branch 'master' into audio-ducking-fx 2024-07-08 12:50:46 +03:00
Bartłomiej Dach
14a93bfc1a
Merge pull request #28553 from frenzibyte/mod-select-customisation-panel
Detach mod customisation area from the footer and replace with an overlay panel display
2024-07-08 11:26:21 +02:00
Salman Ahmed
784a9ae743
Merge branch 'master' into audio-ducking-fx 2024-07-08 12:26:10 +03:00
Bartłomiej Dach
db7774485a
Fix editor player crashing with UR counter present in skin
Closes https://github.com/ppy/osu/issues/28764.
2024-07-08 11:14:32 +02:00
Bartłomiej Dach
2ceedb0f93
Fix editor menus overflowing off screen
Closes https://github.com/ppy/osu/issues/28750.

Yes this is not the perfect change to fix this (which would probably be
some framework change to take bounds of the parenting input manager into
account). I really do not want to go there and would like to just fix
this locally and move on. Due to the game-wide scaling container this
sorta works for any resolution anyhow.
2024-07-08 11:05:39 +02:00
Joseph Madamba
257de9d08b Fix arrow direction test 2024-07-08 01:00:36 -07:00
Salman Ahmed
a3e54a6272
Merge pull request #28763 from peppy/revert-to-default-animation
Add slight animation when revert to default button is displayed
2024-07-08 10:58:53 +03:00
Joseph Madamba
73d164e0d0 Add chevron transition to CommentRepliesButton 2024-07-08 00:32:54 -07:00
Dean Herbert
03bd6069d8
Add slight animation when revert to default button is displayed
This also fixes the transforms running too often (could make the initial
transform take longer than expected if adjusting a slider bar, for
instance).
2024-07-08 15:50:27 +09:00
Joseph Madamba
9532146978 Fix content overflowing to border
The +2 for the top isn't really needed for the original purpose as content fades out now, but visually, having the header and content spacing looks more correct.
2024-07-07 23:12:20 -07:00
Salman Ahmed
7dc901df11 Do not be lenient on nullability of dropdown 2024-07-08 08:54:05 +03:00
Salman Ahmed
58e236a247 Add transition to dropdown chevrons 2024-07-08 08:48:52 +03:00
Salman Ahmed
4c2ae07eba Use scale instead of rotation in ChevronButton (used in top-right of comments section) 2024-07-08 08:48:07 +03:00
Salman Ahmed
dc630ddc9d Use scale instead of rotation in news month sidebar 2024-07-08 08:45:44 +03:00
Salman Ahmed
be039b85ad Use scale instead of rotation in profile cover toggle button 2024-07-08 08:32:29 +03:00
Salman Ahmed
5223e0aeae Use scale instead of rotation for overlay scroll button 2024-07-08 08:31:33 +03:00
Salman Ahmed
22f2f83695 Rescale chevron up and down instead 2024-07-08 08:07:57 +03:00
Dan Balasescu
9375f79879
Add frenzibyte to users that can use diffcalc workflow 2024-07-08 13:58:42 +09:00
Salman Ahmed
a0ffe9bcbc Remove unnecessary HandlePositionalInput override 2024-07-08 07:58:40 +03:00
Salman Ahmed
0c5a1410d3 Add fade transition to content during open/close 2024-07-08 07:54:37 +03:00
Dean Herbert
3650f3c479
Allow multiple ducks with same parameters 2024-07-08 13:52:40 +09:00
Dean Herbert
aa36a844be
Reduce precision requirement for tests 2024-07-08 13:49:25 +09:00
Dean Herbert
0067450b22
Change volume parameter to double 2024-07-08 13:47:57 +09:00
Salman Ahmed
2bfa03c6d8 Rename test scene file 2024-07-08 07:37:42 +03:00
Dean Herbert
5907e0d1eb
Make DuckDuration non-zero by default 2024-07-05 18:39:13 +09:00
Dean Herbert
7efb4ce30a
Fix multiple disposals resulting in assert being hit 2024-07-05 18:39:12 +09:00
Dean Herbert
65418aca1a
Add basic test coverage 2024-07-05 18:35:54 +09:00
Dean Herbert
717f7ba9f0
Better support multiple concurrent ducking operations 2024-07-05 18:12:40 +09:00
Dan Balasescu
0bb6c252a7
Merge pull request #28746 from bdach/fix-ternary-state-breakage
Fix incorrect ternary state computation for bank toggles
2024-07-05 17:42:27 +09:00
Bartłomiej Dach
4c59ec1d94
Fix incorrect ternary state computation for bank toggles
Closes https://github.com/ppy/osu/issues/28741.

Regressed in a7b066f3ee.

The intent of the original change there was to ensure that addition
banks being set will put the ternary state toggles in indeterminate
state (to at least provide a visual indication that the selection does
not use a single bank). This would previously not be the case due to
the use of `.All()` in the original condition (a single object/node
was considered to have a bank enabled if and only if *all* samples
within it used it). However the attempt to fix that via switching
to `Any()` was not correct.

The logic used in the offending commit operates on extracted `Samples`
and `NodeSamples` from the selection, and would consider the ternary
toggle:

- fully off if none of the samples/node samples contained a sample with
  the given bank,
- indeterminate if the some of the samples/node samples contained a
  sample with the given bank,
- fully on if at least one sample from every samples/node samples
  contained a sample with the given bank.

This is a *two-tiered* process, as in first a *binary* on/off state is
extracted from each object's samples/node samples, and *then* a ternary
state is extracted from all objects/nodes. This is insufficient to
express the *desired* behaviour, which is that the toggle should be:

- fully off if *none of the individual samples in the selection* use
  the given bank,
- indeterminate if *at least one individual sample in the selection*
  uses the given bank,
- fully on if *all individual samples in the selection* use the given
  bank.

The second wording is flattened, and no longer tries to consider "nodes"
or "objects", it just looks at all of the samples in the selection
without concern as to whether they're from separate objects/nodes
or not.

To explain why this discrepancy caused the bug, consider a single object
with a `soft` normal bank and `drum` addition bank. Selecting the object
would cause a ternary button state update; as per the incorrect logic,
there were two samples on the object and each had its own separate
banks, so two ternary toggles would have their state set to `True`
(rather than the correct `Indeterminate`), thus triggering a bindable
feedback loop that would cause one of these banks to win and actually
overwrite the other.

Note that the addition indeterminate state computation *still* needs
to do the two-tiered process, because there it actually makes sense (for
a selection to have an addition fully on rather than indeterminate,
*every* object/node *must* contain that addition).
2024-07-05 09:27:21 +02:00
Bartłomiej Dach
d6c1b5d399
Add failing test coverage 2024-07-05 08:54:47 +02:00
Bartłomiej Dach
f8a2b0724d
Merge pull request #28726 from OliBomby/nodesample-inherit
Fix node samples always having default samples on placement
2024-07-05 08:45:35 +02:00