56936 Commits

This Branch

This Branch

All Branches

• Add test coverage of track rate adjusting during multi spectator
  Dean Herbert · 2022-09-07 20:00:24 +09:00
  770c1ade2f
• Enable NRT
  Dan Balasescu · 2022-09-07 19:54:55 +09:00
  cb9bae1f5c
• Merge pull request #20177 from peppy/fix-target-mod-crash

  Fix target mod crashing if beatmap is played with a break after all hitobjects

  Dan Balasescu · 2022-09-07 19:24:19 +09:00
  85ce1bcea9
• Fix case of zero rate calculating a zero true gameplay rate
  Dean Herbert · 2022-09-07 19:23:44 +09:00
  e6b449fe0b
• Fix multiplayer spectator not getting gameplay adjustments applied
  Dean Herbert · 2022-09-07 19:12:34 +09:00
  1be3b74ff3
• Move full track adjustment flow inside MasterGameplayClockContainer
  Dean Herbert · 2022-09-07 19:12:16 +09:00
  fa15502384
• Apply proposed changes to remove inheritance from MasterGameplayClockContainer
  Dean Herbert · 2022-09-07 17:49:05 +09:00
  75d0deef72
• Fix target mod crashing if beatmap is played with a break after all hitobjects

  Closes https://github.com/ppy/osu/issues/20161.

  Dean Herbert · 2022-09-07 17:46:51 +09:00
  b5b66de3c9
• Merge pull request #20171 from peppy/beatmap-carousel-nrt

  Fix missing null checks on `selectedBeatmap` fields in `BeatmapCarousel`

  Dan Balasescu · 2022-09-07 17:15:00 +09:00
  f8e37af2e0
• Merge pull request #20173 from peppy/test-scene-storyboard-tidy

  Tidy up `TestSceneStoryboard`

  Dan Balasescu · 2022-09-07 17:07:19 +09:00
  264c9bfaf6
• Merge pull request #20158 from smoogipoo/taiko-geki-katu

  Decode taiko Geki/Katu from legacy scores into `LargeBonus`

  Dean Herbert · 2022-09-07 17:06:42 +09:00
  68c27522e7
• Simplify children assignment
  Dean Herbert · 2022-09-07 16:51:51 +09:00
  99ef0c95fe
• Merge pull request #20174 from peppy/fix-storyboard-zero-vector-scale

  Fix some storyboard sprites still showing with zero `VectorScale`

  Dan Balasescu · 2022-09-07 16:50:14 +09:00
  edabb0dfe6
• Tidy up test logic
  Dean Herbert · 2022-09-07 16:43:48 +09:00
  cb1bb99208
• Merge branch 'master' into taiko-geki-katu
  Dean Herbert · 2022-09-07 16:22:47 +09:00
  5b758afd09
• Add missing null check in BeatmapCarousel tests
  Dean Herbert · 2022-09-07 16:22:11 +09:00
  b50116e9e4
• Merge pull request #18764 from sw1tchbl4d3r/classic_drumrolls

  Make drum rolls and swells optional in taiko

  Dean Herbert · 2022-09-07 16:12:56 +09:00
  5b95fdeb92
• Fix VectorScale set to 0 still showing some sprites in storyboard

  This implementation was matching the [framework side implementation of
  scale](https://github.com/ppy/osu-framework/blob/16d1c2d3356b0f59271fb49cff5fe8373ae9cdf3/osu.Framework/Graphics/Drawable.cs#L973-L976)
  but I don't think it's required here.
  
  I'm still not sure if the framework implementation is correct, but
  removing it locally does seem to fix broken storyboard cases.
  
  Closes https://github.com/ppy/osu/issues/20155.

  Dean Herbert · 2022-09-07 15:39:19 +09:00
  824e68dab3
• Add test coverage of storyboard using zero VectorScale
  Dean Herbert · 2022-09-07 15:39:19 +09:00
  258b8f015c
• Tidy up TestSceneStoryboard
  Dean Herbert · 2022-09-07 15:38:49 +09:00
  866bc553fe
• Merge pull request #20094 from peppy/tourney-fix-team-display-scores

  Show team scores at the tournament map pool screen

  Dan Balasescu · 2022-09-07 14:58:14 +09:00
  dbdb311f79
• Merge pull request #20095 from peppy/fix-bracket-riht-click-no-selection

  Fix right-clicking a non-selected match in ladder view dismissing context menu

  Dan Balasescu · 2022-09-07 14:56:23 +09:00
  c42ae4be04
• Merge pull request #20144 from peppy/fix-notification-overlay-presence

  Fix completion toasts sometimes not displaying

  Dan Balasescu · 2022-09-07 14:55:33 +09:00
  dc71abdf56
• Fix weird edge case of nullability in CarouselRoot

  A bit unfortunately, but it's what we get for having ctor level bindings..

  Dean Herbert · 2022-09-07 14:27:25 +09:00
  f3bda4e040
• Merge pull request #20168 from nekodex/add-textbox-esc-feedback

  Add audio feedback for Esc/Back clearing text from a FocusedTextBox

  Dean Herbert · 2022-09-07 14:19:15 +09:00
  83962443e5
• Fix missing null checks on selectedBeatmap fields in BeatmapCarousel
  Dean Herbert · 2022-09-07 14:12:35 +09:00
  e18b524f8e
• Apply NRT to BeatmapCarousel
  Dean Herbert · 2022-09-07 14:07:53 +09:00
  241d33d415
• Add audio feedback for Esc/Back clearing text from a FocusedTextBox
  Jamie Taylor · 2022-09-07 13:17:04 +09:00
  cb1d886c9c
• refactor(osu.Game): improve code quality
  Acid Chicken (硫酸鶏) · 2022-09-07 02:29:15 +09:00
  3003fc1061
• Merge pull request #19413 from Gramore/feature/EditorDeleteDiff

  Add ability to delete difficulties from the editor

  Salman Ahmed · 2022-09-06 19:20:45 +03:00
  13efa819ae
• Retrieve great hit window from the hit object
  apollo-dw · 2022-09-06 17:10:32 +01:00
  b5779508d0
• Merge branch 'master' into feature/EditorDeleteDiff
  Salman Ahmed · 2022-09-06 18:48:06 +03:00
  90207b6032
• Decode Geki/Katu from legacy taiko scores into LargeBonus
  Dan Balasescu · 2022-09-07 00:12:34 +09:00
  7c0e99c5a8
• Fix namespace
  Dan Balasescu · 2022-09-07 00:12:25 +09:00
  6a371eba5f
• Fix test failures due to notifications being forwarded before player finishes loading
  Dean Herbert · 2022-09-06 23:36:27 +09:00
  c2107bd322
• Add tests for all taiko judgements
  Dan Balasescu · 2022-09-06 23:26:25 +09:00
  2ca63b5030
• Also ignore drum roll strong judgement
  Dan Balasescu · 2022-09-06 23:26:25 +09:00
  a2f8ff825e
• Merge pull request #20156 from peppy/sb-earliest-alpha-fix-atttempt-two

  Fix some storyboard elements displaying too late due to incorrect start time allowances

  Dan Balasescu · 2022-09-06 23:14:43 +09:00
  604fc0fb97
• Delegate interface to valid target
  Dean Herbert · 2022-09-06 22:26:46 +09:00
  66c44f5913
• Change NonGameplayAdjustments to GameplayAdjustments and convert TrueGameplayRate to extension method
  Dean Herbert · 2022-09-06 22:26:46 +09:00
  bc1212f4e6
• Invalidate working beatmap cache when calling DeleteDifficultyImmediately rather than in editor code
  Dean Herbert · 2022-09-06 18:12:47 +09:00
  db15bd56e8
• Fix deleting a difficulty not updating the beatmap set hash
  Dean Herbert · 2022-09-06 18:12:47 +09:00
  579e7e1f17
• Fix typo in LoopStartTime addition
  Dean Herbert · 2022-09-06 17:46:03 +09:00
  a3de5f808e
• Tidy up TestSceneLeadIn constant for loop offset to read better
  Dean Herbert · 2022-09-06 17:45:53 +09:00
  9f2ea54e40
• Update IsDisplayingToasts to check the flow count directly
  Dean Herbert · 2022-09-06 17:30:24 +09:00
  6e52dbb266
• Rewrite logic using a list
  Dean Herbert · 2022-09-06 16:58:51 +09:00
  677708c5e4
• Refactor alpha check to not overwrite sourced overrides with values from later commands
  Dean Herbert · 2022-09-06 16:41:32 +09:00
  d667f46830
• Add failing test for second incorrect case of start time handling
  Dean Herbert · 2022-09-06 16:40:59 +09:00
  fa0a4614f8
• Merge branch 'master' into classic_drumrolls
  Dan Balasescu · 2022-09-06 16:29:45 +09:00
  792b410c04
• Handle earliest-alpha-start-time logic in StoryboardSprite itself
  Dean Herbert · 2022-09-06 16:16:58 +09:00
  bea42d2862