160 Commits

• Return StatisticItems rather than StatisticRows from ruleset

  There were no usages of more than one column being provided per row, so
  it seemed like unnecessarily complexity. I'm currently trying to reduce
  complexity so we can improve the layout of the results screen, which
  currently has up to three levels of nested `GridContainer`s.
  
  Of note, I can't add backwards compatibility because the method
  signature has not changed in `Ruleset` (only the return type). If we do
  want to keep compatibility with other rulesets, we could designate a new
  name for the updated method.

  Dean Herbert · 2023-06-01 14:35:15 +09:00
  985604fab5
• Remove usages of [ExcludeFromDynamicCompile]
  Dan Balasescu · 2023-05-08 18:12:56 +09:00
  d2380bd840
• Use generic Enum methods
  Berkan Diler · 2022-12-26 20:36:39 +01:00
  c7ca4bbba5
• Fix the MOTHERLOAD of undetected issues that are now visible thanks to net6.0
  Dean Herbert · 2022-12-16 18:16:26 +09:00
  27c497145f
• Rename CreateLegacySkinProvider to CreateSkinTransformer and apply to all skins
  Dean Herbert · 2022-09-15 20:18:10 +09:00
  c7f8f948b9
• Move the CreateConvertibleReplayFrame() into the base ruleset class for avoid api breaking change in the customized ruleset.
  andy840119 · 2022-09-10 11:07:23 +08:00
  3d7367a842
• Merge branch 'master' of https://github.com/ppy/osu into remove-the-nullable-disable-in-the-ruleset

  # Conflicts:
  #	osu.Game.Rulesets.Catch/CatchRuleset.cs
  #	osu.Game.Rulesets.Osu/OsuRuleset.cs
  #	osu.Game.Rulesets.Taiko/TaikoRuleset.cs
  #	osu.Game/Rulesets/Ruleset.cs

  andy840119 · 2022-09-10 10:40:12 +08:00
  e62999fb16
• Remove "internal" identifier as unnecessary
  Dean Herbert · 2022-08-29 14:01:15 +09:00
  90b9c02ac6
• Add ruleset API versioning
  Dean Herbert · 2022-08-22 16:35:08 +09:00
  f5710d8000
• Update GetVariantName to also support localisation
  Dean Herbert · 2022-08-22 14:51:00 +09:00
  d199b3b100
• Localise hit result name
  naoei · 2022-08-14 14:57:02 -04:00
  45e9eda9e7
• Revert localisation for GetDisplayNameForHitResult

  Came across an issue where `LeaderboardScoreTooltip` attempts to capitalize all letters for the `displayName`.
  
  Unsure if I should completely ignore it and localise it anyway.

  naoei · 2022-08-10 16:03:59 -04:00
  1e356f6137
• Change most ruleset-accessible string types to Localisable strings
  naoei · 2022-08-10 15:51:11 -04:00
  8cb2e11766
• Mark CreateHitObjectComposer() accept null.

  And add the null check in the test case.

  為什麼 · 2022-07-10 10:15:27 +08:00
  8e1ed1c621
• Mark the CreateBeatmapProcessor() as nullable.

  Also, should add the null check in the working beatmap.

  為什麼 · 2022-07-10 10:15:27 +08:00
  57c6763556
• Mark CreateConfig() return type as nullable because it's not required all ruleset to implement.

  Also, remove nullable disable annotation for all using classes.
  
  Setting store can be nullable because `RulesetConfigManager()` can accept null setting store.

  為什麼 · 2022-07-10 10:15:27 +08:00
  d39f53f1f0
• Move CreateConvertibleReplayFrame() into legacy ruleset interface because technically only legacy ruleset use it to convert the legacy frame.

  But seems some of the customized ruleset use it for save the replay frame.

  為什麼 · 2022-07-10 10:15:27 +08:00
  857377e145
• Mark create beatmap verifier as nullable because seems it's not requirement to be implemented.
  為什麼 · 2022-07-10 10:10:43 +08:00
  e67cb4c905
• Remove unnecessary attribute.
  為什麼 · 2022-07-10 10:10:43 +08:00
  4a503bab0a
• Remove nullable disable annotation and mark some return value as nullable.
  為什麼 · 2022-07-10 09:29:17 +08:00
  855debd5f6
• Attach DT with NC, SD with PF, and Cinema with Autoplay
  Dan Balasescu · 2022-06-30 11:52:30 +09:00
  edc4ace17e
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Fill out GetModsFor() xmldoc and annotate items as non-null
  Bartłomiej Dach · 2022-06-15 17:40:15 +02:00
  30382b0445
• Require ScoreProcessor to receive ruleset
  Dan Balasescu · 2022-03-14 15:51:10 +09:00
  3fff7f4b7e
• Restructure PerformanceCalculator to not require ScoreInfo argument
  Dan Balasescu · 2022-03-14 14:25:28 +09:00
  4a3e3aba65
• Make Ruleset.RulesetInfo get only
  Dean Herbert · 2022-01-27 15:36:35 +09:00
  e67b1fe0ec
• Update mock RulesetInfo usage to set OnlineID instead of ID
  Dean Herbert · 2021-11-24 15:50:26 +09:00
  f283770f34
• Add back allowance for tests scenes using empty ShortName
  Dean Herbert · 2021-11-22 21:41:09 +09:00
  6c36770eb3
• Use Ruleset's ShortName for mod caching purposes
  Dean Herbert · 2021-11-22 16:52:54 +09:00
  377ba2673a
• Update DifficultyCalculator to take an IWorkingBeatmap
  Dean Herbert · 2021-11-15 19:16:48 +09:00
  62d670a3ca
• Change CreateInstance to use Activator.CreateInstance instead of clone
  Dean Herbert · 2021-09-10 12:05:10 +09:00
  719392de39
• Refactor exposed mod retrieval methods for better safety
  Dean Herbert · 2021-09-10 11:09:13 +09:00
  cf633973a9
• Add ability to lookup mod from a type specification
  Dean Herbert · 2021-09-09 16:50:59 +09:00
  2edb851008
• Add new methods to ruleset for quicker mod lookups
  Dean Herbert · 2021-09-09 16:46:14 +09:00
  4d0530ca9d
• Rename method to drop redundant ruleset suffix
  Dean Herbert · 2021-09-05 13:34:23 +09:00
  25420af078
• Add extension point for ruleset-specific beatmap setup sections
  Bartłomiej Dach · 2021-09-02 23:29:14 +02:00
  ce1912781e
• apply suggestions
  Nathan Alo · 2021-08-18 08:13:53 +08:00
  eaca331170
• apply code inspection fixes
  Nathan Alo · 2021-08-16 07:06:23 +08:00
  c56b34d2da
• apply suggestions

  - make `UserActivity.InGame` and derive that to `InSoloGame` and `InMultiplayerGame`
  - rename `SoloGame` to `InSoloGame`
  - rename `MultiplayerGame` to `InMultiplayerGame`

  Nathan Alo · 2021-08-16 06:32:33 +08:00
  cc3468b4ab
• apply suggestions
  Nathan Alo · 2021-08-14 22:39:12 +08:00
  4ed06a1021
• Refrain from attempting to transform null skins
  Salman Ahmed · 2021-06-10 16:36:45 +03:00
  09a2d008d2
• Convert LegacySkinTransformers to accept raw ISkins rather than a full ISkinSource
  Salman Ahmed · 2021-06-09 22:49:31 +03:00
  cf40282f1f
• Extract invariant instantiation info extension method
  Bartłomiej Dach · 2021-05-12 23:23:51 +02:00
  1b579dd838
• Merge branch 'master' into verify-tab
  Dean Herbert · 2021-04-13 23:05:48 +09:00
  1ff4e2076f
• Make BeatmapVerifier an interface
  Naxess · 2021-04-13 10:40:56 +02:00
  60c2494b31
• Remove empty <returns> xmldoc
  Dean Herbert · 2021-04-12 17:46:14 +09:00
  b5954a55ad
• Rename CreateChecker -> CreateBeatmapVerifier
  Naxess · 2021-04-12 10:08:30 +02:00
  a2fc9c398f
• Checker -> BeatmapVerifier
  Dean Herbert · 2021-04-12 15:29:05 +09:00
  1c553b5d48
• Add ruleset-specific checker
  Naxess · 2021-04-07 14:36:43 +02:00
  0343ef7f14