2266 Commits

• Change osu!mania scoring ratio to 99% acc (to match previous lazer scoring)
  Dean Herbert · 2023-06-10 02:21:14 +09:00
  c40887eee8
• Merge branch 'master' into tidy-results-grid-usage
  Bartłomiej Dach · 2023-06-03 19:45:23 +02:00
  331e90f720
• Merge pull request #23721 from peppy/fix-mania-hold-not-early-hit

  Fix osu!mania hold notes snapping to judgement area too early on early hits

  Bartłomiej Dach · 2023-06-01 21:57:36 +02:00
  4daf1fcb7d
• Merge pull request #23691 from smoogipoo/mania-scroll-speed

  Replace mania scroll "time" with scroll "speed"

  Dean Herbert · 2023-06-01 17:23:27 +09:00
  00bf79d51f
• Fix osu!mania hold notes snapping to judgement area too early on early hits

  Closes https://github.com/ppy/osu/issues/23515.

  Dean Herbert · 2023-06-01 16:06:35 +09:00
  98f35f7481
• Return StatisticItems rather than StatisticRows from ruleset

  There were no usages of more than one column being provided per row, so
  it seemed like unnecessarily complexity. I'm currently trying to reduce
  complexity so we can improve the layout of the results screen, which
  currently has up to three levels of nested `GridContainer`s.
  
  Of note, I can't add backwards compatibility because the method
  signature has not changed in `Ruleset` (only the return type). If we do
  want to keep compatibility with other rulesets, we could designate a new
  name for the updated method.

  Dean Herbert · 2023-06-01 14:35:15 +09:00
  985604fab5
• Migrate in InitialiseDefaults()
  Dan Balasescu · 2023-05-30 17:27:48 +09:00
  b456c36f64
• Replace mania scroll "time" with scroll "speed"
  Dan Balasescu · 2023-05-29 21:22:23 +09:00
  1c199b83e3
• Merge branch 'master' into scorev2
  Dan Balasescu · 2023-05-23 19:07:54 +09:00
  fee3d43596
• Rename parameters
  Dan Balasescu · 2023-05-19 17:27:02 +09:00
  30a296bd09
• Refactor for safety
  Dan Balasescu · 2023-05-19 14:37:26 +09:00
  d74bf2a096
• Avoid NaN values during ApplyBeatmap processing()
  Dan Balasescu · 2023-05-19 14:14:34 +09:00
  2ae34530f7
• Fix TestSceneScoring and incorrect combo calculations
  Dan Balasescu · 2023-05-19 14:09:19 +09:00
  7cbf48ffcf
• Remove ClassicScoreMultiplier and DefaultScoreProcessor
  Dan Balasescu · 2023-05-19 12:24:52 +09:00
  8b56a3f87d
• Move blueprint validity conditions to allow more correct external usage of EndPlacement

  Until now, these were haphazardly enforce inline in blueprint
  implementations. The only thing stopping complete breakage is that
  `EndPlacement` wasn't called (too much) from outside the blueprint,
  leaving them responsible for their own placement.
  
  By moving this conditional out of the provided paramters to
  `EndPlacement`, it allows more flexible usage of that method externally.
  Coming in a future PR.

  Dean Herbert · 2023-05-12 16:02:22 +09:00
  f443cfb93e
• Reimplement classic scoring mode
  Dan Balasescu · 2023-05-09 20:21:38 +09:00
  a7b623f52a
• Initial implementation of ScoreV2
  Dan Balasescu · 2023-05-09 19:33:33 +09:00
  3c3c812ed6
• Merge pull request #23429 from peppy/fix-incorrect-mania-description-keys

  Fix incorrect special style description text

  Bartłomiej Dach · 2023-05-09 07:04:57 +02:00
  efc4df95eb
• Match generally used casing

  Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>

  Bartłomiej Dach · 2023-05-09 07:03:13 +02:00
  0a47ffcbdd
• Remove no-longer-correct remark
  Bartłomiej Dach · 2023-05-08 22:35:41 +02:00
  1ff1730948
• Merge branch 'master' into fix-mania-head-note-animation
  Bartłomiej Dach · 2023-05-08 22:23:01 +02:00
  3f45948664
• Remove clamping of sizingContainer in DrawableHoldNote to fix head note alignment
  Dean Herbert · 2023-05-08 18:14:07 +09:00
  27c10cbdb7
• Add back early return in OnReleased for safety
  Dean Herbert · 2023-05-08 15:43:11 +09:00
  814f0b3fed
• Fix incorrect special style description text

  Closes https://github.com/ppy/osu/issues/23428.

  Dean Herbert · 2023-05-08 13:00:45 +09:00
  85d0c56cd2
• Move logic to Update instead
  Dean Herbert · 2023-05-03 15:18:37 +09:00
  6a59ded1ba
• Merge branch 'master' into mania-fix-hold-note-rewind
  Dean Herbert · 2023-05-03 15:04:59 +09:00
  4013cdcfa8
• Update convert-samples-expected-conversion.json
  OliBomby · 2023-04-30 16:04:03 +02:00
  e7a478ce9c
• remove all non-test usage of SampleControlPoint
  OliBomby · 2023-04-26 13:55:39 +02:00
  d97daee96b
• removing using
  OliBomby · 2023-04-26 13:22:13 +02:00
  39d9f0c3f5
• Remove IContext & add IHasGenerateTicks
  OliBomby · 2023-04-26 13:10:57 +02:00
  6c70948681
• clean up code stuff
  OliBomby · 2023-04-25 19:06:29 +02:00
  e4b64bdc3e
• Add LegacyContext
  OliBomby · 2023-04-25 12:12:46 +02:00
  ea1e6e9798
• made the SampleControlPoint and DifficultyControlPoint obsolete
  OliBomby · 2023-04-25 11:34:09 +02:00
  a4c6850ab2
• Remove overrides on DC/NC mods
  Dan Balasescu · 2023-04-10 17:49:29 +09:00
  ad51f880e0
• Add progressive score multiplier for HT
  Dan Balasescu · 2023-04-10 13:35:48 +09:00
  15f6bc155e
• Add progressive score multiplier for DT
  Dan Balasescu · 2023-04-10 13:31:48 +09:00
  c923482976
• Revert to previous conditional style
  Bartłomiej Dach · 2023-03-28 06:22:00 +02:00
  2b525b626c
• Fix hit lighting misalignment on argon skin with upscroll
  Bartłomiej Dach · 2023-03-27 18:15:01 +02:00
  c54934cb45
• Merge branch 'master' into mania-shadow-icon-changes
  Bartłomiej Dach · 2023-03-20 19:33:52 +01:00
  b5e04791e9
• Reuse colour constants in fallback path
  Bartłomiej Dach · 2023-03-20 18:16:33 +01:00
  fe91f85f6f
• Update colours for 3k to not use double-purples
  Dean Herbert · 2023-03-15 17:18:45 +09:00
  d87f0557ce
• Fix osu!mania hold note animations not correctly re-applying after rewind

  There's early exit logic in `OnPressed`/`OnReleased` for the sake of
  keeping order correct, but this doesn't account for the fact that
  `DrawableHitObject` resets all animations when the hit state changes.
  
  A bit of an ugly workaround, but seems to work as expected.

  Dean Herbert · 2023-03-14 18:15:19 +09:00
  5aebbac6c5
• Adjust animation length and colouring of hitting layer
  Dean Herbert · 2023-03-14 18:14:29 +09:00
  f40a4b591f
• Add hitting layer to fix hit lighting not being applied to tail piece

  Taken from https://github.com/ppy/osu/pull/22820#issuecomment-1462626898.

  Dean Herbert · 2023-03-14 17:29:19 +09:00
  300d81c46b
• Remove unused fields
  Bartłomiej Dach · 2023-03-09 19:14:08 +01:00
  6b2a70b112
• Adjust hold note head icon to be more centered
  Dean Herbert · 2023-03-09 20:46:24 +09:00
  08b88ed639
• Adjust colours a bit to make hold note bodies more accented
  Dean Herbert · 2023-03-09 20:46:24 +09:00
  e12ab165b8
• Adjust argon note shadows and body to be closer in line with new design proposal
  Dean Herbert · 2023-03-09 20:27:58 +09:00
  2ad531f263
• Adjust explosion and hit target to not include shadow portion in height calculation
  Dean Herbert · 2023-03-09 20:27:43 +09:00
  526eeedec2
• Add note about why bodyPiece sizing is done as it is

  I think we're going to have to change this as it's quite limiting in
  what you can do with osu!mania skin implementation, but for now I want
  to leave a note as to why this is done, because each time I have to
  trial and error check what breaks when adjusting it.

  Dean Herbert · 2023-03-09 20:26:49 +09:00
  ed3ff62e4f