15509 Commits

Author	SHA1	Message	Date
Dean Herbert	dafe8d6448	Merge pull request #30145 from WitherFlower/ranked-date-filtering ... Add ranked date and submitted date filtering to song select	2024-10-17 02:38:36 +09:00
Dean Herbert	b29a17364d	Remove hold-to-confirm delay when pausing using keyboard shortcuts	2024-10-16 20:41:24 +09:00
Salman Alshamrani	e151c0fab1	Fix coding mistake	2024-10-14 15:11:44 -04:00
Salman Alshamrani	40b98d4863	Move conditional	2024-10-14 09:55:24 -04:00
Shin Morisawa	8ff86d560f	Merge branch 'master' into master	2024-10-14 17:48:04 +09:00
Shin Morisawa	90a08b8a68	Fix Beatmap Delete Dialog	2024-10-14 09:55:28 +09:00
Salman Alshamrani	f8c8184c5c	Fix placement blueprints not receiving latest mouse position with touch input	2024-10-13 11:01:18 -04:00
Dean Herbert	868a7db9e9	Start preparing player earlier when quick retrying ... Should help with https://github.com/ppy/osu/issues/9039.	2024-10-13 22:29:00 +09:00
Bartłomiej Dach	968835bb44	Do not show daily challenge conclusion notification on disconnection ... Closes https://github.com/ppy/osu/issues/30194.	2024-10-11 14:18:19 +02:00
WitherFlower	da376c534b	Filter out unranked/unsubmitted beatmaps when using the ranked/submitted search filters	2024-10-11 09:49:47 +02:00
Dan Balasescu	616c2aeefc	Merge pull request #30206 from minetoblend/fix/selection-box-buttons-stuck ... Fix SelectionBox buttons freezing when button is triggered via key event	2024-10-11 12:02:58 +09:00
Marvin Schürz	af55585dc8	Make TriggerAction public	2024-10-10 20:50:47 +02:00
Marvin Schürz	fc7ad96fcd	Move circle flash to TriggerAction	2024-10-10 20:20:02 +02:00
Marvin Schürz	9cc6ee2ebc	Fix SelectionBox buttons freezing when button is triggered via key event	2024-10-10 20:14:11 +02:00
Dean Herbert	14ecd56913	Merge pull request #30195 from bdach/advanced-stats-stupid-shenanigans ... Fix crashes when attempting to change from a custom ruleset with mods selected to another	2024-10-11 00:57:28 +09:00
WitherFlower	eb2f1d09f8	Improve regex readability by using character set	2024-10-10 17:42:43 +02:00
WitherFlower	6b532824b1	Fix code quality and formatting issues	2024-10-10 17:41:29 +02:00
Bartłomiej Dach	938c3d78ce	Fix argon song progress bar tooltip showing during active gameplay ... Closes https://github.com/ppy/osu/issues/30197. Pretty bad one, might be worth a hotfix...	2024-10-10 14:36:28 +02:00
Bartłomiej Dach	f1842d781e	Decouple AdvancedStats from global mods ... Closes https://github.com/ppy/osu/issues/30163. If I'm to be blunt, the decoupled stuff in song select makes my head spin. I spent a solid 20 minutes thinking how I was going to fix this one but then finally realised that generally most of the cause there was the fact that `AdvancedStats` was seeing the new rulesets *before* the "ensure global selected mods are valid for current ruleset" logic, and so decided to just _delay_ that until the decoupled transfer thingamajig happens. I was honestly considering combining `BeatmapInfo`, `Ruleset`, and `Mods` into one property on `AdvancedStats`. I figured I'd rather not push my luck and try the baseline version first, but I honestly think that direction is going to be required at some point to properly corral all of the decoupled madness taking place in song select.	2024-10-10 14:22:16 +02:00
WitherFlower	b58576f31b	Add slash and dot as valid separators in dates.	2024-10-08 14:13:27 +02:00
WitherFlower	2369e98cfc	Implement ranked and submitted date filtering	2024-10-08 13:56:55 +02:00
Dean Herbert	682023e130	Merge branch 'master' into grids-4	2024-10-08 16:26:42 +09:00
Dean Herbert	b658d9a681	Merge pull request #30073 from peppy/updates-outside-of-gameplay-only-2 ... Avoid updates (and update notifications) from appearing in more gameplay cases	2024-10-08 15:17:09 +09:00
OliBomby	d7526be243	Merge remote-tracking branch 'upstream/master' into grids-4	2024-10-07 11:56:35 +02:00
Dan Balasescu	8dece70097	Merge branch 'master' into updates-outside-of-gameplay-only-2	2024-10-07 17:41:42 +09:00
Dean Herbert	11fc811e2f	Fix delete dialogs having generic "Caution" header text ... Regressed in https://github.com/ppy/osu/pull/28363.	2024-10-07 16:46:53 +09:00
Dean Herbert	75f15ccaba	Maybe fix compilation? Fuck knows if this is correct.	2024-10-07 16:04:24 +09:00
Dean Herbert	1ab02b93b3	Merge branch 'master' into grids-4	2024-10-07 15:42:23 +09:00
Dean Herbert	5c826be652	Merge pull request #29860 from bdach/fix-nudging ... Only allow seek to next/previous object via keybinding if there is no selection	2024-10-07 15:36:19 +09:00
Dan Balasescu	944f8f5f67	Merge pull request #30078 from CloneWith/update/progresshover ... Add progress tooltip for ArgonSongProgressBar	2024-10-07 15:20:50 +09:00
Dean Herbert	6e4eed657c	Fix weird mouse position handling and don't return true to event	2024-10-07 14:32:31 +09:00
Dean Herbert	b5cc45bdda	Simplify format code (and adjust formatting slightly)	2024-10-07 14:26:42 +09:00
OliBomby	ae8abc7f35	fix readybutton and favouritebutton	2024-10-05 21:46:00 +02:00
OliBomby	ad734b1a13	Revert "Use new keyword instead of overriding TooltipText to remove setter" ... This reverts commit 80dffa905a.	2024-10-05 15:10:36 +02:00
CloneWith	d7ba4ce7f2	Refactor progress tooltip updating method ... * Rewrite calculating logic * Remove useless variables	2024-10-04 23:30:50 +08:00
Bartłomiej Dach	7816c41b94	Only transfer difficulty slider values on commit ... Closes https://github.com/ppy/osu/issues/30112.	2024-10-04 14:08:46 +02:00
Dean Herbert	4fc0aae486	Merge pull request #30108 from bdach/default-combo-colours-in-editor ... Initialise colours section with default combo colours if none present	2024-10-04 18:57:25 +09:00
Bartłomiej Dach	61103cc712	Remove redundant initialiser	2024-10-04 11:18:09 +02:00
Bartłomiej Dach	7cd724f342	Move setup screen background preview to appropriate form control ... See https://discord.com/channels/188630481301012481/188630652340404224/1291361342971707463.	2024-10-04 11:09:14 +02:00
CloneWith	fd5655455a	Adjust tooltip text format	2024-10-04 16:56:16 +08:00
CloneWith	2d7fdaf892	Override OnMouseMove for cursor position fetching	2024-10-04 16:42:48 +08:00
Bartłomiej Dach	6e5a38c6c8	Initialise colours section with default combo colours if none present ... Closes https://github.com/ppy/osu/issues/30100.	2024-10-04 10:01:24 +02:00
Bartłomiej Dach	1bab2236fe	Ensure columns collapse into one correctly if no space	2024-10-03 15:01:23 +02:00
Bartłomiej Dach	99eb26b7d5	Redo the layout of sections based on discord feedback ... See https://discord.com/channels/188630481301012481/188630652340404224/1291358770064130140 and everything after.	2024-10-03 13:53:21 +02:00
Bartłomiej Dach	b15608343b	Replace setup screen controls with new "form" controls	2024-10-03 11:49:03 +02:00
OliBomby	80dffa905a	Use new keyword instead of overriding TooltipText to remove setter	2024-10-03 11:13:49 +02:00
Dean Herbert	24d6ea5444	Change failed states to be considered as NotPlaying	2024-10-03 17:11:41 +09:00
OliBomby	f8397cccc7	Merge remote-tracking branch 'upstream/master' into grids-4	2024-10-01 15:43:54 +02:00
OliBomby	9fa2849b14	Fixed tooltip inheritors of RoundedButton	2024-10-01 15:34:12 +02:00
CloneWith	5dd28d5352	Fix extra newline	2024-10-01 21:08:31 +08:00
CloneWith	5af05f1cc9	Use play length for timestamp calculation	2024-10-01 20:53:15 +08:00
CloneWith	4f16ecdf1b	Add progress tooltip for ArgonSongProgressBar	2024-10-01 20:22:46 +08:00
OliBomby	154a3eebc6	Reset the sample bank states to auto when selection is cleared ... this matches behaviour in stable	2024-10-01 13:22:20 +02:00
OliBomby	1960a0d44d	Add tooltip to explain why addition banks dont work when no additions exist	2024-10-01 13:07:25 +02:00
Dean Herbert	8773c34fdd	Rename enum to non-plural now that it won't conflict	2024-10-01 19:55:46 +09:00
Dean Herbert	8dba4cf760	Passing means NotPlaying	2024-10-01 19:55:31 +09:00
Dean Herbert	54e68005ef	Merge pull request #29691 from bdach/hotkeys-in-context-menus ... Add hotkey hints to editor menus	2024-10-01 19:29:05 +09:00
Dean Herbert	3d54f4a5ab	Make states better defined	2024-10-01 17:53:58 +09:00
Dean Herbert	ad3007eaad	Adjust ILocalUserPlayInfo to expose whether gameplay is in a paused/break state	2024-10-01 17:53:46 +09:00
OliBomby	0a78eb9628	Implement auto additions editor-only	2024-10-01 16:40:48 +09:00
Dean Herbert	1b4215576d	Merge branch 'master' into additions	2024-10-01 16:38:56 +09:00
Dean Herbert	87ab953935	Merge pull request #30062 from bdach/distance-snap-weirdness ... Fix various distance snap grid weirdness around unsnapped objects	2024-10-01 16:16:22 +09:00
Dean Herbert	75745bd95f	Merge branch 'master' into move-already-placed-objects-when-adjusting-offset-bpm	2024-10-01 15:53:13 +09:00
Dean Herbert	590f27e0a0	Merge branch 'master' into hotkeys-in-context-menus	2024-10-01 15:50:19 +09:00
Bartłomiej Dach	11fc1f9a1c	Fix distance snap grid using wrong colour when reference object is unsnapped	2024-09-30 13:36:51 +02:00
Bartłomiej Dach	75fc57c34b	Fix distance spacing grid displaying incorrectly for unsnapped objects with duration	2024-09-30 13:36:16 +02:00
Bartłomiej Dach	5e5bb49cd8	Fix rate change hotkeys sometimes losing track of adjust pitch setting ... Fixes https://osu.ppy.sh/community/forums/topics/1983327. The cause of the bug is a bit convoluted, and stems from the fact that the mod select overlay controls all of the game-global mod instances if present. `ModSpeedHotkeyHandler` would store the last spotted instance of a rate adjust mod - which in this case is a problem, because on deselection of a mod, the mod select overlay resets its settings to defaults: a258059d43/osu.Game/Overlays/Mods/ModSelectOverlay.cs (L424-L425) A way to defend against this is a clone, but this reveals another issue, in that the existing code was *relying* on the reference to the mod remaining the same in any other case, to read the latest valid settings of the mod. This basically only mattered in the edge case wherein Double Time would swap places with Half Time and vice versa (think [0.95,1.05] range). Therefore, track mod settings too explicitly to ensure that the stored clone is as up-to-date as possible.	2024-09-30 08:47:02 +02:00
Dean Herbert	a258059d43	Merge pull request #29918 from bdach/control-drag ... Add to existing selection when dragging with control pressed	2024-09-30 14:00:36 +09:00
Dean Herbert	c46d787f1e	Merge pull request #29949 from minetoblend/feature/scale-around-center ... Support scaling around center when scaling with select box	2024-09-28 21:37:39 +09:00
Bartłomiej Dach	d607331755	Fix control-drag selection expansion deselecting object if control is released over one of the blueprints	2024-09-27 12:15:08 +02:00
Bartłomiej Dach	b45fedc356	Merge branch 'master' into control-drag	2024-09-27 11:39:50 +02:00
Bartłomiej Dach	a00ed8dd77	Merge pull request #29914 from peppy/fix-judgement-counter-sync ... Fix judgement counter not showing correct counts when spectating user mid-play	2024-09-27 10:57:26 +02:00
Bartłomiej Dach	33593280d8	Merge pull request #29938 from OliBomby/selection-center ... Use minimum enclosing circle as selection centre for scale and rotate	2024-09-27 10:46:32 +02:00
Bartłomiej Dach	766d2d2ad2	Merge pull request #29950 from minetoblend/feature/freeze-select-box-buttons ... Freeze select box buttons position on press	2024-09-27 10:13:06 +02:00
Dan Balasescu	73a9b03401	Merge pull request #30018 from peppy/add-missing-shader-preload ... Update shader preloader with missing shader usages	2024-09-27 16:58:15 +09:00
Dean Herbert	1dd6082aa9	Rename method to be more appropriate	2024-09-27 16:56:22 +09:00
Dean Herbert	19a96bcc50	Merge pull request #29967 from bdach/storyboard-full-dim ... Continue displaying storyboard even if fully dimmed in specific circumstances	2024-09-27 16:33:58 +09:00
Bartłomiej Dach	fa90b43233	Merge branch 'master' into selection-center	2024-09-27 09:30:36 +02:00
Dean Herbert	5be63ee304	Reorganise with ruleset shader separated out	2024-09-27 16:19:24 +09:00
Dean Herbert	4205a21c0c	Add one more shader usage	2024-09-27 16:11:24 +09:00
Dean Herbert	b2983e2562	Update shader preloader with missing shader usages	2024-09-27 14:21:20 +09:00
Dean Herbert	5efdc6cdd7	Merge pull request #29936 from u4vh3/skinning-colour-customisation ... Add colour customisation to layout editor	2024-09-27 14:20:58 +09:00
OliBomby	b179e086c6	Merge remote-tracking branch 'upstream/master' into grids-4	2024-09-26 14:59:52 +02:00
Bartłomiej Dach	f16f419928	Merge pull request #29983 from bdach/directory-selector-redesign ... Redesign directory & file selector	2024-09-26 14:14:22 +02:00
OliBomby	e3b4483872	Refactor PlacementBlueprint to not be hitobject specific	2024-09-24 20:31:00 +02:00
Bartłomiej Dach	20e7ade3b0	Fix statistics update not being shown on results screen if it arrives too fast ... As reported in https://discord.com/channels/188630481301012481/1097318920991559880/1288160137286258799.	2024-09-24 17:52:19 +02:00
Marvin Schürz	99a80b399c	Animate SelectionBox buttons on unfreeze	2024-09-24 16:42:37 +02:00
Bartłomiej Dach	9f4e48dde7	Actually use bindables rather than stick things in Update()	2024-09-24 15:15:28 +02:00
Bartłomiej Dach	7f8b64bb6d	Redesign directory & file selector (and update usages accordingly)	2024-09-24 14:54:48 +02:00
Dean Herbert	b7d8cb2371	Merge pull request #29968 from bdach/cache-for-spectate-screen ... Use cache for beatmap lookups on spectate screen	2024-09-24 20:59:33 +09:00
Bartłomiej Dach	4f57a67ea4	Merge branch 'master' into skinning-colour-customisation	2024-09-24 13:02:22 +02:00
Bartłomiej Dach	4c2ebdb2db	Simplify accent colour assignment in argon wedge piece	2024-09-24 12:53:54 +02:00
Marvin Schürz	b54b4063be	Rename parameter	2024-09-24 12:40:28 +02:00
OliBomby	0f0f490598	Don't snap to global grid while placing grid	2024-09-23 17:24:09 +02:00
OliBomby	1a81e12192	Refactor PlacementBlueprint to not be hitobject specific	2024-09-23 16:33:36 +02:00
Bartłomiej Dach	4b349ba387	Use cache for beatmap lookups on spectate screen ... @peppy noticed recently that attempting to spectate just a few users was very likely to end up in requests very quickly being rejected with code 429 ("Too Many Requests"). I'm somewhat certain that the reason for that is that a significant number of players is wont to retry a lot in quick succession. That means that spectator server is going to note a lot of gameplay start and end messages in quick succession, too. And as it turns out, every gameplay start would end up triggering a new beatmap set fetch request: ccf1acce56/osu.Game/Screens/Spectate/SpectatorScreen.cs (L131-L134) ccf1acce56/osu.Game/Screens/Play/SoloSpectatorScreen.cs (L168-L172) ccf1acce56/osu.Game/Screens/Play/SoloSpectatorScreen.cs (L243-L256) To attempt to curtail that, use the beatmap cache instead, which should prevent these unnecessary requests from firing in the first place, therefore reducing the chance of the client getting throttled. This technically means that a different endpoint is used to fetch the data (`GET /beatmaps/?ids[]=` rather than `GET /beatmapsets/lookup?beatmap_id={id}`), but docs claim that both should return the same data, and it looks to work fine in practice.	2024-09-23 12:15:19 +02:00
OliBomby	a9ebfbe431	Assert default origin not null in rotation handle	2024-09-23 11:37:42 +02:00
Bartłomiej Dach	0f758ca25f	Continue displaying storyboard even if fully dimmed in specific circumstances ... Closes https://github.com/ppy/osu/issues/9315. Closes https://github.com/ppy/osu/issues/29867. Notably, this does nothing about https://github.com/ppy/osu/issues/25075, but I'm not sure what to do with that one in the first place.	2024-09-23 11:19:31 +02:00
OliBomby	92b5650ff8	fix outdated comment	2024-09-23 10:56:03 +02:00
Bartłomiej Dach	881c9dfbba	Fix score being cloned in async method causing random errors (again) ... Compare: https://github.com/ppy/osu/pull/24548. I don't have a reproduction scenario (judging from the stack trace of the crash it's likely to be nigh-impossible to concoct a reliable one), but there is some circumstantial evidence that this might help, namely that that previous fix above worked, and the pathway that's failing here is similarly async to the one that pull fixed. So I'm just gonna start with that and hope that it does the job.	2024-09-23 09:51:02 +02:00